Remove use of IceTransportInternal Destroyed signal in remoting [chromium/src : main]
0 views
Skip to first unread message
Tony Herre (Gerrit)
Nov 5, 2025, 4:26:26 AM (2 days ago) Nov 5
to Joe Downing, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Joe Downing
Tony Herre voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Nov 5, 2025, 9:59:42 AM (2 days ago) Nov 5
to Tony Herre, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Tony Herre
Joe Downing voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tony Herre
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tony Herre (Gerrit)
Nov 5, 2025, 10:45:11 AM (2 days ago) Nov 5
to Joe Downing, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Tony Herre voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 5, 2025, 11:00:18 AM (2 days ago) Nov 5
to Tony Herre, Joe Downing, AyeAye, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove use of IceTransportInternal Destroyed signal in remoting
Nothing ever triggers the Destroyed signal, so this is a noop.
The signal itself is being removed in http://issues.webrtc.org/457682036
Bug: None
Change-Id: Ib2a72c44ff6f4224cf49de1b2502ec61d7645b7d
Auto-Submit: Tony Herre <top...@chromium.org>
Reviewed-by: Joe Downing <joe...@chromium.org>
Commit-Queue: Tony Herre <top...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540648}
Files:
- M remoting/protocol/channel_socket_adapter.cc
- M remoting/protocol/channel_socket_adapter.h
Change size: S
Delta: 2 files changed, 0 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Downing
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages