[BAM] Refactor Recent Tabs submenu metrics logging and remove kActionOpenRecentTab [chromium/src : main]
0 views
Skip to first unread message
Kunal Daftari (Gerrit)
6:07 PM (2 hours ago) 6:07 PM
to Darryl James, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Darryl James
Kunal Daftari voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kunal Daftari
| Code-Review | +1 |
1 comment
File chrome/browser/ui/tabs/recent_tabs_sub_menu_model_browsertest.cc
Line 218, Patchset 2 (Latest):
void CallLogMenuMetrics(int command_id) { LogMenuMetrics(command_id); }
void CallLogSubmenuAction(AppMenuAction action_id) {Kunal Daftari . unresolved
nit: can we add a space between these functions.
Related details
Attention is currently required from:
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
6:33 PM (2 hours ago) 6:33 PM
to Kunal Daftari, Chromium LUCI CQ, chromium...@chromium.org
Darryl James added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/tabs/recent_tabs_sub_menu_model_browsertest.cc
Line 218, Patchset 2:
void CallLogMenuMetrics(int command_id) { LogMenuMetrics(command_id); }
void CallLogSubmenuAction(AppMenuAction action_id) {Kunal Daftari . resolved
nit: can we add a space between these functions.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
6:34 PM (2 hours ago) 6:34 PM
to Kunal Daftari, Chromium LUCI CQ, chromium...@chromium.org
Darryl James voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages