ASH Refactoring: Move 57 login-related strings to ash/ (Part 2) [chromium/src : main]

0 views
Skip to first unread message

Yoshiki IGUCHI (Gerrit)

unread,
Jun 15, 2026, 2:43:19 AMJun 15
to Yoshiki IGUCHI, Chromium LUCI CQ, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Yoshiki IGUCHI

Message from Yoshiki IGUCHI

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Yoshiki IGUCHI
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0807c272abdaaa098e037ddbd1131188cec4cdff
Gerrit-Change-Number: 7932710
Gerrit-PatchSet: 11
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Attention: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Jun 2026 06:42:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yoshiki IGUCHI (Gerrit)

unread,
Jun 15, 2026, 2:43:36 AMJun 15
to Yoshiki IGUCHI, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Hidehiko Abe

Yoshiki IGUCHI added 1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Yoshiki IGUCHI . resolved

Hidehiko-san, PTAL. Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0807c272abdaaa098e037ddbd1131188cec4cdff
Gerrit-Change-Number: 7932710
Gerrit-PatchSet: 11
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-CC: Di Wu <di...@google.com>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Jun 2026 06:43:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Jun 18, 2026, 2:11:29 AM (12 days ago) Jun 18
to Yoshiki IGUCHI, Chromium LUCI CQ, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Yoshiki IGUCHI

Hidehiko Abe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yoshiki IGUCHI
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0807c272abdaaa098e037ddbd1131188cec4cdff
Gerrit-Change-Number: 7932710
Gerrit-PatchSet: 11
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-CC: Di Wu <di...@google.com>
Gerrit-Attention: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 06:10:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Yoshiki IGUCHI (Gerrit)

unread,
Jun 18, 2026, 3:01:04 AM (12 days ago) Jun 18
to Yoshiki IGUCHI, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org

Yoshiki IGUCHI voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0807c272abdaaa098e037ddbd1131188cec4cdff
Gerrit-Change-Number: 7932710
Gerrit-PatchSet: 11
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-CC: Di Wu <di...@google.com>
Gerrit-Comment-Date: Thu, 18 Jun 2026 07:00:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 18, 2026, 4:11:27 AM (12 days ago) Jun 18
to Yoshiki IGUCHI, Hidehiko Abe, Di Wu, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
ASH Refactoring: Move 57 login-related strings to ash/ (Part 2)

Move 57 login-related strings from chrome/app/chromeos_strings.grdp
to ash/login/resources/login_strings.grd.

Moved strings:
- IDS_AI_INTRO_SELECTED_BUTTON_LABEL
- IDS_AI_INTRO_SLIDE_BACKGROUND_TEXT
- IDS_AI_INTRO_SLIDE_BACKGROUND_TITLE
- IDS_AI_INTRO_SLIDE_IMAGE_TEXT
- IDS_AI_INTRO_SLIDE_IMAGE_TITLE
- IDS_AI_INTRO_SLIDE_LABEL
- IDS_AI_INTRO_SLIDE_READ_TEXT
- IDS_AI_INTRO_SLIDE_READ_TITLE
- IDS_AI_INTRO_SLIDE_WALLPAPER_TEXT
- IDS_AI_INTRO_SLIDE_WALLPAPER_TITLE
- IDS_AI_INTRO_SLIDE_WRITE_TEXT
- IDS_AI_INTRO_SLIDE_WRITE_TITLE
- IDS_AI_INTRO_SUBTITLE
- IDS_AI_INTRO_TITLE
- IDS_AI_INTRO_UNSELECTED_BUTTON_LABEL
- IDS_GEMINI_INTRO_SUBTITLE
- IDS_GEMINI_INTRO_TITLE
- IDS_LOGIN_GET_STARTED
- IDS_LOGIN_MARKETING_OPT_IN_SCREEN_GET_CHROMEBOOK_UPDATES_SIGN_ME_UP
- IDS_LOGIN_MARKETING_OPT_IN_SCREEN_SUBTITLE
- IDS_LOGIN_MARKETING_OPT_IN_SCREEN_SUBTITLE_WITH_DEVICE_NAME
- IDS_LOGIN_MARKETING_OPT_IN_SCREEN_TITLE
- IDS_LOGIN_MARKETING_OPT_IN_SCREEN_UNSUBSCRIBE_LONG
- IDS_LOGIN_MARKETING_OPT_IN_SCREEN_UNSUBSCRIBE_SHORT
- IDS_LOGIN_MARKETING_OPT_IN_SCREEN_WITH_CLOUDGAMINGDEVICE_SIGN_ME_UP
- IDS_LOGIN_MARKETING_OPT_IN_SCREEN_WITH_CLOUDGAMINGDEVICE_SUBTITLE
- IDS_LOGIN_MARKETING_OPT_IN_SCREEN_WITH_CLOUDGAMINGDEVICE_TITLE
- IDS_LOGIN_QUICK_START_ACCOUNT_TRANSFER_STEP_SUBTITLE
- IDS_LOGIN_QUICK_START_ACCOUNT_TRANSFER_STEP_TITLE
- IDS_LOGIN_QUICK_START_BLUETOOTH_DIALOG_CANCEL
- IDS_LOGIN_QUICK_START_BLUETOOTH_DIALOG_CONTENT
- IDS_LOGIN_QUICK_START_BLUETOOTH_DIALOG_ENABLE
- IDS_LOGIN_QUICK_START_BLUETOOTH_DIALOG_TITLE
- IDS_LOGIN_QUICK_START_CONFIRM_ACCOUNT_SUBTITLE
- IDS_LOGIN_QUICK_START_CONFIRM_ACCOUNT_TITLE
- IDS_LOGIN_QUICK_START_NETWORK_NEEDED_SUBTITLE
- IDS_LOGIN_QUICK_START_RESUME_AFTER_REBOOT_SUBTITLE
- IDS_LOGIN_QUICK_START_RESUME_AFTER_REBOOT_TITLE
- IDS_LOGIN_QUICK_START_SETUP
- IDS_LOGIN_QUICK_START_SETUP_COMPLETE_STEP_SUBTITLE_BOTH
- IDS_LOGIN_QUICK_START_SETUP_COMPLETE_STEP_SUBTITLE_SIGNED_IN
- IDS_LOGIN_QUICK_START_SETUP_COMPLETE_STEP_TITLE
- IDS_LOGIN_QUICK_START_SETUP_CONTENT_FOOTER_FOLLOW_INSTRUCTIONS_PIN
- IDS_LOGIN_QUICK_START_SETUP_CONTENT_FOOTER_FOLLOW_INSTRUCTIONS_QR
- IDS_LOGIN_QUICK_START_SETUP_CONTENT_FOOTER_TURN_ON_WIFI_AND_BLT
- IDS_LOGIN_QUICK_START_SETUP_FROM_SIGNIN_SCREEN_SUBTITLE
- IDS_LOGIN_QUICK_START_SETUP_FROM_SIGNIN_SCREEN_TITLE
- IDS_LOGIN_QUICK_START_SETUP_NETWORK_SCREEN_ENTRY_POINT
- IDS_LOGIN_QUICK_START_SETUP_PIN_TITLE
- IDS_LOGIN_QUICK_START_SETUP_QR_TITLE
- IDS_LOGIN_QUICK_START_SETUP_SIGNIN_SCREEN_ENTRY_POINT
- IDS_LOGIN_QUICK_START_SETUP_SUBTITLE
- IDS_LOGIN_QUICK_START_SETUP_SUBTITLE_ACCOUNT_ONLY
- IDS_LOGIN_QUICK_START_WIFI_ERROR_SUBTITLE
- IDS_LOGIN_QUICK_START_WIFI_ERROR_TITLE
- IDS_LOGIN_QUICK_START_WIFI_TRANSFER_SUBTITLE
- IDS_LOGIN_QUICK_START_WIFI_TRANSFER_TITLE

Also move 56 string image files from
chrome/app/chromeos_strings_grdp to ash/login/resources/login_strings_grd.
Bug: 487122295
Test: CQ passes
Skip-Translation-Screenshots-Check: True
Change-Id: I0807c272abdaaa098e037ddbd1131188cec4cdff
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Commit-Queue: Yoshiki IGUCHI <yos...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648853}
Files:
  • M ash/login/resources/login_strings.grd
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SELECTED_BUTTON_LABEL.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_BACKGROUND_TEXT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_BACKGROUND_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_IMAGE_TEXT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_IMAGE_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_LABEL.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_READ_TEXT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_READ_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_WALLPAPER_TEXT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_WALLPAPER_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_WRITE_TEXT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SLIDE_WRITE_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_AI_INTRO_UNSELECTED_BUTTON_LABEL.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_GEMINI_INTRO_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_GEMINI_INTRO_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_GET_STARTED.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_MARKETING_OPT_IN_SCREEN_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_MARKETING_OPT_IN_SCREEN_SUBTITLE_WITH_DEVICE_NAME.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_MARKETING_OPT_IN_SCREEN_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_MARKETING_OPT_IN_SCREEN_UNSUBSCRIBE_LONG.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_MARKETING_OPT_IN_SCREEN_UNSUBSCRIBE_SHORT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_MARKETING_OPT_IN_SCREEN_WITH_CLOUDGAMINGDEVICE_SIGN_ME_UP.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_MARKETING_OPT_IN_SCREEN_WITH_CLOUDGAMINGDEVICE_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_MARKETING_OPT_IN_SCREEN_WITH_CLOUDGAMINGDEVICE_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_ACCOUNT_TRANSFER_STEP_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_ACCOUNT_TRANSFER_STEP_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_BLUETOOTH_DIALOG_CANCEL.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_BLUETOOTH_DIALOG_CONTENT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_BLUETOOTH_DIALOG_ENABLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_BLUETOOTH_DIALOG_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_CONFIRM_ACCOUNT_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_CONFIRM_ACCOUNT_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_NETWORK_NEEDED_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_RESUME_AFTER_REBOOT_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_RESUME_AFTER_REBOOT_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_COMPLETE_STEP_SUBTITLE_BOTH.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_COMPLETE_STEP_SUBTITLE_SIGNED_IN.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_COMPLETE_STEP_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_CONTENT_FOOTER_FOLLOW_INSTRUCTIONS_PIN.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_CONTENT_FOOTER_FOLLOW_INSTRUCTIONS_QR.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_CONTENT_FOOTER_TURN_ON_WIFI_AND_BLT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_FROM_SIGNIN_SCREEN_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_FROM_SIGNIN_SCREEN_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_NETWORK_SCREEN_ENTRY_POINT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_PIN_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_QR_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_SIGNIN_SCREEN_ENTRY_POINT.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_SETUP_SUBTITLE_ACCOUNT_ONLY.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_WIFI_ERROR_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_WIFI_ERROR_TITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_WIFI_TRANSFER_SUBTITLE.png.sha1
  • R ash/login/resources/login_strings_grd/IDS_LOGIN_QUICK_START_WIFI_TRANSFER_TITLE.png.sha1
  • M chrome/app/chromeos_strings.grdp
  • M chrome/browser/ash/login/demo_mode/BUILD.gn
  • M chrome/browser/ash/login/demo_mode/demo_setup_browsertest.cc
  • M chrome/browser/ash/login/screens/network_screen_browsertest.cc
  • M chrome/browser/ash/login/screens/quick_start_screen_browsertest.cc
  • M chrome/browser/ui/webui/ash/login/ai_intro_screen_handler.cc
  • M chrome/browser/ui/webui/ash/login/gaia_screen_handler.cc
  • M chrome/browser/ui/webui/ash/login/gemini_intro_screen_handler.cc
  • M chrome/browser/ui/webui/ash/login/marketing_opt_in_screen_handler.cc
  • M chrome/browser/ui/webui/ash/login/network_screen_handler.cc
  • M chrome/browser/ui/webui/ash/login/quick_start_screen_handler.cc
  • M chrome/browser/ui/webui/ash/login/welcome_screen_handler.cc
Change size: L
Delta: 69 files changed, 199 insertions(+), 188 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Hidehiko Abe
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0807c272abdaaa098e037ddbd1131188cec4cdff
Gerrit-Change-Number: 7932710
Gerrit-PatchSet: 12
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages