net: Allow multiple HTTPS completions in DnsTaskResultsManager [chromium/src : main]
Kenichi Ishibashi (Gerrit)
Kenichi Ishibashi added 1 comment![]( "Open in Gerrit")
if (!is_metadata_ready_) {I don't think we can simply do this. `is_metadata_ready == true` means all endpoints are ready to start cryptographic handshakes. (See ServiceEndpointRequest::EndpointsCryptoReady).
If we support follow-up HTTPS queries, endpoints may have different states about crypto handshake readyness. Probably we need separate state per endpoint regarding EndpointsCryptoReady, which requires API surface changes. Also, HttpStreamPool::AttemptManager, which uses the API, assumes that once EndpointsCryptoReady() returns true all endpoints are crypto ready. We need to update AttemptManager as well.
Related details
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 1 comment![]( "Open in Gerrit")
if (!is_metadata_ready_) {I don't think we can simply do this. `is_metadata_ready == true` means all endpoints are ready to start cryptographic handshakes. (See ServiceEndpointRequest::EndpointsCryptoReady).
If we support follow-up HTTPS queries, endpoints may have different states about crypto handshake readyness. Probably we need separate state per endpoint regarding EndpointsCryptoReady, which requires API surface changes. Also, HttpStreamPool::AttemptManager, which uses the API, assumes that once EndpointsCryptoReady() returns true all endpoints are crypto ready. We need to update AttemptManager as well.
addressed this properly in https://crrev.com/c/7543703 which replaces `is_metadata_ready_` with `https_response_received_` and gates `IsMetadataReady()` on `HasPendingMetadqataTargets()`. it only returns true when all metadata target names have resolved addresses. Abandoning this CL in favor of that one.
Related details
- Kenichi Ishibashi
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka abandoned this change.
Helmut Januschka abandoned this change![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |