[NTP Customization for MVT] Fix the accessibility string [chromium/src : main]
0 views
Skip to first unread message
Yanling Hu (Gerrit)
Sep 24, 2025, 1:09:44 PM (3 days ago) Sep 24
to Xi Han, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Xi Han
Yanling Hu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Xi Han
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xi Han (Gerrit)
Sep 24, 2025, 1:30:10 PM (3 days ago) Sep 24
to Yanling Hu, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Yanling Hu
Xi Han added 1 comment![]( "Open in Gerrit")
File components/browser_ui/strings/android/browser_ui_strings.grd
Line 1366, Patchset 2 (Latest):
my shortcuts bottom sheet opened at half heightXi Han . unresolved
Can you fix this one too?
Related details
Attention is currently required from:
- Yanling Hu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yanling Hu (Gerrit)
Sep 25, 2025, 12:25:29 PM (2 days ago) Sep 25
to Xi Han, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Xi Han
Yanling Hu added 1 comment![]( "Open in Gerrit")
File components/browser_ui/strings/android/browser_ui_strings.grd
Can you fix this one too?
Attention is currently required from:
- Xi Han
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xi Han (Gerrit)
Sep 25, 2025, 1:35:27 PM (2 days ago) Sep 25
to Yanling Hu, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Yanling Hu
Xi Han voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Yanling Hu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yanling Hu (Gerrit)
Sep 25, 2025, 2:02:38 PM (2 days ago) Sep 25
to Xi Han, Chromium LUCI CQ, chromium...@chromium.org
Yanling Hu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 25, 2025, 2:05:34 PM (2 days ago) Sep 25
to Yanling Hu, Xi Han, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[NTP Customization for MVT] Fix the accessibility string
This CL updates the accessibility string for the "My shortcuts" bottom
sheet, as requested by the localization query at
https://localizer.google.com/query/14957155?notificationId=594e9625-2576-410c-a5d1-64fcb809105e.
Bug: 421436204
Change-Id: I78052955d19d620939db1a7fcf0a75f979566351
Commit-Queue: Yanling Hu <yanl...@google.com>
Reviewed-by: Xi Han <ha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520748}
Files:
- M components/browser_ui/strings/android/browser_ui_strings.grd
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Xi Han
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages