Dismantle VirtualKeyboardFloatingDefault flag. [chromium/src : main]

Bao-Duy Tran (Gerrit)

unread,

Jul 25, 2021, 10:48:57 PM7/25/21

to chromium-a...@chromium.org, extension...@chromium.org, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: David Vallet.

Patch set 1:Auto-Submit +1Commit-Queue +1

View Change

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Bao-Duy Tran (Gerrit)

unread,

Jul 29, 2021, 2:24:05 AM7/29/21

to chromium-a...@chromium.org, extension...@chromium.org, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: David Vallet.

View Change

1 comment:

Patchset:
- Patch Set #1:
  Friendly ping @ dvallet

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Jun Sheng (Gerrit)

unread,

Jul 31, 2021, 9:46:42 PM7/31/21

to Bao-Duy Tran, chromium-a...@chromium.org, extension...@chromium.org, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Bao-Duy Tran, David Vallet.

View Change

1 comment:

Patchset:
- Patch Set #1:
  Just a fyi, looks like VK is no longer reading this flag, which broke Tast test inputs.VirtualKeyboardFloat*
  http://tastboard/test/inputs.VirtualKeyboardFloat.stable
  I will fix this test.

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Bao-Duy Tran (Gerrit)

unread,

Aug 1, 2021, 9:59:23 PM8/1/21

to chromium-a...@chromium.org, extension...@chromium.org, Darren Shen, Jun Sheng, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Darren Shen, David Vallet.

Patch set 2:Auto-Submit +1

View Change

1 comment:

Patchset:
- Patch Set #2:
  R: +shend for OWNERS chrome_virtual_keyboard_delegate.cc

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Bao-Duy Tran (Gerrit)

unread,

Aug 1, 2021, 9:59:36 PM8/1/21

to chromium-a...@chromium.org, extension...@chromium.org, Darren Shen, Jun Sheng, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Darren Shen, David Vallet.

Bao-Duy Tran removed a vote from this change.

View Change

Removed Auto-Submit+1 by Bao-Duy Tran <tranb...@chromium.org>

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Bao-Duy Tran (Gerrit)

unread,

Aug 1, 2021, 9:59:55 PM8/1/21

to chromium-a...@chromium.org, extension...@chromium.org, Darren Shen, Jun Sheng, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Darren Shen, David Vallet.

Patch set 2:Commit-Queue +1

View Change

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Darren Shen (Gerrit)

unread,

Aug 1, 2021, 10:21:44 PM8/1/21

to Bao-Duy Tran, chromium-a...@chromium.org, extension...@chromium.org, Jun Sheng, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Bao-Duy Tran, Jun Sheng, David Vallet.

View Change

1 comment:

Patchset:
- Patch Set #2:
  I think this flag might be used by our Tast tests. Jun, can you confirm? Thanks.

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Jun Sheng (Gerrit)

unread,

Aug 1, 2021, 11:10:30 PM8/1/21

to Bao-Duy Tran, chromium-a...@chromium.org, extension...@chromium.org, Darren Shen, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Bao-Duy Tran, David Vallet.

View Change

1 comment:

Patchset:
- Patch Set #2:
  Yes. https://crrev.com/c/3065240 is fixing the tast test.

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Jun Sheng (Gerrit)

unread,

Aug 1, 2021, 11:11:41 PM8/1/21

to Bao-Duy Tran, chromium-a...@chromium.org, extension...@chromium.org, Darren Shen, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Bao-Duy Tran, David Vallet.

View Change

1 comment:

Patchset:
- Patch Set #2:
  Sadly, I do not have any permission to code review on chromium. So remove myself.

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Bao-Duy Tran (Gerrit)

unread,

Aug 2, 2021, 12:37:02 AM8/2/21

to chromium-a...@chromium.org, extension...@chromium.org, Darren Shen, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Darren Shen, David Vallet.

View Change

1 comment:

Patchset:
- Patch Set #2:
  I think this flag might be used by our Tast tests. Jun, can you confirm? Thanks.
  Resolved. From shengjun@: "Yes. https://crrev.com/c/3065240 is fixing the tast test."

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Darren Shen (Gerrit)

unread,

Aug 2, 2021, 12:46:01 AM8/2/21

to Bao-Duy Tran, chromium-a...@chromium.org, extension...@chromium.org, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Bao-Duy Tran, David Vallet.

Patch set 2:Code-Review +1

View Change

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Darren Shen (Gerrit)

unread,

Aug 2, 2021, 12:46:20 AM8/2/21

to Bao-Duy Tran, chromium-a...@chromium.org, extension...@chromium.org, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Bao-Duy Tran, David Vallet.

View Change

1 comment:

Patchset:
- Patch Set #2:
  Resolved. From shengjun@: "Yes. https://crrev.com/c/3065240 is fixing the tast test. […]
  Thanks!

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Bao-Duy Tran (Gerrit)

unread,

Aug 2, 2021, 8:28:49 PM8/2/21

to chromium-a...@chromium.org, extension...@chromium.org, Darren Shen, Chromium LUCI CQ, David Vallet, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: David Vallet.

View Change

1 comment:

Patchset:
- Patch Set #2:
  friendly ping @ dvallet :-D

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

David Vallet (Gerrit)

unread,

Aug 4, 2021, 2:42:31 AM8/4/21

to Bao-Duy Tran, chromium-a...@chromium.org, extension...@chromium.org, Darren Shen, Chromium LUCI CQ, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Bao-Duy Tran.

Patch set 2:Code-Review +1

View Change

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Bao-Duy Tran (Gerrit)

unread,

Aug 4, 2021, 8:51:05 PM8/4/21

to chromium-a...@chromium.org, extension...@chromium.org, David Vallet, Darren Shen, Chromium LUCI CQ, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Attention is currently required from: Bao-Duy Tran.

Patch set 3:Commit-Queue +2

View Change

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Aug 4, 2021, 9:47:14 PM8/4/21

to Bao-Duy Tran, chromium-a...@chromium.org, extension...@chromium.org, David Vallet, Darren Shen, chromium...@chromium.org, Kalyan Kondapally, Sadrul Chowdhury

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  David Vallet: Looks good to me
  Darren Shen: Looks good to me
  Bao-Duy Tran: Commit

Dismantle VirtualKeyboardFloatingDefault flag.

BUG=1232846

Change-Id: I860528d9f05d3e9b64c82a8345dbf465c5caddf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3053232
Commit-Queue: Bao-Duy Tran <tranb...@chromium.org>
Reviewed-by: Darren Shen <sh...@chromium.org>
Reviewed-by: David Vallet <dva...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908719}
---
M ash/constants/ash_features.cc
M ash/constants/ash_features.h
M chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
3 files changed, 0 insertions(+), 11 deletions(-)

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

The name of the file: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
Insertions: 3, Deletions: 0.

```
@@ +531:534 @@
+    features.Append(GenerateFeatureFlag(
+        "stylushandwriting",
+        base::FeatureList::IsEnabled(chromeos::features::kImeStylusHandwriting)));

```

To view, visit change 3053232. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward