[WebAudio] Enforce speaker-selection permissions policy in setSinkId [chromium/src : main]

0 views
Skip to first unread message

Hongchan Choi (Gerrit)

unread,
Jul 20, 2026, 1:07:40 PM (yesterday) Jul 20
to Guido Urdaneta, chromium...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Guido Urdaneta

Hongchan Choi added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Hongchan Choi . resolved

PTAL

I am not super familiar with the "audio_output_authorization" part. Please let me know if the approach is way off from what needs to be fixed.

Thank you, Guido!

Open in Gerrit

Related details

Attention is currently required from:
  • Guido Urdaneta
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I990a01ad8472ce652619e21ab8b980c20fa8fb70
Gerrit-Change-Number: 8117150
Gerrit-PatchSet: 1
Gerrit-Owner: Hongchan Choi <hong...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Jul 2026 17:07:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Guido Urdaneta (Gerrit)

unread,
5:47 AM (13 hours ago) 5:47 AM
to Hongchan Choi, chromium...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Hongchan Choi

Guido Urdaneta voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hongchan Choi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I990a01ad8472ce652619e21ab8b980c20fa8fb70
Gerrit-Change-Number: 8117150
Gerrit-PatchSet: 1
Gerrit-Owner: Hongchan Choi <hong...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-Attention: Hongchan Choi <hong...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Jul 2026 09:47:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Blink W3C Test Autoroller (Gerrit)

unread,
5:57 AM (13 hours ago) 5:57 AM
to Hongchan Choi, Guido Urdaneta, chromium...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Hongchan Choi

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61437.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:
  • Hongchan Choi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I990a01ad8472ce652619e21ab8b980c20fa8fb70
Gerrit-Change-Number: 8117150
Gerrit-PatchSet: 1
Gerrit-Owner: Hongchan Choi <hong...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-Attention: Hongchan Choi <hong...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Jul 2026 09:57:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Hongchan Choi (Gerrit)

unread,
10:06 AM (9 hours ago) 10:06 AM
to Blink W3C Test Autoroller, Guido Urdaneta, chromium...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org

Hongchan Choi voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I990a01ad8472ce652619e21ab8b980c20fa8fb70
Gerrit-Change-Number: 8117150
Gerrit-PatchSet: 1
Gerrit-Owner: Hongchan Choi <hong...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Jul 2026 14:06:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages