[DownloadBubble] Add browsertest for download bubble [chromium/src : main]

unread,

Jul 2, 2022, 1:10:51 AMJul 2

to bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Xinghui Lu.

Patch set 2:Commit-Queue +1

To view, visit change 3741608. To unsubscribe, or for help writing mail filters, visit settings.

unread,

Jul 11, 2022, 5:27:42 PMJul 11

to Rohit Bhatia, bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Rohit Bhatia.

1 comment:

Patchset:
- Patch Set #3:
  Is this a reland of https://crrev.com/c/3633188? Could you clarify the root cause and the fix in the CL description?

To view, visit change 3741608. To unsubscribe, or for help writing mail filters, visit settings.

unread,

Jul 13, 2022, 2:54:35 PMJul 13

to bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Xinghui Lu.

1 comment:

Patchset:
- Patch Set #3:
  Is this a reland of https://crrev. […]
  Yes, I am unable to reproduce the build failure though, both on trybots and swarm.
  The stack traces from flakes indicate the issue is of a timeout while waiting for the bubble to be created. I have simplified the browsertest to simpler test cases, and creating the quit closure that signals bubble creation before starting the download itself. Updated this in CL description too.

To view, visit change 3741608. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward