[DownloadBubble] Add browsertest for download bubble [chromium/src : main]

0 views
Skip to first unread message

Rohit Bhatia (Gerrit)

unread,
Jul 2, 2022, 1:10:51 AMJul 2
to bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Xinghui Lu.

Patch set 2:Commit-Queue +1

View Change

    To view, visit change 3741608. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I48011f692784d5ae3b19dc1af445c32d8bea4f73
    Gerrit-Change-Number: 3741608
    Gerrit-PatchSet: 2
    Gerrit-Owner: Rohit Bhatia <bhati...@google.com>
    Gerrit-Reviewer: Rohit Bhatia <bhati...@google.com>
    Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
    Gerrit-Attention: Xinghui Lu <xing...@chromium.org>
    Gerrit-Comment-Date: Sat, 02 Jul 2022 05:10:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Xinghui Lu (Gerrit)

    unread,
    Jul 11, 2022, 5:27:42 PMJul 11
    to Rohit Bhatia, bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Rohit Bhatia.

    View Change

    1 comment:

    To view, visit change 3741608. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I48011f692784d5ae3b19dc1af445c32d8bea4f73
    Gerrit-Change-Number: 3741608
    Gerrit-PatchSet: 3
    Gerrit-Owner: Rohit Bhatia <bhati...@google.com>
    Gerrit-Reviewer: Rohit Bhatia <bhati...@google.com>
    Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
    Gerrit-Attention: Rohit Bhatia <bhati...@google.com>
    Gerrit-Comment-Date: Mon, 11 Jul 2022 21:27:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Rohit Bhatia (Gerrit)

    unread,
    Jul 13, 2022, 2:54:35 PMJul 13
    to bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Xinghui Lu.

    View Change

    1 comment:

    • Patchset:

      • Patch Set #3:

        Is this a reland of https://crrev. […]

        Yes, I am unable to reproduce the build failure though, both on trybots and swarm.

        The stack traces from flakes indicate the issue is of a timeout while waiting for the bubble to be created. I have simplified the browsertest to simpler test cases, and creating the quit closure that signals bubble creation before starting the download itself. Updated this in CL description too.

    To view, visit change 3741608. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I48011f692784d5ae3b19dc1af445c32d8bea4f73
    Gerrit-Change-Number: 3741608
    Gerrit-PatchSet: 4
    Gerrit-Owner: Rohit Bhatia <bhati...@google.com>
    Gerrit-Reviewer: Rohit Bhatia <bhati...@google.com>
    Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
    Gerrit-Attention: Xinghui Lu <xing...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 Jul 2022 18:54:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Xinghui Lu <xing...@chromium.org>
    Gerrit-MessageType: comment
    Reply all
    Reply to author
    Forward
    0 new messages