Use chrome client to retrieve cobalt controller [chromium/src : main]

0 views
Skip to first unread message

Quentin Pubert (Gerrit)

unread,
Apr 10, 2026, 5:34:21 AM (3 days ago) Apr 10
to Olivier Robin, chromium...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Olivier Robin

Quentin Pubert voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Robin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a95b889855c3c87b8014d60e1176ce900f739f9
Gerrit-Change-Number: 7746004
Gerrit-PatchSet: 3
Gerrit-Owner: Olivier Robin <olivie...@chromium.org>
Gerrit-Reviewer: Quentin Pubert <qpu...@google.com>
Gerrit-Attention: Olivier Robin <olivie...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Apr 2026 09:34:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sylvain Defresne (Gerrit)

unread,
6:25 AM (2 hours ago) 6:25 AM
to Olivier Robin, Quentin Pubert, chromium...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Olivier Robin

Sylvain Defresne added 1 comment

File ios/public/provider/chrome/browser/cobalt/cobalt_api.h
Line 60, Patchset 3 (Latest):void* GetCobaltController(ProfileIOS* profile);
Sylvain Defresne . unresolved

I really do not like returning this as a `void*`.

Can we give a name to this type instead? `void*` is quite tricky to use.

Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Robin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0a95b889855c3c87b8014d60e1176ce900f739f9
    Gerrit-Change-Number: 7746004
    Gerrit-PatchSet: 3
    Gerrit-Owner: Olivier Robin <olivie...@chromium.org>
    Gerrit-Reviewer: Quentin Pubert <qpu...@google.com>
    Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Attention: Olivier Robin <olivie...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 10:25:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sylvain Defresne (Gerrit)

    unread,
    6:27 AM (2 hours ago) 6:27 AM
    to Olivier Robin, Quentin Pubert, chromium...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Olivier Robin

    Sylvain Defresne added 1 comment

    File ios/public/provider/chrome/browser/cobalt/cobalt_api.h
    Line 60, Patchset 3 (Latest):void* GetCobaltController(ProfileIOS* profile);
    Sylvain Defresne . unresolved

    I really do not like returning this as a `void*`.

    Can we give a name to this type instead? `void*` is quite tricky to use.

    Sylvain Defresne

    By this I mean, expose a `CobaltController` type and return a `CobaltController*` here. Then in the implementation use this type.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Olivier Robin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0a95b889855c3c87b8014d60e1176ce900f739f9
    Gerrit-Change-Number: 7746004
    Gerrit-PatchSet: 3
    Gerrit-Owner: Olivier Robin <olivie...@chromium.org>
    Gerrit-Reviewer: Quentin Pubert <qpu...@google.com>
    Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Attention: Olivier Robin <olivie...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 10:26:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Sylvain Defresne <sdef...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Olivier Robin (Gerrit)

    unread,
    7:58 AM (23 minutes ago) 7:58 AM
    to Sylvain Defresne, Quentin Pubert, chromium...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Sylvain Defresne

    Olivier Robin added 1 comment

    File ios/public/provider/chrome/browser/cobalt/cobalt_api.h
    Line 60, Patchset 3 (Latest):void* GetCobaltController(ProfileIOS* profile);
    Sylvain Defresne . unresolved

    I really do not like returning this as a `void*`.

    Can we give a name to this type instead? `void*` is quite tricky to use.

    Sylvain Defresne

    By this I mean, expose a `CobaltController` type and return a `CobaltController*` here. Then in the implementation use this type.

    Olivier Robin

    The question is where to define the CobaltController?
    ios/web/web_state/ui/wk_web_view_configuration_provider.mm will need to depend on it to, so I guess the only place it can be defined is in ios/web/public? Maybe in the WebClient header?

    Or maybe ios/public/provider/web/cobalt_api.h is accessible from everywhere and we can define the CobaltController there?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sylvain Defresne
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0a95b889855c3c87b8014d60e1176ce900f739f9
    Gerrit-Change-Number: 7746004
    Gerrit-PatchSet: 3
    Gerrit-Owner: Olivier Robin <olivie...@chromium.org>
    Gerrit-Reviewer: Quentin Pubert <qpu...@google.com>
    Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 11:58:29 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages