Etienne Pierre-Doray (Gerrit)

unread,

Dec 19, 2025, 1:21:21 PM12/19/25

to Kentaro Hara, Raphael Kubo da Costa, devtools...@chromium.org, Stephen Chenney, Olga Gerchikov, chromium...@chromium.org, Hiroki Nakagawa, Nate Chapin, Yoav Weiss (@Shopify), Menard, Alexis, Dirk Schulze, Daniel Cheng, kinuko...@chromium.org, blink-rev...@chromium.org, loading-re...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, gavinp...@chromium.org, fmalit...@chromium.org, devtools-re...@chromium.org, blink-revie...@chromium.org, servicewor...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, hiroshig...@chromium.org, drott+bl...@chromium.org, kouhei...@chromium.org, storage...@chromium.org, blink-revie...@chromium.org, loading...@chromium.org, blink-...@chromium.org, loading-rev...@chromium.org, fserb...@chromium.org, shimazu+se...@chromium.org, blink-reviews-p...@chromium.org, dom+...@chromium.org

Attention needed from Kentaro Hara

Etienne Pierre-Doray has uploaded the change for review

Etienne Pierre-Doray would like Kentaro Hara to review this change.

Commit message

[tracing] Migrate legacy flow macros in third_party/blink

Migrating the following flow event macros somewhat mechanically:
```
- TRACE_EVENT_FLOW[012](<category_group>, <name>, <flag>, <id>, ...)
-> TRACE_EVENT(<category_group>, <name>, <flow_type>::<id_type>, ...)
```

This CL was uploaded by git cl split.

R=har...@chromium.org

Bug: 432427382

Change-Id: Id2285e1428555f5519d5ade9a2bdba769285a48f

Change diff

Change information

Files:

M third_party/blink/common/loader/throttling_url_loader.cc
M third_party/blink/renderer/bindings/core/v8/script_cache_consumer.cc
M third_party/blink/renderer/bindings/core/v8/script_streamer.cc
M third_party/blink/renderer/core/animation_frame/worker_animation_frame_provider.cc
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/frame/remote_frame.cc
M third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
M third_party/blink/renderer/core/html/parser/html_document_parser.cc
M third_party/blink/renderer/core/html/parser/html_preload_scanner.cc
M third_party/blink/renderer/core/inspector/devtools_session.cc
M third_party/blink/renderer/core/loader/document_loader.cc
M third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
M third_party/blink/renderer/core/script/classic_pending_script.cc
M third_party/blink/renderer/core/script/html_parser_script_runner.cc
M third_party/blink/renderer/modules/cache_storage/cache.cc
M third_party/blink/renderer/modules/cache_storage/cache_storage.cc
M third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc
M third_party/blink/renderer/modules/delegated_ink/delegated_ink_trail_presenter.cc
M third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
M third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
M third_party/blink/renderer/platform/loader/fetch/url_loader/url_loader.cc
M third_party/blink/renderer/platform/widget/compositing/render_frame_metadata_observer_impl.cc
M third_party/blink/renderer/platform/widget/widget_base.cc

Change size: XL

Delta: 23 files changed, 558 insertions(+), 696 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Kentaro Hara

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

AI Code Reviewer (Gerrit)

unread,

Dec 19, 2025, 1:23:15 PM12/19/25

to Etienne Pierre-Doray, Kentaro Hara, Menard, Alexis, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, Stephen Chenney, Yoav Weiss (@Shopify), blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Kentaro Hara

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/html/parser/html_document_parser.cc

Line 504, Patchset 1 (Latest): perfetto::Flow::FromPointer(this), "parser", (void*)this);

AI Code Reviewer . unresolved

nit: Use C++-style casts (e.g. `static_cast<void*>(this)`) instead of C-style casts. (Google C++ Style Guide: Casting)

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:

Kentaro Hara

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kentaro Hara (Gerrit)

unread,

Jan 16, 2026, 4:15:51 PM (21 hours ago) Jan 16

to Etienne Pierre-Doray, Chromium LUCI CQ, AI Code Reviewer, Menard, Alexis, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, Stephen Chenney, Yoav Weiss (@Shopify), blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Etienne Pierre-Doray

Kentaro Hara voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

8:16 AM (4 hours ago) 8:16 AM

to Kentaro Hara, Chromium LUCI CQ, AI Code Reviewer, Menard, Alexis, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, Stephen Chenney, Yoav Weiss (@Shopify), blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Auto-Submit

+1

1 comment

File third_party/blink/renderer/core/html/parser/html_document_parser.cc

Line 504, Patchset 1: perfetto::Flow::FromPointer(this), "parser", (void*)this);

AI Code Reviewer . resolved

nit: Use C++-style casts (e.g. `static_cast<void*>(this)`) instead of C-style casts. (Google C++ Style Guide: Casting)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Etienne Pierre-Doray

OK But Won't Fix: unrelated

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

satisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

8:16 AM (4 hours ago) 8:16 AM

to Kentaro Hara, Chromium LUCI CQ, AI Code Reviewer, Menard, Alexis, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, Stephen Chenney, Yoav Weiss (@Shopify), blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

9:03 AM (4 hours ago) 9:03 AM

to Etienne Pierre-Doray, Kentaro Hara, AI Code Reviewer, Menard, Alexis, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, Stephen Chenney, Yoav Weiss (@Shopify), blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[tracing] Migrate legacy flow macros in third_party/blink

Migrating the following flow event macros somewhat mechanically:
```
- TRACE_EVENT_FLOW[012](<category_group>, <name>, <flag>, <id>, ...)
-> TRACE_EVENT(<category_group>, <name>, <flow_type>::<id_type>, ...)
```

This CL was uploaded by git cl split.

R=har...@chromium.org

Bug: 432427382

Change-Id: Id2285e1428555f5519d5ade9a2bdba769285a48f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7277379

Reviewed-by: Kentaro Hara <har...@chromium.org>

Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>

Auto-Submit: Etienne Pierre-Doray <etie...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1570785}

Delta: 23 files changed, 560 insertions(+), 697 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kentaro Hara

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[tracing] Migrate legacy flow macros in third_party/blink [chromium/src : main]

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray has uploaded the change for review

Commit message

Change diff

Change information

Related details

AI Code Reviewer (Gerrit)

AI Code Reviewer added 1 comment

Related details

Kentaro Hara (Gerrit)

Kentaro Hara voted Code-Review+1

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

1 comment

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted Commit-Queue+2

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information