Add histogram HttpCache.GenerateCacheKey.Time [chromium/src : main]
0 views
Skip to first unread message
Adam Rice (Gerrit)
Dec 5, 2025, 4:53:22 AMDec 5
to Nidhi Jaju, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Nidhi Jaju
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nidhi Jaju
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nidhi Jaju (Gerrit)
Dec 7, 2025, 11:39:57 PMDec 7
to Adam Rice, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Adam Rice
Nidhi Jaju voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nidhi Jaju
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nidhi Jaju . unresolved
lgtm, but just want to check if the 12/31 expiry is sufficient (i.e. you will only ever collect Canary/Dev data), or are you planning to merge this back?
Related details
Attention is currently required from:
- Adam Rice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Dec 8, 2025, 10:36:34 AMDec 8
to Nidhi Jaju, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Adam Rice added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Nidhi Jaju . resolved
lgtm, but just want to check if the 12/31 expiry is sufficient (i.e. you will only ever collect Canary/Dev data), or are you planning to merge this back?
Adam Rice
Yes, I will only use Dev data for this.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Dec 8, 2025, 10:36:50 AMDec 8
to Nidhi Jaju, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Adam Rice voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 22, 2025, 2:40:01 PM (4 days ago) Dec 22
to Adam Rice, Nidhi Jaju, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add histogram HttpCache.GenerateCacheKey.Time
Measure the real-world performance of net::HttpCache::GenerateCacheKey()
by adding a scoped histogram, "HttpCache.GenerateCacheKey.Time".
This is intended to be temporary and should be removed before the end of
2025.
BUG=388956603
Change-Id: Ice54cb5b0e21df7ad4a3ede97460953373b36ca1
Commit-Queue: Adam Rice <ri...@chromium.org>
Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561912}
Files:
- M net/http/http_cache.cc
- M tools/metrics/histograms/metadata/net/histograms.xml
Change size: S
Delta: 2 files changed, 20 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nidhi Jaju
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
8:50 PM (2 hours ago) 8:50 PM
to Chromium LUCI CQ, Nidhi Jaju, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Adam Rice has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages