viz: ignore source id until ExternalBeginFrameSourceMojo is bound [chromium/src : main]
0 views
Skip to first unread message
里傲曹 (Gerrit)
May 25, 2026, 6:08:47 AM (7 days ago) May 25
to chromium...@chromium.org, cc-...@chromium.org
里傲曹 has uploaded the change for review![]( "Open in Gerrit")
Commit message
viz: ignore source id until ExternalBeginFrameSourceMojo is bound
ExternalBeginFrameSourceMojo previously initialized |original_source_id_|
to BeginFrameArgs::kStartingSourceId. That allowed not-yet-activated
instances to observe source_id 0 begin frames before they had been
bound to a real external source.
In multi-window external begin frame setups, those unbound instances
could incorrectly claim unrelated frames and pollute
|pending_frame_sinks_|, which can prevent the pending callback/ack
flow from draining correctly.
Store |original_source_id_| as std::optional<uint64_t> instead and only
track FrameSink begin/finish notifications after a source id has been
explicitly established by IssueExternalBeginFrame().
Add unit tests covering both the unbound case and the bound source-id
matching behavior.
Bug: 516336135
Test: viz_unittests --gtest_filter=ExternalBeginFrameSourceMojoTest.*
Change-Id: I407f9a1701598e577870a51bc54a6f049b8accb4
Change diff
Change information
Files:
- M components/viz/service/BUILD.gn
- M components/viz/service/frame_sinks/external_begin_frame_source_mojo.cc
- M components/viz/service/frame_sinks/external_begin_frame_source_mojo.h
- A components/viz/service/frame_sinks/external_begin_frame_source_mojo_unittest.cc
Change size: M
Delta: 4 files changed, 90 insertions(+), 3 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
里傲曹 (Gerrit)
May 28, 2026, 3:00:37 AM (4 days ago) May 28
to Sunny Sachanandani, Kyle Charbonneau, chromium...@chromium.org, cc-...@chromium.org
Attention needed from Kyle Charbonneau and Sunny Sachanandani
里傲曹 added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
里傲曹 . resolved
This MR ready for review. Please take a look and reply your suggestions.
Related details
Attention is currently required from:
- Kyle Charbonneau
- Sunny Sachanandani
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sunny Sachanandani (Gerrit)
May 28, 2026, 4:22:31 PM (3 days ago) May 28
to 里傲曹, Kyle Charbonneau, chromium...@chromium.org, cc-...@chromium.org
Attention needed from Kyle Charbonneau and 里傲曹
Sunny Sachanandani voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sunny Sachanandani
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Kyle Charbonneau
- 里傲曹
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyle Charbonneau (Gerrit)
May 29, 2026, 2:43:20 PM (2 days ago) May 29
to 里傲曹, chromium...@chromium.org, cc-...@chromium.org
Attention needed from 里傲曹
Kyle Charbonneau voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kyle Charbonneau
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- 里傲曹
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
里傲曹 (Gerrit)
May 31, 2026, 11:10:04 PM (2 hours ago) May 31
to Kyle Charbonneau, chromium...@chromium.org, cc-...@chromium.org
里傲曹 voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
里傲曹 (Gerrit)
May 31, 2026, 11:14:32 PM (1 hour ago) May 31
to Chromium LUCI CQ, Kyle Charbonneau, chromium...@chromium.org, cc-...@chromium.org
里傲曹 added 1 comment![]( "Open in Gerrit")
Patchset-level comments
里傲曹 . resolved
Thank you for reviewing, It seems CR+1 are enough for submit, could you please give me a CQ+2 vote? Thanks again.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages