Pass -Wno-gcc-install-dir-libstdcxx in gcc_preprocess.py [chromium/src : main]
0 views
Skip to first unread message
Tomasz Śniatowski (Gerrit)
5:34 AM (6 hours ago) 5:34 AM
to Andrew Grieve, chromium...@chromium.org, agriev...@chromium.org
Attention needed from Andrew Grieve
Tomasz Śniatowski added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tomasz Śniatowski . resolved
PTAL, a small result of a "why did this build break, it should be hermetic" investigation.
Related details
Attention is currently required from:
- Andrew Grieve
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Grieve (Gerrit)
9:31 AM (2 hours ago) 9:31 AM
to Tomasz Śniatowski, Andrew Grieve, chromium...@chromium.org, agriev...@chromium.org
Attention needed from Tomasz Śniatowski
Andrew Grieve voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrew Grieve
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Tomasz Śniatowski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Grieve (Gerrit)
9:32 AM (2 hours ago) 9:32 AM
to Tomasz Śniatowski, Chromium LUCI CQ, Andrew Grieve, chromium...@chromium.org, agriev...@chromium.org
Attention needed from Tomasz Śniatowski
Andrew Grieve voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Tomasz Śniatowski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tomasz Śniatowski (Gerrit)
9:58 AM (2 hours ago) 9:58 AM
to Chromium LUCI CQ, Andrew Grieve, chromium...@chromium.org, agriev...@chromium.org
Attention needed from Andrew Grieve
Tomasz Śniatowski voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Andrew Grieve
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tomasz Śniatowski (Gerrit)
10:22 AM (2 hours ago) 10:22 AM
to Chromium LUCI CQ, Andrew Grieve, chromium...@chromium.org, agriev...@chromium.org
Attention needed from Andrew Grieve
Tomasz Śniatowski voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrew Grieve
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tomasz Śniatowski (Gerrit)
10:23 AM (2 hours ago) 10:23 AM
to Chromium LUCI CQ, Andrew Grieve, chromium...@chromium.org, agriev...@chromium.org
Attention needed from Andrew Grieve
Tomasz Śniatowski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tomasz Śniatowski
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Tomasz Śniatowski . resolved
FTR issue was on my end, unsurprisingly since I haven't been through the new process yet. One https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gerrit_reauth.md#ReAuth-in-Gerrit-Web-UI round trip later I'm all set up and it feels better now (tm).
Related details
Attention is currently required from:
- Andrew Grieve
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:38 AM (1 hour ago) 10:38 AM
to Tomasz Śniatowski, Andrew Grieve, chromium...@chromium.org, agriev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Pass -Wno-gcc-install-dir-libstdcxx in gcc_preprocess.py
Recently clang started complaining with a "clang: warning: future
releases of the clang compiler will prefer GCC installations containing
libstdc++ include directories" on some systems, which was fatal in
gcc_preprocess.py. For example, this would be triggered on a Ubuntu
machine where gcc and libstdc++ in version 11 exist, and libgcc-12-dev
is also installed but a corresponding libstdc++-12-dev is not.
Avoid clang complaints by disabling the warning. The gcc_preprocess.py
action in the Android build only runs clang for preprocessing (duh) and
does not include any headers anyway.
Bug: 457939332
Change-Id: Ibbb91a2573b24a61385d782aa919c8e59ae3f510
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Tomasz Śniatowski <tomasz.s...@xperi.com>
Reviewed-by: Tomasz Śniatowski <tomasz.s...@xperi.com>
Cr-Commit-Position: refs/heads/main@{#1540631}
Files:
- M build/android/gyp/gcc_preprocess.py
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrew Grieve, +1 by Tomasz Śniatowski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages