[BrowserControls] nonScrollableLayerYOffset >= topControlOffset [chromium/src : main]

0 views
Skip to first unread message

Wenyu Fu (Gerrit)

unread,
Jan 9, 2026, 7:54:59 PM (20 hours ago) Jan 9
to Peilin Wang, Sirisha Kavuluru, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, peilinwa...@google.com
Attention needed from Peilin Wang

Wenyu Fu voted and added 1 comment

Votes added by Wenyu Fu

Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Peilin Wang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I774f1634e64e89fee02f747167766ae6e6f776f0
Gerrit-Change-Number: 7427186
Gerrit-PatchSet: 3
Gerrit-Owner: Wenyu Fu <wen...@chromium.org>
Gerrit-Reviewer: Peilin Wang <peili...@google.com>
Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
Gerrit-CC: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Peilin Wang <peili...@google.com>
Gerrit-Comment-Date: Sat, 10 Jan 2026 00:54:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peilin Wang (Gerrit)

unread,
Jan 9, 2026, 9:04:16 PM (19 hours ago) Jan 9
to Wenyu Fu, Sirisha Kavuluru, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, peilinwa...@google.com
Attention needed from Wenyu Fu

Peilin Wang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Wenyu Fu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I774f1634e64e89fee02f747167766ae6e6f776f0
    Gerrit-Change-Number: 7427186
    Gerrit-PatchSet: 3
    Gerrit-Owner: Wenyu Fu <wen...@chromium.org>
    Gerrit-Reviewer: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-CC: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Attention: Wenyu Fu <wen...@chromium.org>
    Gerrit-Comment-Date: Sat, 10 Jan 2026 02:04:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Wenyu Fu (Gerrit)

    unread,
    Jan 9, 2026, 9:11:38 PM (19 hours ago) Jan 9
    to Peilin Wang, Sirisha Kavuluru, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, peilinwa...@google.com

    Wenyu Fu voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I774f1634e64e89fee02f747167766ae6e6f776f0
    Gerrit-Change-Number: 7427186
    Gerrit-PatchSet: 3
    Gerrit-Owner: Wenyu Fu <wen...@chromium.org>
    Gerrit-Reviewer: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-CC: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Comment-Date: Sat, 10 Jan 2026 02:11:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 9, 2026, 9:15:05 PM (19 hours ago) Jan 9
    to Wenyu Fu, Peilin Wang, Sirisha Kavuluru, AyeAye, chromium...@chromium.org, peilinwa...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [BrowserControls] nonScrollableLayerYOffset >= topControlOffset

    nonScrollableLayerYOffset should be limited to no larger than the top
    control offset. This fixes an issue if browser controls is locked,
    adding a new layer can cause some of the layers positioned too high
    unexpectedly.

    This is part of the fix from crrev.com/c/7427223.
    Bug: 449166259
    Change-Id: I774f1634e64e89fee02f747167766ae6e6f776f0
    Reviewed-by: Peilin Wang <peili...@google.com>
    Commit-Queue: Wenyu Fu <wen...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1567326}
    Files:
    • M chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/TopControlsStacker.java
    • M chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/TopControlsStackerUnitTest.java
    Change size: S
    Delta: 2 files changed, 40 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Peilin Wang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I774f1634e64e89fee02f747167766ae6e6f776f0
    Gerrit-Change-Number: 7427186
    Gerrit-PatchSet: 4
    Gerrit-Owner: Wenyu Fu <wen...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages