satlab: add support for custom target type [infra/infra : main]

0 views
Skip to first unread message

Jacek Klimkowicz (Gerrit)

unread,
Jun 12, 2025, 4:31:38 AM6/12/25
to Przemysław Filipek, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Przemysław Filipek

Jacek Klimkowicz voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Przemysław Filipek
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I78ffba2c1b1445e6b2505cfdeb51588a27e2a054
Gerrit-Change-Number: 6632696
Gerrit-PatchSet: 1
Gerrit-Owner: Jacek Klimkowicz <klimk...@google.com>
Gerrit-Reviewer: Jacek Klimkowicz <klimk...@google.com>
Gerrit-Reviewer: Przemysław Filipek <fil...@google.com>
Gerrit-Attention: Przemysław Filipek <fil...@google.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 08:31:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Przemysław Filipek (Gerrit)

unread,
Jun 12, 2025, 5:41:33 AM6/12/25
to Jacek Klimkowicz, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Jacek Klimkowicz

Przemysław Filipek voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jacek Klimkowicz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I78ffba2c1b1445e6b2505cfdeb51588a27e2a054
Gerrit-Change-Number: 6632696
Gerrit-PatchSet: 2
Gerrit-Owner: Jacek Klimkowicz <klimk...@google.com>
Gerrit-Reviewer: Jacek Klimkowicz <klimk...@google.com>
Gerrit-Reviewer: Przemysław Filipek <fil...@google.com>
Gerrit-Attention: Jacek Klimkowicz <klimk...@google.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 09:41:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jacek Klimkowicz (Gerrit)

unread,
Jun 12, 2025, 8:27:29 AM6/12/25
to Przemysław Filipek, chromium...@chromium.org, infra-rev...@chromium.org

Jacek Klimkowicz voted

Auto-Submit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I78ffba2c1b1445e6b2505cfdeb51588a27e2a054
Gerrit-Change-Number: 6632696
Gerrit-PatchSet: 2
Gerrit-Owner: Jacek Klimkowicz <klimk...@google.com>
Gerrit-Reviewer: Jacek Klimkowicz <klimk...@google.com>
Gerrit-Reviewer: Przemysław Filipek <fil...@google.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 12:27:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

LUCI CQ (Gerrit)

unread,
Jun 12, 2025, 8:53:40 AM6/12/25
to Jacek Klimkowicz, Przemysław Filipek, chromium...@chromium.org, infra-rev...@chromium.org

LUCI CQ submitted the change

Change information

Commit message:
satlab: add support for custom target type

BUG=b:396635592
TEST=led
Change-Id: I78ffba2c1b1445e6b2505cfdeb51588a27e2a054
Commit-Queue: Jacek Klimkowicz <klimk...@google.com>
Reviewed-by: Przemysław Filipek <fil...@google.com>
Auto-Submit: Jacek Klimkowicz <klimk...@google.com>
Cr-Commit-Position: refs/heads/main@{#74249}
Files:
  • M go/src/infra/cros/satlab/common/run/run.go
  • M go/src/infra/cros/satlab/satlab/internal/components/run/run_suite_cmd.go
  • M go/src/infra/cros/satlab/satlab/internal/components/run/run_suite_flags.go
Change size: S
Delta: 3 files changed, 31 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Przemysław Filipek
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I78ffba2c1b1445e6b2505cfdeb51588a27e2a054
Gerrit-Change-Number: 6632696
Gerrit-PatchSet: 3
Gerrit-Owner: Jacek Klimkowicz <klimk...@google.com>
Gerrit-Reviewer: Jacek Klimkowicz <klimk...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages