added zeroize [chromium/src : main]
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq:
third-party-rust: luk...@chromium.org
It looks like you’re modifying `//third_party/rust`. An appropriate reviewer has been automatically added to this CL.
`//third_party/rust` reviewer(s): luk...@chromium.org
Reviewer source(s):
luk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq)
Related details
- Łukasz Anforowicz
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Anforowicz (Gerrit)
Łukasz Anforowicz added 4 comments![]( "Open in Gerrit")
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Please add `third_party/rust/zeroize/OWNERS` file (per [`third_party/rust/README-importing-new-crates.md`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/rust/README-importing-new-crates.md;l=70;drc=8915c12d835738baffc4a7830ae5c12ea942d8be))
(And also add `third_party/rust/zeroize_derive/OWNERS` - it can just forward to the former/other `OWNERS` file.)
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Per `third_party/rust/OWNERS-review-checklist.md` and [`//docs/adding_to_third_party.md`](https://chromium.googlesource.com/chromium/src/+/main/docs/adding_to_third_party.md#before-you-start) please add a link to a thread on https://groups.google.com/a/google.com/g/chrome-atls-discuss (or chrome-tsc-discuss) that approves adding this third-party dependency.
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Please add a `Bug: <bug number>` line to refer to a bug that tracks the project associated with this CL.
Related details
- Sam Schlesinger
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Schlesinger (Gerrit)
Sam Schlesinger added 3 comments![]( "Open in Gerrit")
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Per `third_party/rust/OWNERS-review-checklist.md` and [`//docs/adding_to_third_party.md`](https://chromium.googlesource.com/chromium/src/+/main/docs/adding_to_third_party.md#before-you-start) please add a link to a thread on https://groups.google.com/a/google.com/g/chrome-atls-discuss (or chrome-tsc-discuss) that approves adding this third-party dependency.
Done.
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Please add `third_party/rust/zeroize/OWNERS` file (per [`third_party/rust/README-importing-new-crates.md`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/rust/README-importing-new-crates.md;l=70;drc=8915c12d835738baffc4a7830ae5c12ea942d8be))
(And also add `third_party/rust/zeroize_derive/OWNERS` - it can just forward to the former/other `OWNERS` file.)
Done.
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Please add a `Bug: <bug number>` line to refer to a bug that tracks the project associated with this CL.
- Łukasz Anforowicz
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Anforowicz (Gerrit)
Łukasz Anforowicz added 4 comments![]( "Open in Gerrit")
@rop, can you PTAL at the failure in "Chromium License Check" that is reported by Gerrit at https://crrev.com/c/8075619?checksRunsSelected=Chromium%20License%20Check&tab=checks ? It seems to me that the check / report is invalid - this CL does add a `third_party/rust/chromium_crates_io/vendor/zeroize-v1/LICENSE-APACHE` file and this file does contain what looks like an Apache license. Do we need to ignore that failure and just go ahead with submitting to CQ?
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Sam SchlesingerPlease add a `Bug: <bug number>` line to refer to a bug that tracks the project associated with this CL.
Done.
Acknowledged
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Sam SchlesingerPer `third_party/rust/OWNERS-review-checklist.md` and [`//docs/adding_to_third_party.md`](https://chromium.googlesource.com/chromium/src/+/main/docs/adding_to_third_party.md#before-you-start) please add a link to a thread on https://groups.google.com/a/google.com/g/chrome-atls-discuss (or chrome-tsc-discuss) that approves adding this third-party dependency.
Done.
@samschlesinger, can you please double-check if the CL description has been edited? I still see no link when I look at https://crrev.com/c/8075619.
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Sam SchlesingerPlease add `third_party/rust/zeroize/OWNERS` file (per [`third_party/rust/README-importing-new-crates.md`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/rust/README-importing-new-crates.md;l=70;drc=8915c12d835738baffc4a7830ae5c12ea942d8be))
(And also add `third_party/rust/zeroize_derive/OWNERS` - it can just forward to the former/other `OWNERS` file.)
Done.
- Jordan Brown
- Sam Schlesinger
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Schlesinger (Gerrit)
Sam Schlesinger added 1 comment![]( "Open in Gerrit")
Change-Id: Ia75c855367d9b2d9fd2eb55d85cac9e4fe608c59Sam SchlesingerPer `third_party/rust/OWNERS-review-checklist.md` and [`//docs/adding_to_third_party.md`](https://chromium.googlesource.com/chromium/src/+/main/docs/adding_to_third_party.md#before-you-start) please add a link to a thread on https://groups.google.com/a/google.com/g/chrome-atls-discuss (or chrome-tsc-discuss) that approves adding this third-party dependency.
Łukasz AnforowiczDone.
@samschlesinger, can you please double-check if the CL description has been edited? I still see no link when I look at https://crrev.com/c/8075619.
Sorry I didn't understand I had to put it in the description. Edited now.
Related details
- Jordan Brown
- Łukasz Anforowicz
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |