Deflake CrossPlatformAccessibilityBrowserTest.NavigateInIframe [chromium/src : main]

[David Tseng (Gerrit)]

Attention needed from Bryan Oltman

David Tseng added 2 comments

File content/browser/accessibility/cross_platform_accessibility_browsertest.cc

Line 168, Patchset 3 (Latest): InputMsgWatcher input_watcher(rwh, blink::WebInputEvent::Type::kKeyUp);

David Tseng . unresolved

Doesn't tab key down trigger focus change?

Line 170, Patchset 3 (Latest): shell()->web_contents(), ui::AXEventGenerator::Event::FOCUS_CHANGED);

David Tseng . unresolved

If we're simply concerned with a11y focus, then it seems like busy while waiting for focus node to match the target name should suffice.

As is, it's I guess possible we end up matching against the wrong focus event since we're tabbing potentially more than once.

Open in Gerrit

Related details

Attention is currently required from:

• Bryan Oltman

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I629a3055b2c2062a9907c0b16db3fca5d6237e67

Gerrit-Change-Number: 8110657

Gerrit-PatchSet: 3

Gerrit-Owner: Bryan Oltman <bryan...@google.com>

Gerrit-Reviewer: Bryan Oltman <bryan...@google.com>

Gerrit-Reviewer: David Tseng <dts...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Bryan Oltman <bryan...@google.com>

Gerrit-Comment-Date: Fri, 17 Jul 2026 22:53:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Bryan Oltman (Gerrit)]

Attention needed from David Tseng

Bryan Oltman added 2 comments

File content/browser/accessibility/cross_platform_accessibility_browsertest.cc

Line 168, Patchset 3: InputMsgWatcher input_watcher(rwh, blink::WebInputEvent::Type::kKeyUp);

David Tseng . resolved

Doesn't tab key down trigger focus change?

Bryan Oltman

Sometimes more than once. As per the other comment though, you're right that this same thing is achievable without the InputMsgWatcher. Cleaned this up.

Line 170, Patchset 3: shell()->web_contents(), ui::AXEventGenerator::Event::FOCUS_CHANGED);

David Tseng . resolved

If we're simply concerned with a11y focus, then it seems like busy while waiting for focus node to match the target name should suffice.

As is, it's I guess possible we end up matching against the wrong focus event since we're tabbing potentially more than once.

Bryan Oltman

That would definitely be a lot simpler. Done.

Open in Gerrit

Related details

Attention is currently required from:

• David Tseng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I629a3055b2c2062a9907c0b16db3fca5d6237e67

Gerrit-Change-Number: 8110657

Gerrit-PatchSet: 4

Gerrit-Owner: Bryan Oltman <bryan...@google.com>

Gerrit-Reviewer: Bryan Oltman <bryan...@google.com>

Gerrit-Reviewer: David Tseng <dts...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: David Tseng <dts...@chromium.org>

Gerrit-Comment-Date: Sat, 18 Jul 2026 23:53:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: David Tseng <dts...@chromium.org>

[Michelle Tsotetsi (Gerrit)]

Attention needed from Bryan Oltman and David Tseng

Michelle Tsotetsi added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Michelle Tsotetsi . resolved

I can use my Facebook messenger

Open in Gerrit

Related details

Attention is currently required from:

• Bryan Oltman
• David Tseng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I629a3055b2c2062a9907c0b16db3fca5d6237e67

Gerrit-Change-Number: 8110657

Gerrit-PatchSet: 4

Gerrit-Owner: Bryan Oltman <bryan...@google.com>

Gerrit-Reviewer: Bryan Oltman <bryan...@google.com>

Gerrit-Reviewer: David Tseng <dts...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Michelle Tsotetsi <michellets...@gmail.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: David Tseng <dts...@chromium.org>

Gerrit-Attention: Bryan Oltman <bryan...@google.com>

Gerrit-Comment-Date: Sun, 19 Jul 2026 00:59:59 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No