Why was it reverted and what's the diff between the original CL and this one to address it? Uploading the original one and the fix in the next patch would make it easy to see.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Why was it reverted and what's the diff between the original CL and this one to address it? Uploading the original one and the fix in the next patch would make it easy to see.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Set Ready For Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
boolean hasHardwareKeyboard =
runOnUiThreadBlocking(() -> DeviceInput.supportsKeyboard(getActivity()));
if (hasHardwareKeyboard
&& DeviceFormFactor.isNonMultiDisplayContextOnTablet(getActivity())) {The only change between this reland cl and the previous one is here:
Only Large Form Factor device with physical keyboard connected need to collapse the soft keyboard. For Lff device w/o physical keyboard, treats it as phone
This change ensures that the previous two post-submit tests would pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fuhsin LiaoWhy was it reverted and what's the diff between the original CL and this one to address it? Uploading the original one and the fix in the next patch would make it easy to see.
Sorry forgot to mark this WIP
The diff between reland and the previous cl has been updated in the latest comment, please check, thanks~!
| Code-Review | +1 |
boolean hasHardwareKeyboard =
runOnUiThreadBlocking(() -> DeviceInput.supportsKeyboard(getActivity()));
if (hasHardwareKeyboard
&& DeviceFormFactor.isNonMultiDisplayContextOnTablet(getActivity())) {The only change between this reland cl and the previous one is here:
Only Large Form Factor device with physical keyboard connected need to collapse the soft keyboard. For Lff device w/o physical keyboard, treats it as phone
This change ensures that the previous two post-submit tests would pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Auto-Submit | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |