Convert to UNSAFE_TODO in media [1/7] Mac and Apple [chromium/src : main]
0 views
Skip to first unread message
Arthur Sonzogni (Gerrit)
11:22 AM (10 hours ago) 11:22 AM
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, toyosh...@chromium.org
Attention needed from Eugene Zemtsov
Arthur Sonzogni voted and added 3 comments![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Auto-Submit | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Arthur Sonzogni . resolved
Hi Eugene, could you please take a look?
File media/base/mac/channel_layout_util_mac.cc
Line 11, Patchset 1 (Latest):
#include "base/compiler_specific.h"Arthur Sonzogni . resolved
Note: (this is only useful for the presubmit, this is a pre-existing issue)
> media/midi/midi_manager_mac.cc:112 ARCH_CPU_64_BITS macro is used without first including build/build_config.h.
File media/gpu/mac/vt_config_util_unittest.mm
Line 348, Patchset 1 (Latest):
UNSAFE_TODO(base::span<const uint8_t>(kAvc1Box, sizeof(kAvc1Box))));Arthur Sonzogni . resolved
Note: `base::span` has safe constructors. If `kAvc1Box` is a fixed-size C-array, `base::span(kAvc1Box)` should automatically deduce the size safely without needing sizeof().
I can submit follow-ups trying to fix the trivial instances like this if you want.
I do prefer follow-ups to keep this patch purely as a mechanical change.
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
7:26 PM (2 hours ago) 7:26 PM
to Arthur Sonzogni, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, toyosh...@chromium.org
Attention needed from Arthur Sonzogni
Eugene Zemtsov voted![]( "Open in Gerrit")
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
8:57 PM (1 hour ago) 8:57 PM
to Arthur Sonzogni, Eugene Zemtsov, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, toyosh...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Convert to UNSAFE_TODO in media [1/7] Mac and Apple
This was generated using [Script] below, followed by Gemini to
Address the unsupported/difficult cases.
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989
Change-Id: Ie4fad30d2ee0caeb613fb76ccb2ac403ce328e26
Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>
Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1604512}
Files:
- M media/audio/mac/audio_loopback_input_mac_impl.mm
- M media/audio/mac/audio_loopback_input_mac_unittest.mm
- M media/base/mac/channel_layout_util_mac.cc
- M media/base/mac/channel_layout_util_mac.h
- M media/base/mac/channel_layout_util_mac_unittest.cc
- M media/base/mac/video_frame_mac.mm
- M media/base/mac/video_frame_mac_unittest.cc
- M media/capture/video/apple/sample_buffer_transformer_unittest.mm
- M media/capture/video/apple/video_capture_device_apple.mm
- M media/capture/video/apple/video_capture_device_avfoundation.mm
- M media/capture/video/apple/video_capture_device_factory_apple.mm
- M media/capture/video/mac/uvc_control_mac.mm
- M media/gpu/mac/vt_config_util_unittest.mm
- M media/midi/midi_manager_mac.cc
Change size: M
Delta: 14 files changed, 101 insertions(+), 123 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eugene Zemtsov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages