Sync: Upgrade DUMP_WILL_BE_CHECKs in ClientTagBasedDataTypeProcessor [chromium/src : main]
0 views
Skip to first unread message
Marc Treib (Gerrit)
Apr 14, 2025, 8:45:43 AMApr 14
to Marc Treib, Chromium Sync Reviews, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Chromium Sync Reviews
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Chromium Sync Reviews
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Apr 14, 2025, 8:49:07 AMApr 14
to Marc Treib, Chromium Sync Reviews, Mahmoud Rashad, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Mahmoud Rashad
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
mmra...@google.com is from context(googleclient/chrome/chromium_gwsq/components/sync/config.gwsq)
Related details
Attention is currently required from:
- Mahmoud Rashad
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mahmoud Rashad (Gerrit)
Apr 14, 2025, 9:33:30 AMApr 14
to Marc Treib, Chromium Sync Reviews, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Marc Treib
Mahmoud Rashad voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Apr 14, 2025, 9:42:40 AMApr 14
to Marc Treib, Chromium Sync Reviews, Chromium LUCI CQ, chromium...@chromium.org
Marc Treib voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 14, 2025, 9:45:18 AMApr 14
to Marc Treib, Mahmoud Rashad, Chromium Sync Reviews, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Sync: Upgrade DUMP_WILL_BE_CHECKs in ClientTagBasedDataTypeProcessor
Most of the DUMP_WILL_BE_CHECKs can now be (hopefully safely) upgraded
to proper CHECKs.
Two exceptions have TODOs with other bugs attached (one pre-existing,
one added by this CL).
Bug: 410400548
Change-Id: Ic26a9d0adf07d4953a5805a504c9b94bc4abe543
Commit-Queue: Marc Treib <tr...@chromium.org>
Reviewed-by: Mahmoud Rashad <mmra...@google.com>
Cr-Commit-Position: refs/heads/main@{#1446496}
Files:
- M components/sync/model/client_tag_based_data_type_processor.cc
Change size: M
Delta: 1 file changed, 79 insertions(+), 79 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mahmoud Rashad
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
May 22, 2025, 2:39:13 PMMay 22
to Marc Treib, Chromium LUCI CQ, Chromium Sync Reviews, chromium...@chromium.org
Ginny Huang has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages