SideUi: Rename requestUpdateContainer() and its parameter [chromium/src : main]

0 views
Skip to first unread message

Linyu He (Gerrit)

unread,
Jun 24, 2026, 9:08:41 PM (4 days ago) Jun 24
to Neil Coronado, Moe Adel, chromium...@chromium.org, Charles Hager, Mark Schillaci, Shu Yang, Sinan Sahin, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, nemco...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Neil Coronado

Linyu He voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Neil Coronado
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I790ac2254c8e559e263c1c3f9690acd0acae7ed6
Gerrit-Change-Number: 7997508
Gerrit-PatchSet: 2
Gerrit-Owner: Linyu He <lin...@google.com>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Reviewer: Neil Coronado <ne...@google.com>
Gerrit-CC: Charles Hager <clh...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-CC: Shu Yang <shu...@google.com>
Gerrit-CC: Sinan Sahin <sinan...@google.com>
Gerrit-Attention: Neil Coronado <ne...@google.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 01:08:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Neil Coronado (Gerrit)

unread,
Jun 24, 2026, 9:25:37 PM (4 days ago) Jun 24
to Linyu He, Jinsuk Kim, Chromium LUCI CQ, Moe Adel, chromium...@chromium.org, Charles Hager, Mark Schillaci, Shu Yang, Sinan Sahin, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, nemco...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Jinsuk Kim and Linyu He

Neil Coronado voted and added 1 comment

Votes added by Neil Coronado

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Neil Coronado . resolved

lgtm, thanks for the cleanup!

Open in Gerrit

Related details

Attention is currently required from:
  • Jinsuk Kim
  • Linyu He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I790ac2254c8e559e263c1c3f9690acd0acae7ed6
Gerrit-Change-Number: 7997508
Gerrit-PatchSet: 2
Gerrit-Owner: Linyu He <lin...@google.com>
Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Reviewer: Neil Coronado <ne...@google.com>
Gerrit-CC: Charles Hager <clh...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-CC: Shu Yang <shu...@google.com>
Gerrit-CC: Sinan Sahin <sinan...@google.com>
Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
Gerrit-Attention: Linyu He <lin...@google.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 01:25:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 24, 2026, 10:09:00 PM (4 days ago) Jun 24
to Linyu He, Neil Coronado, Jinsuk Kim, Moe Adel, chromium...@chromium.org, Charles Hager, Mark Schillaci, Shu Yang, Sinan Sahin, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, nemco...@google.com, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
SideUi: Rename requestUpdateContainer() and its parameter

This CL is a no-op. It's only to make subsequent changes for the
attached bug easier to review.

The logic of requestUpdateContainer() doesn't update one
SideUiContainer. It calculates SideUiSpecs and SideUiShowability for all
SideUiContainers and update all SideUiContainers and SideUiObservers.

This CL renames requestUpdateContainer() and its parameter to better
reflect the logic above.

* requestUpdateContainer() -> updateUi()

* SideUiContainerProperties -> UiUpdateRequest
  * Remove mAnchorSide: we don't support updating the AnchorSide yet.
    It'll be easy to add it back if needed.
  * Add mSuppressAnimations: this is part of the UI update requirement.
Bug: 478338737
Change-Id: I790ac2254c8e559e263c1c3f9690acd0acae7ed6
Commit-Queue: Linyu He <lin...@google.com>
Auto-Submit: Linyu He <lin...@google.com>
Reviewed-by: Neil Coronado <ne...@google.com>
Cr-Commit-Position: refs/heads/main@{#1652125}
Files:
  • M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/vertical_tabs/VerticalTabsSideUiCoordinator.java
  • M chrome/browser/ui/side_panel_container/internal/android/java/src/org/chromium/chrome/browser/ui/side_panel_container/SidePanelContainerCoordinatorImpl.java
  • M chrome/browser/ui/side_ui/internal/android/java/src/org/chromium/chrome/browser/ui/side_ui/SideUiCoordinatorImpl.java
  • M chrome/browser/ui/side_ui/internal/android/java/src/org/chromium/chrome/browser/ui/side_ui/SideUiCoordinatorImplTest.java
  • M chrome/browser/ui/side_ui/public/android/java/src/org/chromium/chrome/browser/ui/side_ui/SideUiContainer.java
  • M chrome/browser/ui/side_ui/public/android/java/src/org/chromium/chrome/browser/ui/side_ui/SideUiCoordinator.java
  • M chrome/browser/ui/side_ui/test/android/java/src/org/chromium/chrome/browser/ui/side_ui/TestSideUiContainer.java
Change size: M
Delta: 7 files changed, 72 insertions(+), 113 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Neil Coronado
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I790ac2254c8e559e263c1c3f9690acd0acae7ed6
Gerrit-Change-Number: 7997508
Gerrit-PatchSet: 3
Gerrit-Owner: Linyu He <lin...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Reviewer: Neil Coronado <ne...@google.com>
Gerrit-CC: Charles Hager <clh...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages