Add field trial config for AutofillComplementCountryUsingPhoneNumber [chromium/src : main]
0 views
Skip to first unread message
Tamino Bauknecht (Gerrit)
Jul 3, 2026, 5:03:00 AM (6 days ago) Jul 3
to chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org, browser-comp...@chromium.org
Tamino Bauknecht has uploaded the change for review![]( "Open in Gerrit")
Commit message
Add field trial config for AutofillComplementCountryUsingPhoneNumber
Bug: 509874545
Change-Id: I2348f0c211c600767f876a630a54d9a585e39225
Change diff
diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
index 9fef1be4..2bfcb10 100644
--- a/testing/variations/fieldtrial_testing_config.json
+++ b/testing/variations/fieldtrial_testing_config.json
@@ -2766,6 +2766,26 @@
]
}
],
+ "AutofillComplementCountryUsingPhoneNumber": [
+ {
+ "platforms": [
+ "android",
+ "chromeos",
+ "ios",
+ "linux",
+ "mac",
+ "windows"
+ ],
+ "experiments": [
+ {
+ "name": "Enabled",
+ "enable_features": [
+ "AutofillComplementCountryUsingPhoneNumber"
+ ]
+ }
+ ]
+ }
+ ],
"AutofillCreditCardUserPerceptionSurvey": [
{
"platforms": [
Change information
Files:
- M testing/variations/fieldtrial_testing_config.json
Change size: S
Delta: 1 file changed, 20 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tamino Bauknecht (Gerrit)
Jul 6, 2026, 5:34:46 AM (3 days ago) Jul 6
to Jihad Hanna, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org
Attention needed from Jihad Hanna
Tamino Bauknecht added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tamino Bauknecht . unresolved
Hi Jihad, this is the field trial config I exptracted from crrev.com/c/8011492.
I assume this feature is not required on Android Webview because it doesn't have a save prompt (I think), do you agree?
Related details
Attention is currently required from:
- Jihad Hanna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jihad Hanna (Gerrit)
Jul 6, 2026, 6:19:37 AM (3 days ago) Jul 6
to Tamino Bauknecht, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org
Attention needed from Tamino Bauknecht
Jihad Hanna voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tamino Bauknecht
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jihad Hanna (Gerrit)
Jul 6, 2026, 6:20:06 AM (3 days ago) Jul 6
to Tamino Bauknecht, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org
Attention needed from Tamino Bauknecht
Jihad Hanna added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hi Jihad, this is the field trial config I exptracted from crrev.com/c/8011492.
I assume this feature is not required on Android Webview because it doesn't have a save prompt (I think), do you agree?
Jihad Hanna
Yes that is right, we do not have a storage layer on WebView 👍
Related details
Attention is currently required from:
- Tamino Bauknecht
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jihad Hanna (Gerrit)
3:39 AM (8 hours ago) 3:39 AM
to Tamino Bauknecht, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org
Attention needed from Tamino Bauknecht
Jihad Hanna added 1 comment![]( "Open in Gerrit")
File components/autofill/core/browser/form_import/addresses/address_form_data_importer.h
Line 104, Patchset 8 (Latest):
LogBuffer& import_log_buffer,Jihad Hanna . unresolved
Why are these changes bundled in the same CL as the fieldtrial config one?
Related details
Attention is currently required from:
- Tamino Bauknecht
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tamino Bauknecht (Gerrit)
8:27 AM (3 hours ago) 8:27 AM
to Chromium LUCI CQ, Jihad Hanna, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org
Attention needed from Jihad Hanna
Tamino Bauknecht added 1 comment![]( "Open in Gerrit")
File components/autofill/core/browser/form_import/addresses/address_form_data_importer.h
Line 104, Patchset 8:
LogBuffer& import_log_buffer,Jihad Hanna . unresolved
Why are these changes bundled in the same CL as the fieldtrial config one?
Tamino Bauknecht
Done. That was by mistake, I accidentally merged it with https://crrev.com/c/8062947 - thanks for telling me :)
Were you put into the attention set automatically or did you just notice it while browsing your reviewed CLs?
Related details
Attention is currently required from:
- Jihad Hanna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jihad Hanna (Gerrit)
8:43 AM (3 hours ago) 8:43 AM
to Tamino Bauknecht, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org
Attention needed from Tamino Bauknecht
Jihad Hanna voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jihad Hanna
| Code-Review | +1 |
1 comment
File components/autofill/core/browser/form_import/addresses/address_form_data_importer.h
Line 104, Patchset 8:
LogBuffer& import_log_buffer,Jihad Hanna . resolved
Tamino BauknechtWhy are these changes bundled in the same CL as the fieldtrial config one?
Done. That was by mistake, I accidentally merged it with https://crrev.com/c/8062947 - thanks for telling me :)
Were you put into the attention set automatically or did you just notice it while browsing your reviewed CLs?
Attention is currently required from:
- Tamino Bauknecht
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages