[gerrit_util] Update docstring for new param [chromium/tools/depot_tools : main]
0 views
Skip to first unread message
Allen Li (Gerrit)
7:20 PM (4 hours ago) 7:20 PM
to chromium...@chromium.org, chops-source-team...@google.com
Allen Li has uploaded the change for review![]( "Open in Gerrit")
Commit message
[gerrit_util] Update docstring for new param
Change-Id: Ifb6106ad0063183ee0a0377bb3564c4fc99d88ef
Change diff
diff --git a/gerrit_util.py b/gerrit_util.py
index a7619c3..323e269 100644
--- a/gerrit_util.py
+++ b/gerrit_util.py
@@ -223,7 +223,11 @@
@classmethod
def is_applicable(cls, *, conn: Optional[HttpConn] = None) -> bool:
"""Must return True if this Authenticator is available in the current
- environment."""
+ environment.
+
+ If conn is not None, return True if this Authenticator is
+ applicable to the given conn in the current environment.
+ """
raise NotImplementedError()
def ensure_authenticated(self, gerrit_host: str, git_host: str) -> Tuple[bool, str]:
Change information
Files:
- M gerrit_util.py
Change size: XS
Delta: 1 file changed, 5 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Allen Li (Gerrit)
7:21 PM (4 hours ago) 7:21 PM
to Robbie Iannucci, Yiwei Zhang, chromium...@chromium.org, chops-source-team...@google.com
Attention needed from Robbie Iannucci and Yiwei Zhang
Allen Li voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Robbie Iannucci
- Yiwei Zhang
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yiwei Zhang (Gerrit)
7:21 PM (4 hours ago) 7:21 PM
to Allen Li, LUCI CQ, Robbie Iannucci, chromium...@chromium.org, chops-source-team...@google.com
Attention needed from Allen Li and Robbie Iannucci
Yiwei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Allen Li
- Robbie Iannucci
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Allen Li (Gerrit)
9:29 PM (2 hours ago) 9:29 PM
to Yiwei Zhang, LUCI CQ, Robbie Iannucci, chromium...@chromium.org, chops-source-team...@google.com
Attention needed from Robbie Iannucci
Allen Li voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Robbie Iannucci
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages