[lacros/client] Add active display support [chromium/src : main]

Mitsuru Oshima (Gerrit)

unread,

Nov 22, 2022, 4:05:38 PM11/22/22

to crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Maksim Sisov.

View Change

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Maksim Sisov (Gerrit)

unread,

Nov 23, 2022, 1:59:34 AM11/23/22

to Mitsuru Oshima, crostin...@chromium.org, yhanada+...@chromium.org, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Mitsuru Oshima.

View Change

6 comments:

File ui/ozone/platform/wayland/host/wayland_screen_unittest.cc:
- Patch Set #11, Line 304:
  you can revert this change to have a "cleaner" commit (if you wish).
File ui/ozone/platform/wayland/host/wayland_zaura_output_unittest.cc:
- Patch Set #11, Line 21: namespace {
  no need for the unanimous namespace.
- Patch Set #11, Line 27: WaylandTestScreen(WaylandScreen* wayland_screen)
  single-argument constructors must be marked explicit to avoid unintentional implicit conversions (https://clang.llvm.org/extra/clang-tidy/checks/google/explicit-constructor.html)
  (Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel` or `linux-chromeos-clang-tidy-rel`)
  Please fix.
- Patch Set #11, Line 28: : display::test::TestScreen(/*create=*/false, /*register=*/true),
  argument name 'create' in comment does not match parameter name 'create_display' (https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)
  (Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel` or `linux-chromeos-clang-tidy-rel`)
  Please fix.
- Patch Set #11, Line 28: : display::test::TestScreen(/*create=*/false, /*register=*/true),
  argument name 'register' in comment does not match parameter name 'register_screen' (https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)
  (Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel` or `linux-chromeos-clang-tidy-rel`)
  Please fix.
- Patch Set #11, Line 154: ;
  default initialization?

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Nov 23, 2022, 2:19:29 PM11/23/22

to crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Maksim Sisov.

Patch set 12:Commit-Queue +1

View Change

6 comments:

File ui/ozone/platform/wayland/host/wayland_screen_unittest.cc:

- Patch Set #11, Line 304:
  you can revert this change to have a "cleaner" commit (if you wish).

- Done
File ui/ozone/platform/wayland/host/wayland_zaura_output_unittest.cc:

- Patch Set #11, Line 21: namespace {
  no need for the unanimous namespace.

- This is only for the base class which is local to this file, not test bodies.

- Patch Set #11, Line 27: WaylandTestScreen(WaylandScreen* wayland_screen)

- > single-argument constructors must be marked explicit to avoid unintentional implicit conversions ( […]
  Done

- Patch Set #11, Line 28: : display::test::TestScreen(/*create=*/false, /*register=*/true),

- > argument name 'register' in comment does not match parameter name 'register_screen' (https://clang […]
  Done

- Patch Set #11, Line 28: : display::test::TestScreen(/*create=*/false, /*register=*/true),

- > argument name 'create' in comment does not match parameter name 'create_display' (https://clang. […]
  Done

- Patch Set #11, Line 154: ;
  default initialization?

- Done

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Maksim Sisov (Gerrit)

unread,

Nov 24, 2022, 2:11:24 AM11/24/22

to Mitsuru Oshima, crostin...@chromium.org, yhanada+...@chromium.org, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Mitsuru Oshima.

Patch set 12:Code-Review +1

View Change

1 comment:

File ui/ozone/platform/wayland/host/wayland_zaura_output_unittest.cc:

- Patch Set #11, Line 21: namespace {

- This is only for the base class which is local to this file, not test bodies.
  Didn't notice that. Sorry.

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Nov 24, 2022, 5:36:28 AM11/24/22

to crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Patch set 12:Commit-Queue +2

View Change

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Nov 24, 2022, 10:50:40 AM11/24/22

to crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Patch set 12:Commit-Queue +2

View Change

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Nov 24, 2022, 6:21:48 PM11/24/22

to crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Patch set 12:Commit-Queue +2

View Change

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Nov 25, 2022, 3:52:06 AM11/25/22

to crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Patch set 12:Commit-Queue +1

View Change

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Nov 25, 2022, 1:37:03 PM11/25/22

to crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Patch set 13:Commit-Queue +2

View Change

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Nov 25, 2022, 11:26:31 PM11/25/22

to crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Patch set 13:Commit-Queue +2

View Change

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Nov 26, 2022, 12:05:29 PM11/26/22

to crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, Chromium LUCI CQ, chromium...@chromium.org

Patch set 13:Commit-Queue +2

View Change

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Nov 26, 2022, 4:25:25 PM11/26/22

to Mitsuru Oshima, crostin...@chromium.org, yhanada+...@chromium.org, Maksim Sisov, Tricium, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change



12 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ui/ozone/platform/wayland/host/wayland_zaura_output_unittest.cc
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Approvals:
  Maksim Sisov: Looks good to me
  Mitsuru Oshima: Commit

[lacros/client] Add active display support

This will be used as a target for new display when
no bounds is specified.

Bug: 1350513
Test: WaylandZAuraOutputTest.ActiveDisplay
Change-Id: I08449be2995d1867ce81a2e274254a0d99322e39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024382
Reviewed-by: Maksim Sisov <msi...@igalia.com>
Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1075920}
---
M ui/display/screen_base.cc
M ui/ozone/platform/wayland/BUILD.gn
M ui/ozone/platform/wayland/host/wayland_zaura_output.cc
M ui/ozone/platform/wayland/host/wayland_zaura_output_unittest.cc
M ui/ozone/platform/wayland/host/wayland_zaura_shell.cc
M ui/ozone/platform/wayland/test/mock_zaura_shell.cc
6 files changed, 90 insertions(+), 4 deletions(-)

To view, visit change 4024382. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward