[permissions] Avoid continuously reparsing NTP url [chromium/src : main]
0 views
Skip to first unread message
Marc Treib (Gerrit)
Apr 20, 2026, 7:36:38 AM (11 days ago) Apr 20
to Antonio Sartori, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews
Attention needed from Antonio Sartori
Marc Treib voted and added 2 comments![]( "Open in Gerrit")
Votes added by Marc Treib
| Code-Review | +1 |
2 comments
File chrome/common/webui_url_constants.h
Line 225, Patchset 2 (Latest):
const GURL& ChromeUINewTabURLAsGURL();Marc Treib . unresolved
There are [many other places that parse these URL constants on demand](https://source.chromium.org/search?q=%22GURL(chrome::kChromeUINewTabURL)%22%20%22GURL(chrome::kChromeUINewTabPageURL)%22). Are you planning to update those too?
File chrome/common/webui_url_constants.cc
Line 341, Patchset 2 (Latest):
}Marc Treib . resolved
Huh, I'm a bit surprised that nobody else has run into this kind of thing so far, so there's no established pattern. And then it's odd that permissions is the first thing to run into a perf issue here; presumably the permissions code doesn't run *that* frequently?
But the pattern seems fine, and I don't see any better place to put it, so lgtm.
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 8:10:42 AM (11 days ago) Apr 20
to Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews
Antonio Sartori voted and added 2 comments![]( "Open in Gerrit")
Votes added by Antonio Sartori
| Commit-Queue | +2 |
2 comments
File chrome/common/webui_url_constants.h
Line 225, Patchset 2 (Latest):
const GURL& ChromeUINewTabURLAsGURL();Marc Treib . resolved
There are [many other places that parse these URL constants on demand](https://source.chromium.org/search?q=%22GURL(chrome::kChromeUINewTabURL)%22%20%22GURL(chrome::kChromeUINewTabPageURL)%22). Are you planning to update those too?
Antonio Sartori
Thanks! Yes, since I started this, I'll send out multiple small CLs for all those places.
File chrome/common/webui_url_constants.cc
Marc Treib . resolved
Huh, I'm a bit surprised that nobody else has run into this kind of thing so far, so there's no established pattern. And then it's odd that permissions is the first thing to run into a perf issue here; presumably the permissions code doesn't run *that* frequently?
But the pattern seems fine, and I don't see any better place to put it, so lgtm.
Antonio Sartori
I guess so. Still, I don't think it makes sense to keep parsing these URLs.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 8:13:19 AM (11 days ago) Apr 20
to Antonio Sartori, Marc Treib, chromium...@chromium.org, Permissions Reviews
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[permissions] Avoid continuously reparsing NTP url
This CL creates GURL constants for ChromeUINewTabURL and
ChromeUINewTabPageURL so that they don't need to be parsed again and
again in chrome_permission_client.cc.
Bug: 503370195
Change-Id: Icda93fd6d276b8e6a0a0fb63bf70897621e7b82d
Fixed: 503370195
Reviewed-by: Marc Treib <tr...@chromium.org>
Commit-Queue: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617416}
Files:
- M chrome/browser/permissions/chrome_permissions_client.cc
- M chrome/common/webui_url_constants.cc
- M chrome/common/webui_url_constants.h
Change size: S
Delta: 3 files changed, 21 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Marc Treib
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:33:15 AM (10 days ago) Apr 20
to Hidehiko Abe, chromium...@chromium.org
Attention needed from Hidehiko Abe
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Hidehiko Abe to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
R=hide...@chromium.org
Bug: 503370195
Change-Id: Ibdcae12c4a4df533e9cd3565b8359ece7a3d30db
Change diff
diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc
index 95e3845..7466bc94 100644
--- a/chrome/test/base/testing_profile.cc
+++ b/chrome/test/base/testing_profile.cc
@@ -930,7 +930,7 @@
}
GURL TestingProfile::GetHomePage() {
- return GURL(chrome::kChromeUINewTabURL);
+ return chrome::ChromeUINewTabURLAsGURL();
}
void TestingProfile::SetCreationTimeForTesting(base::Time creation_time) {
Change information
Files:
- M chrome/test/base/testing_profile.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:33:59 AM (10 days ago) Apr 20
to Marc Treib, chromium...@chromium.org, cros-print...@google.com, chrome-gr...@chromium.org, browser-comp...@chromium.org, subresource-f...@chromium.org, print-rev...@chromium.org
Attention needed from Marc Treib
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Marc Treib to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in ['chrome/browser', 'chrome/browser/first_run', 'chrome/browser/history', 'chrome/browser/printing', 'chrome/browser/privacy_sandbox', 'chrome/browser/resource_coordinator', 'chrome/browser/subresource_filter'], avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/browser_process_platform_part_ash_browsertest.cc
- M chrome/browser/chrome_content_browser_client.cc
- M chrome/browser/chrome_content_browser_client_browsertest.cc
- M chrome/browser/chrome_content_browser_client_unittest.cc
- M chrome/browser/first_run/first_run_browsertest.cc
- M chrome/browser/history/history_browsertest.cc
- M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
- M chrome/browser/privacy_sandbox/notice/desktop_entrypoint_handlers_helper.cc
- M chrome/browser/resource_coordinator/tab_manager_unittest.cc
- M chrome/browser/subresource_filter/subresource_filter_disabled_reason_uma_browsertest.cc
Change size: S
Delta: 10 files changed, 20 insertions(+), 19 deletions(-)
Related details
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:34:30 AM (10 days ago) Apr 20
to Christine Ying, chromium...@chromium.org, chrstn...@google.com, aashna...@google.com, mfoltz+wa...@chromium.org, boujan...@google.com
Attention needed from Christine Ying
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Christine Ying to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/actor/ui, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
diff --git a/chrome/browser/actor/ui/actor_ui_tab_controller_browsertest.cc b/chrome/browser/actor/ui/actor_ui_tab_controller_browsertest.cc
index e5c99f6c..adf6ec84 100644
--- a/chrome/browser/actor/ui/actor_ui_tab_controller_browsertest.cc
+++ b/chrome/browser/actor/ui/actor_ui_tab_controller_browsertest.cc
@@ -156,7 +156,7 @@
base::PlatformThread::Sleep(actor::ui::kProfileScopedUiUpdateDebounceDelay);
ASSERT_TRUE(AddTabAtIndexToBrowser(browser(), 0,
- GURL(chrome::kChromeUINewTabURL),
+ chrome::ChromeUINewTabURLAsGURL(),
::ui::PAGE_TRANSITION_LINK));
auto* tab_one = browser()->GetTabStripModel()->GetTabAtIndex(0);
base::RunLoop loop;
diff --git a/chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble_interactive_uitest.cc b/chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble_interactive_uitest.cc
index 5da927d..b725a7f 100644
--- a/chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble_interactive_uitest.cc
+++ b/chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble_interactive_uitest.cc
@@ -86,7 +86,7 @@
// Add and activate the non-actuation tab.
ASSERT_TRUE(AddTabAtIndexToBrowser(browser(), 1,
- GURL(chrome::kChromeUINewTabURL),
+ chrome::ChromeUINewTabURLAsGURL(),
ui::PAGE_TRANSITION_LINK));
auto* tab_two = browser()->GetTabStripModel()->GetTabAtIndex(1);
browser()->GetTabStripModel()->ActivateTabAt(1);
Change information
Files:
- M chrome/browser/actor/ui/actor_ui_tab_controller_browsertest.cc
- M chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble_interactive_uitest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Christine Ying
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:35:15 AM (10 days ago) Apr 20
to Toni Barzic, Kevin McNee, James Maclean, chromium...@chromium.org, dmurph+wat...@chromium.org, chromium-a...@chromium.org, webap...@microsoft.com
Attention needed from Toni Barzic
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Toni Barzic to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/apps, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
diff --git a/chrome/browser/apps/app_service/launch_utils.cc b/chrome/browser/apps/app_service/launch_utils.cc
index 80aa52a..85343e5 100644
--- a/chrome/browser/apps/app_service/launch_utils.cc
+++ b/chrome/browser/apps/app_service/launch_utils.cc
@@ -97,7 +97,7 @@
Browser::CreateParams create_params(profile, /*user_gesture=*/false);
Browser* browser = Browser::Create(create_params);
- NavigateParams params(browser, GURL(chrome::kChromeUINewTabURL),
+ NavigateParams params(browser, chrome::ChromeUINewTabURLAsGURL(),
ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
params.tabstrip_add_types = AddTabTypes::ADD_ACTIVE;
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index 874e305d..ce8ffd2 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -2686,7 +2686,7 @@
GURL original_url = guest_main_frame->GetLastCommittedURL();
// Try to navigate <webview> to a chrome: URL directly.
- GURL chrome_url(chrome::kChromeUINewTabURL);
+ GURL chrome_url = chrome::ChromeUINewTabURLAsGURL();
content::TestFrameNavigationObserver observer(guest_main_frame);
guest->GetController().LoadURL(chrome_url, content::Referrer(),
ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
Change information
Files:
- M chrome/browser/apps/app_service/launch_utils.cc
- M chrome/browser/apps/guest_view/web_view_browsertest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Toni Barzic
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:35:49 AM (10 days ago) Apr 20
to Mike Dougherty, chromium...@chromium.org
Attention needed from Mike Dougherty
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Mike Dougherty to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/breadcrumbs, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
diff --git a/chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper.cc b/chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper.cc
index 59683b9..30d8d5ba 100644
--- a/chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper.cc
+++ b/chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper.cc
@@ -17,10 +17,10 @@
namespace {
bool IsNtpUrl(const GURL& url) {
- const std::string origin = url.DeprecatedGetOriginAsURL().spec();
- return origin == chrome::kChromeUINewTabURL ||
- origin == chrome::kChromeUINewTabPageURL ||
- origin == chrome::kChromeUINewTabPageThirdPartyURL;
+ const GURL origin = url.DeprecatedGetOriginAsURL();
+ return origin == chrome::ChromeUINewTabURLAsGURL() ||
+ origin == chrome::ChromeUINewTabPageURLAsGURL() ||
+ origin.spec() == chrome::kChromeUINewTabPageThirdPartyURL;
}
} // namespace
diff --git a/chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper_unittest.cc b/chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper_unittest.cc
index a3ed3be..f9e99c63 100644
--- a/chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper_unittest.cc
+++ b/chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper_unittest.cc
@@ -182,7 +182,7 @@
TEST_F(BreadcrumbManagerTabHelperTest, ChromeNewTabNavigationStart) {
ASSERT_EQ(0u, GetNumEvents());
auto simulator = content::NavigationSimulator::CreateBrowserInitiated(
- GURL(chrome::kChromeUINewTabURL), web_contents());
+ chrome::ChromeUINewTabURLAsGURL(), web_contents());
simulator->Start();
const auto& events = GetEvents();
ASSERT_EQ(1u, events.size());
@@ -353,7 +353,7 @@
TEST_F(BreadcrumbManagerTabHelperTest, NtpPageLoad) {
ASSERT_EQ(0u, GetNumEvents());
content::NavigationSimulator::NavigateAndCommitFromBrowser(
- web_contents(), GURL(chrome::kChromeUINewTabURL));
+ web_contents(), chrome::ChromeUINewTabURLAsGURL());
const auto& events = GetEvents();
ASSERT_EQ(3u, events.size());
EXPECT_NE(std::string::npos,
Change information
Files:
- M chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper.cc
- M chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper_unittest.cc
Change size: S
Delta: 2 files changed, 6 insertions(+), 6 deletions(-)
Related details
Attention is currently required from:
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:36:36 AM (10 days ago) Apr 20
to Avi Drissman, Enterprise Policy Reviews, devtools...@chromium.org, chromium...@chromium.org, dullweb...@chromium.org, svend+w...@chromium.org, oshima...@chromium.org, vasilii+watchlis...@chromium.org, jdh+wa...@chromium.org, ortuno+w...@chromium.org, gcasto+w...@chromium.org, njeunje+...@chromium.org, msrame...@chromium.org, amaliev+...@chromium.org, liu+wa...@chromium.org
Attention needed from Avi Drissman
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Avi Drissman to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in ['chrome/browser/browsing_data', 'chrome/browser/btm', 'chrome/browser/chromeos', 'chrome/browser/content_settings', 'chrome/browser/devtools', 'chrome/browser/password_manager', 'chrome/browser/policy', 'chrome/browser/profiles', 'chrome/browser/renderer_context_menu', 'chrome/browser/supervised_user', 'chrome/browser/win'], avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
- M chrome/browser/btm/btm_service_unittest.cc
- M chrome/browser/chromeos/tablet_mode/tablet_mode_page_behavior_browsertest.cc
- M chrome/browser/content_settings/host_content_settings_map_unittest.cc
- M chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc
- M chrome/browser/password_manager/chrome_password_manager_client.cc
- M chrome/browser/policy/login_policy_test_base_browsertest.cc
- M chrome/browser/profiles/profile_impl.cc
- M chrome/browser/renderer_context_menu/render_view_context_menu.cc
- M chrome/browser/supervised_user/supervised_user_browser_utils.cc
- M chrome/browser/win/installer_downloader/installer_downloader_interactive_uitest.cc
Change size: S
Delta: 11 files changed, 17 insertions(+), 17 deletions(-)
Related details
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:37:07 AM (10 days ago) Apr 20
to Sébastien Lalancette, chromium...@chromium.org, cbe-cep-eng...@google.com
Attention needed from Sébastien Lalancette
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Sébastien Lalancette to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/enterprise/connectors/interstitials, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
diff --git a/chrome/browser/enterprise/connectors/interstitials/enterprise_block_controller_client.cc b/chrome/browser/enterprise/connectors/interstitials/enterprise_block_controller_client.cc
index 272e4d83..1109158 100644
--- a/chrome/browser/enterprise/connectors/interstitials/enterprise_block_controller_client.cc
+++ b/chrome/browser/enterprise/connectors/interstitials/enterprise_block_controller_client.cc
@@ -36,7 +36,7 @@
Profile::FromBrowserContext(web_contents->GetBrowserContext())
->GetPrefs(),
g_browser_process->GetApplicationLocale(),
- GURL(chrome::kChromeUINewTabURL),
+ chrome::ChromeUINewTabURLAsGURL(),
/*settings_page_helper=*/nullptr),
request_url_(request_url) {}
diff --git a/chrome/browser/enterprise/connectors/interstitials/enterprise_warn_controller_client.cc b/chrome/browser/enterprise/connectors/interstitials/enterprise_warn_controller_client.cc
index 91e84fd..ca28682e 100644
--- a/chrome/browser/enterprise/connectors/interstitials/enterprise_warn_controller_client.cc
+++ b/chrome/browser/enterprise/connectors/interstitials/enterprise_warn_controller_client.cc
@@ -36,7 +36,7 @@
Profile::FromBrowserContext(web_contents->GetBrowserContext())
->GetPrefs(),
g_browser_process->GetApplicationLocale(),
- GURL(chrome::kChromeUINewTabURL),
+ chrome::ChromeUINewTabURLAsGURL(),
/*settings_page_helper=*/nullptr),
request_url_(request_url) {}
Change information
Files:
- M chrome/browser/enterprise/connectors/interstitials/enterprise_block_controller_client.cc
- M chrome/browser/enterprise/connectors/interstitials/enterprise_warn_controller_client.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Sébastien Lalancette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:37:48 AM (10 days ago) Apr 20
to Yann Dago, chromium...@chromium.org
Attention needed from Yann Dago
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Yann Dago to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/enterprise/signin, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/enterprise/signin/interstitials/managed_profile_required_controller_client.cc
- M chrome/browser/enterprise/signin/oidc_authentication_signin_interceptor.cc
- M chrome/browser/enterprise/signin/profile_token_web_signin_interceptor.cc
Change size: XS
Delta: 3 files changed, 3 insertions(+), 3 deletions(-)
Related details
Attention is currently required from:
- Yann Dago
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:38:20 AM (10 days ago) Apr 20
to Andrea Orru, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Andrea Orru
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Andrea Orru to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/extensions, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/extensions/content_script_apitest.cc
- M chrome/browser/extensions/error_console/error_console_browsertest.cc
- M chrome/browser/extensions/extension_browser_window_helper.cc
- M chrome/browser/extensions/extension_override_apitest.cc
- M chrome/browser/extensions/extension_tab_util_browsertest.cc
- M chrome/browser/extensions/extension_url_overrides_unittest.cc
- M chrome/browser/extensions/extension_url_rewrite_browsertest.cc
- M chrome/browser/extensions/lazy_background_page_apitest.cc
- M chrome/browser/extensions/permissions/active_tab_unittest.cc
- M chrome/browser/extensions/process_management_browsertest.cc
- M chrome/browser/extensions/settings_api_helpers.cc
Change size: S
Delta: 11 files changed, 23 insertions(+), 22 deletions(-)
Related details
Attention is currently required from:
- Andrea Orru
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:38:56 AM (10 days ago) Apr 20
to Finnur Thorarinsson, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Finnur Thorarinsson
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Finnur Thorarinsson to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/extensions/api, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/extensions/api/chrome_extensions_api_client.cc
- M chrome/browser/extensions/api/chrome_extensions_api_client_unittest.cc
- M chrome/browser/extensions/api/tabs/tabs_api.cc
Change size: XS
Delta: 3 files changed, 4 insertions(+), 4 deletions(-)
Related details
Attention is currently required from:
- Finnur Thorarinsson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:39:42 AM (10 days ago) Apr 20
to Dominic Battré, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Dominic Battré
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Dominic Battré to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/extensions/api/web_request, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
index 1e68232..62ccde1 100644
--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
@@ -3159,7 +3159,7 @@
// Navigate to the NTP. The request for "fake_ntp_script.js" should not have
// reached the extension, since it was made by the instant NTP renderer, which
// is semi-privileged.
- ASSERT_TRUE(NavigateToURL(web_contents, GURL(chrome::kChromeUINewTabURL)));
+ ASSERT_TRUE(NavigateToURL(web_contents, chrome::ChromeUINewTabURLAsGURL()));
EXPECT_TRUE(was_ntp_script_loaded(web_contents));
ASSERT_TRUE(search::IsInstantNTP(web_contents));
EXPECT_FALSE(was_script_request_intercepted(extension->id()));
@@ -3296,7 +3296,7 @@
ASSERT_FALSE(GetAndResetOneGoogleBarRequestSeen());
auto* web_contents = GetActiveWebContents();
- ASSERT_TRUE(NavigateToURL(web_contents, GURL(chrome::kChromeUINewTabURL)));
+ ASSERT_TRUE(NavigateToURL(web_contents, chrome::ChromeUINewTabURLAsGURL()));
ASSERT_EQ(ntp_test_utils::GetFinalNtpUrl(profile()),
GetActiveWebContents()->GetLastCommittedURL());
WaitForOneGoogleBarDataUpdate();
diff --git a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
index 540881f6..11f34a5 100644
--- a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
@@ -127,7 +127,7 @@
};
url::Origin ntp_origin =
- url::Origin::Create(GURL(chrome::kChromeUINewTabPageURL));
+ url::Origin::Create(chrome::ChromeUINewTabPageURLAsGURL());
// Sub-resource browser initiated requests are hidden from extensions.
WebRequestInfoInitParams info_params_1 = create_request_params(
Change information
Files:
- M chrome/browser/extensions/api/web_request/web_request_apitest.cc
- M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
Change size: XS
Delta: 2 files changed, 3 insertions(+), 3 deletions(-)
Related details
Attention is currently required from:
- Dominic Battré
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:40:18 AM (10 days ago) Apr 20
to Bryant Chandler, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Bryant Chandler
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Bryant Chandler to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/glic, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/glic/actor/glic_actor_tab_functional_browsertest.cc
- M chrome/browser/glic/host/glic_actor_general_interactive_uitest.cc
- M chrome/browser/glic/service/glic_invoke_handler.cc
Change size: S
Delta: 3 files changed, 5 insertions(+), 5 deletions(-)
Related details
Attention is currently required from:
- Bryant Chandler
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:40:46 AM (10 days ago) Apr 20
to Erik Chen, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Erik Chen
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Erik Chen to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/glic/host/context, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
diff --git a/chrome/browser/glic/host/context/glic_sharing_utils.cc b/chrome/browser/glic/host/context/glic_sharing_utils.cc
index b564115..e16c78d 100644
--- a/chrome/browser/glic/host/context/glic_sharing_utils.cc
+++ b/chrome/browser/glic/host/context/glic_sharing_utils.cc
@@ -35,7 +35,7 @@
static const base::NoDestructor<std::vector<GURL>> kUrlAllowList{
{GURL(), GURL(url::kAboutBlankURL),
GURL(chrome::kChromeUINewTabPageThirdPartyURL),
- GURL(chrome::kChromeUINewTabPageURL), GURL(chrome::kChromeUINewTabURL),
+ chrome::ChromeUINewTabPageURLAsGURL(), chrome::ChromeUINewTabURLAsGURL(),
#if BUILDFLAG(IS_ANDROID)
GURL(chrome::kChromeUINativeNewTabURL),
#endif
diff --git a/chrome/browser/glic/host/context/glic_sharing_utils_unittest.cc b/chrome/browser/glic/host/context/glic_sharing_utils_unittest.cc
index 3c4e5d67..9e05859 100644
--- a/chrome/browser/glic/host/context/glic_sharing_utils_unittest.cc
+++ b/chrome/browser/glic/host/context/glic_sharing_utils_unittest.cc
@@ -47,7 +47,7 @@
TEST_F(GlicSharingUtilsTest, IsTabValidForSharing_ChromeUINewTab) {
content::WebContents* web_contents =
- CreateWebContents(GURL(chrome::kChromeUINewTabURL));
+ CreateWebContents(chrome::ChromeUINewTabURLAsGURL());
EXPECT_TRUE(IsTabValidForSharing(web_contents));
}
Change information
Files:
- M chrome/browser/glic/host/context/glic_sharing_utils.cc
- M chrome/browser/glic/host/context/glic_sharing_utils_unittest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Erik Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:41:20 AM (10 days ago) Apr 20
to Zekun Jiang, chromium...@chromium.org, dewitt...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
Attention needed from Zekun Jiang
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Zekun Jiang to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/glic/suggestions, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
diff --git a/chrome/browser/glic/suggestions/contextual_cueing_helper_interactive_uitest.cc b/chrome/browser/glic/suggestions/contextual_cueing_helper_interactive_uitest.cc
index be15afa..48a87ed 100644
--- a/chrome/browser/glic/suggestions/contextual_cueing_helper_interactive_uitest.cc
+++ b/chrome/browser/glic/suggestions/contextual_cueing_helper_interactive_uitest.cc
@@ -264,7 +264,7 @@
SwapToFakeDelegate(nudge_delegate);
ASSERT_TRUE(ui_test_utils::NavigateToURLWithDisposition(
- browser(), GURL(chrome::kChromeUINewTabURL),
+ browser(), chrome::ChromeUINewTabURLAsGURL(),
WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP));
EXPECT_FALSE(nudge_delegate.GetIsShowingGlicNudge());
diff --git a/chrome/browser/glic/suggestions/contextual_cueing_service_browsertest.cc b/chrome/browser/glic/suggestions/contextual_cueing_service_browsertest.cc
index e0b4a0f..e35b899 100644
--- a/chrome/browser/glic/suggestions/contextual_cueing_service_browsertest.cc
+++ b/chrome/browser/glic/suggestions/contextual_cueing_service_browsertest.cc
@@ -294,7 +294,7 @@
ASSERT_TRUE(embedded_test_server()->Start());
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(),
- GURL(chrome::kChromeUINewTabURL)));
+ chrome::ChromeUINewTabURLAsGURL()));
base::test::TestFuture<std::vector<std::string>> future;
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
Change information
Files:
- M chrome/browser/glic/suggestions/contextual_cueing_helper_interactive_uitest.cc
- M chrome/browser/glic/suggestions/contextual_cueing_service_browsertest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Zekun Jiang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Finnur Thorarinsson (Gerrit)
Apr 20, 2026, 11:41:54 AM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Antonio Sartori
Finnur Thorarinsson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:41:54 AM (10 days ago) Apr 20
to Emily Stark, chromium...@chromium.org, jdeblas...@chromium.org
Attention needed from Emily Stark
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Emily Stark to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/lookalikes, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/lookalikes/lookalike_url_blocking_page.cc
- M chrome/browser/lookalikes/lookalike_url_controller_client.cc
- M chrome/browser/lookalikes/lookalike_url_navigation_throttle_browsertest.cc
Change size: XS
Delta: 3 files changed, 3 insertions(+), 3 deletions(-)
Related details
Attention is currently required from:
- Emily Stark
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:42:27 AM (10 days ago) Apr 20
to Paul Adedeji, chromium...@chromium.org
Attention needed from Paul Adedeji
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Paul Adedeji to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/new_tab_page, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/new_tab_page/modules/new_tab_page_modules_interactive_uitest.cc
- M chrome/browser/new_tab_page/new_tab_page_interactive_uitest.cc
- M chrome/browser/new_tab_page/new_tab_page_realbox_interactive_uitest.cc
- M chrome/browser/new_tab_page/one_google_bar/one_google_bar_loader_impl.cc
- M chrome/browser/new_tab_page/promos/promo_service.cc
Change size: M
Delta: 5 files changed, 28 insertions(+), 27 deletions(-)
Related details
Attention is currently required from:
- Paul Adedeji
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christine Ying (Gerrit)
Apr 20, 2026, 11:42:32 AM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, mfoltz+wa...@chromium.org
Attention needed from Antonio Sartori
Christine Ying voted![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:42:59 AM (10 days ago) Apr 20
to Takashi Toyoshima, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
Attention needed from Takashi Toyoshima
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Takashi Toyoshima to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/page_load_metrics/observers, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/page_load_metrics/observers/chrome_gws_page_load_metrics_observer.cc
- M chrome/browser/page_load_metrics/observers/new_tab_page_page_load_metrics_observer.cc
- M chrome/browser/page_load_metrics/observers/new_tab_page_page_load_metrics_observer_browsertest.cc
Change size: XS
Delta: 3 files changed, 3 insertions(+), 3 deletions(-)
Related details
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:43:38 AM (10 days ago) Apr 20
to Elias Klim, Permissions Reviews, chromium...@chromium.org
Attention needed from Elias Klim
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Elias Klim to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/permissions, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/permissions/permission_manager_unittest.cc
- M chrome/browser/permissions/permission_subscription_unittest.cc
- M chrome/browser/permissions/permissions_security_model_interactive_uitest.cc
Change size: S
Delta: 3 files changed, 12 insertions(+), 12 deletions(-)
Related details
Attention is currently required from:
- Elias Klim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:44:15 AM (10 days ago) Apr 20
to Igor Ruvinov, Enterprise Policy Reviews, chromium...@chromium.org
Attention needed from Igor Ruvinov
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Igor Ruvinov to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/policy/test, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/policy/test/locale_policy_browsertest.cc
- M chrome/browser/policy/test/promotional_tabs_enabled_policy_browsertest.cc
- M chrome/browser/policy/test/restore_on_startup_policy_browsertest.cc
Change size: S
Delta: 3 files changed, 6 insertions(+), 6 deletions(-)
Related details
Attention is currently required from:
- Igor Ruvinov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:44:48 AM (10 days ago) Apr 20
to Lingqi Chi, prerendering-reviews, chromium...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Lingqi Chi
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Lingqi Chi to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/preloading, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/preloading/prefetch/zero_suggest_prefetch/zero_suggest_prefetch_tab_helper_browsertest.cc
- M chrome/browser/preloading/prerender/prerender_browsertest.cc
Change size: S
Delta: 2 files changed, 6 insertions(+), 6 deletions(-)
Related details
Attention is currently required from:
- Lingqi Chi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:45:25 AM (10 days ago) Apr 20
to thefrog, chromium...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, zackha...@chromium.org, xinghui...@chromium.org
Attention needed from thefrog
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like thefrog to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/safe_browsing, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
- M chrome/browser/safe_browsing/client_side_detection_host_browsertest.cc
- M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
- M chrome/browser/safe_browsing/notification_telemetry/notification_telemetry_service_unittest.cc
- M chrome/browser/safe_browsing/phishy_interaction_tracker_unittest.cc
- M chrome/browser/safe_browsing/safe_browsing_service.cc
- M chrome/browser/safe_browsing/test_safe_browsing_service.cc
- M chrome/browser/safe_browsing/threat_details_unittest.cc
Change size: S
Delta: 8 files changed, 10 insertions(+), 10 deletions(-)
Related details
Attention is currently required from:
- thefrog
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:45:55 AM (10 days ago) Apr 20
to chromium...@chromium.org
Attention needed from Moe Ahmadi
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Moe Ahmadi to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/search, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/search/search.cc
- M chrome/browser/search/search_unittest.cc
Change size: S
Delta: 2 files changed, 13 insertions(+), 13 deletions(-)
Related details
Attention is currently required from:
- Moe Ahmadi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:46:35 AM (10 days ago) Apr 20
to Nicolas Dossou-Gbété, chromium...@chromium.org, chrome-regionalc...@google.com
Attention needed from Nicolas Dossou-Gbété
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Nicolas Dossou-Gbété to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/search_engine_choice, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/search_engine_choice/search_engine_choice_dialog_browsertest.cc
- M chrome/browser/search_engine_choice/search_engine_choice_dialog_interactive_uitest.cc
- M chrome/browser/search_engine_choice/search_engine_choice_dialog_service.cc
- M chrome/browser/search_engine_choice/search_engine_choice_dialog_service_unittest.cc
Change size: S
Delta: 4 files changed, 18 insertions(+), 18 deletions(-)
Related details
Attention is currently required from:
- Nicolas Dossou-Gbété
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:47:07 AM (10 days ago) Apr 20
to Darryl James, chromium...@chromium.org
Attention needed from Darryl James
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Darryl James to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/sessions, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/sessions/chrome_tab_restore_service_client.cc
- M chrome/browser/sessions/session_restore.cc
- M chrome/browser/sessions/session_restore_browsertest.cc
- M chrome/browser/sessions/tab_restore_browsertest.cc
- M chrome/browser/sessions/tab_restore_service_unittest.cc
Change size: M
Delta: 5 files changed, 30 insertions(+), 30 deletions(-)
Related details
Attention is currently required from:
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 11:47:41 AM (10 days ago) Apr 20
to Samar Chehade, chromium...@chromium.org
Attention needed from Samar Chehade
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Samar Chehade to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/signin, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/signin/dice_browsertest.cc
- M chrome/browser/signin/dice_intercepted_session_startup_helper.cc
- M chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
Change size: S
Delta: 3 files changed, 8 insertions(+), 7 deletions(-)
Related details
Attention is currently required from:
- Samar Chehade
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
thefrog (Gerrit)
Apr 20, 2026, 11:52:17 AM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Antonio Sartori
thefrog voted and added 1 comment![]( "Open in Gerrit")
Votes added by thefrog
| Code-Review | +1 |
1 comment
Commit Message
Line 17, Patchset 1 (Latest):
Bug: 503370195thefrog . unresolved
nit: please use `b:` for the Google-internal issue tracker ([docs](https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md#cl-footer-reference)).
```suggestion
Bug: b:503370195
```
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas Dossou-Gbété (Gerrit)
Apr 20, 2026, 11:55:25 AM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, chrome-regionalc...@google.com
Attention needed from Antonio Sartori
Nicolas Dossou-Gbété voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Apr 20, 2026, 12:01:48 PM (10 days ago) Apr 20
to Antonio Sartori, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, cros-print...@google.com, print-rev...@chromium.org, subresource-f...@chromium.org
Attention needed from Antonio Sartori
Marc Treib voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Battré (Gerrit)
Apr 20, 2026, 12:04:10 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Antonio Sartori
Dominic Battré voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 12:19:14 PM (10 days ago) Apr 20
to thefrog, chromium...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Antonio Sartori voted and added 1 comment![]( "Open in Gerrit")
Votes added by Antonio Sartori
| Auto-Submit | +1 |
| Commit-Queue | +2 |
nit: please use `b:` for the Google-internal issue tracker ([docs](https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md#cl-footer-reference)).
```suggestion
Bug: b:503370195
```
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 12:19:44 PM (10 days ago) Apr 20
to Carlos IL, chromium...@chromium.org
Attention needed from Carlos IL
Antonio Sartori voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Carlos IL
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 20, 2026, 12:20:23 PM (10 days ago) Apr 20
to Finnur Thorarinsson, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Antonio Sartori voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos IL (Gerrit)
Apr 20, 2026, 12:24:41 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org
Attention needed from Antonio Sartori
Carlos IL voted and added 1 comment![]( "Open in Gerrit")
Votes added by Carlos IL
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Apr 20, 2026, 12:29:27 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org
Attention needed from Antonio Sartori
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Darryl James . resolved
lgtm! Thanks!
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 12:37:07 PM (10 days ago) Apr 20
to Antonio Sartori, Christine Ying, chromium...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, mfoltz+wa...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/actor/ui, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I0dc3a4266962c4c2a8eb340453ad4564f8aef7ae
Reviewed-by: Christine Ying <chr...@google.com>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Christine Ying <chr...@google.com>
Cr-Commit-Position: refs/heads/main@{#1617555}
Files:
- M chrome/browser/actor/ui/actor_ui_tab_controller_browsertest.cc
- M chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble_interactive_uitest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Christine Ying
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
Apr 20, 2026, 12:42:43 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Antonio Sartori
Erik Chen voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zekun Jiang (Gerrit)
Apr 20, 2026, 12:54:24 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org
Attention needed from Antonio Sartori
Zekun Jiang voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 12:56:14 PM (10 days ago) Apr 20
to Antonio Sartori, Dominic Battré, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/extensions/api/web_request, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: Ie26d69dc6bb63a8c0a5992aee76adc77a72ba59a
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Dominic Battré <bat...@chromium.org>
Commit-Queue: Dominic Battré <bat...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617564}
Files:
- M chrome/browser/extensions/api/web_request/web_request_apitest.cc
- M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
Change size: XS
Delta: 2 files changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominic Battré
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 1:02:17 PM (10 days ago) Apr 20
to Antonio Sartori, Marc Treib, chromium...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, cros-print...@google.com, print-rev...@chromium.org, subresource-f...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in ['chrome/browser', 'chrome/browser/first_run', 'chrome/browser/history', 'chrome/browser/printing', 'chrome/browser/privacy_sandbox', 'chrome/browser/resource_coordinator', 'chrome/browser/subresource_filter'], avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I74c0ac447e2c9c0ae7f6190e3b0986891e6ac5e6
Commit-Queue: Marc Treib <tr...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Marc Treib <tr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617570}
Files:
- M chrome/browser/browser_process_platform_part_ash_browsertest.cc
- M chrome/browser/chrome_content_browser_client.cc
- M chrome/browser/chrome_content_browser_client_browsertest.cc
- M chrome/browser/chrome_content_browser_client_unittest.cc
- M chrome/browser/first_run/first_run_browsertest.cc
- M chrome/browser/history/history_browsertest.cc
- M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
- M chrome/browser/privacy_sandbox/notice/desktop_entrypoint_handlers_helper.cc
- M chrome/browser/resource_coordinator/tab_manager_unittest.cc
- M chrome/browser/subresource_filter/subresource_filter_disabled_reason_uma_browsertest.cc
Change size: S
Delta: 10 files changed, 20 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Marc Treib
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 1:12:35 PM (10 days ago) Apr 20
to Antonio Sartori, Nicolas Dossou-Gbété, chromium...@chromium.org, chrome-regionalc...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/search_engine_choice, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I8ce9278bef6244e92d2274a981134cf4f063d572
Commit-Queue: Nicolas Dossou-Gbété <d...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <d...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617577}
Files:
- M chrome/browser/search_engine_choice/search_engine_choice_dialog_browsertest.cc
- M chrome/browser/search_engine_choice/search_engine_choice_dialog_interactive_uitest.cc
- M chrome/browser/search_engine_choice/search_engine_choice_dialog_service.cc
- M chrome/browser/search_engine_choice/search_engine_choice_dialog_service_unittest.cc
Change size: S
Delta: 4 files changed, 18 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nicolas Dossou-Gbété
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 1:31:59 PM (10 days ago) Apr 20
to Antonio Sartori, Finnur Thorarinsson, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/extensions/api, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: Id0259e1cabd492046aa33992766f1cc0dfcc76be
Reviewed-by: Finnur Thorarinsson <fin...@chromium.org>
Commit-Queue: Antonio Sartori <antonio...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617589}
Files:
- M chrome/browser/extensions/api/chrome_extensions_api_client.cc
- M chrome/browser/extensions/api/chrome_extensions_api_client_unittest.cc
- M chrome/browser/extensions/api/tabs/tabs_api.cc
Change size: XS
Delta: 3 files changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Finnur Thorarinsson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Riley Tatum (Gerrit)
Apr 20, 2026, 1:37:40 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org
Attention needed from Antonio Sartori
Riley Tatum voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 1:41:15 PM (10 days ago) Apr 20
to Antonio Sartori, thefrog, chromium...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/safe_browsing, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: b:503370195
Change-Id: Iede42e8aa20ef37a18ed931291731e794d3b5be7
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: thefrog <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617601}
Files:
- M chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
- M chrome/browser/safe_browsing/client_side_detection_host_browsertest.cc
- M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
- M chrome/browser/safe_browsing/notification_telemetry/notification_telemetry_service_unittest.cc
- M chrome/browser/safe_browsing/phishy_interaction_tracker_unittest.cc
- M chrome/browser/safe_browsing/safe_browsing_service.cc
- M chrome/browser/safe_browsing/test_safe_browsing_service.cc
- M chrome/browser/safe_browsing/threat_details_unittest.cc
Change size: S
Delta: 8 files changed, 10 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by thefrog
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 1:45:04 PM (10 days ago) Apr 20
to Antonio Sartori, Carlos IL, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ssl, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
NO_IFTTT=Does not apply here
Bug: b:503370195
Change-Id: Ia7a875ada37c726e861d5ab5d8bf95277893b7fd
Reviewed-by: Carlos IL <carl...@chromium.org>
Commit-Queue: Carlos IL <carl...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617605}
Files:
- M chrome/browser/ssl/ask_before_http_dialog_controller.cc
- M chrome/browser/ssl/https_only_mode_controller_client.cc
- M chrome/browser/ssl/insecure_form/insecure_form_controller_client.cc
- M chrome/browser/ssl/ssl_error_controller_client.cc
Change size: XS
Delta: 4 files changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Carlos IL
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 1:48:45 PM (10 days ago) Apr 20
to Antonio Sartori, Darryl James, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/sessions, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I8717084fe9c1aee42b719df8eaf39003afb9a51f
Reviewed-by: Darryl James <dlj...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Darryl James <dlj...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617606}
Files:
- M chrome/browser/sessions/chrome_tab_restore_service_client.cc
- M chrome/browser/sessions/session_restore.cc
- M chrome/browser/sessions/session_restore_browsertest.cc
- M chrome/browser/sessions/tab_restore_browsertest.cc
- M chrome/browser/sessions/tab_restore_service_unittest.cc
Change size: M
Delta: 5 files changed, 30 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darryl James
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrea Orru (Gerrit)
Apr 20, 2026, 1:56:13 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Antonio Sartori
Andrea Orru voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 2:31:08 PM (10 days ago) Apr 20
to Antonio Sartori, Zekun Jiang, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/glic/suggestions, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I83762843695a642139d7148c4745ac755d5f9d8c
Reviewed-by: Zekun Jiang <zekun...@google.com>
Commit-Queue: Zekun Jiang <zekun...@google.com>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617647}
Files:
- M chrome/browser/glic/suggestions/contextual_cueing_helper_interactive_uitest.cc
- M chrome/browser/glic/suggestions/contextual_cueing_service_browsertest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Zekun Jiang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Ruvinov (Gerrit)
Apr 20, 2026, 2:37:39 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, Enterprise Policy Reviews
Attention needed from Antonio Sartori
Igor Ruvinov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Ruvinov
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Igor Ruvinov . resolved
Thanks!
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 3:01:38 PM (10 days ago) Apr 20
to Antonio Sartori, Riley Tatum, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/new_tab_page, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: Id0013de0451bce564753118fda2eccd7c3b856bf
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Riley Tatum <rta...@google.com>
Commit-Queue: Riley Tatum <rta...@google.com>
Cr-Commit-Position: refs/heads/main@{#1617677}
Files:
- M chrome/browser/new_tab_page/modules/new_tab_page_modules_interactive_uitest.cc
- M chrome/browser/new_tab_page/new_tab_page_interactive_uitest.cc
- M chrome/browser/new_tab_page/new_tab_page_realbox_interactive_uitest.cc
- M chrome/browser/new_tab_page/one_google_bar/one_google_bar_loader_impl.cc
- M chrome/browser/new_tab_page/promos/promo_service.cc
Change size: M
Delta: 5 files changed, 28 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Riley Tatum
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sébastien Lalancette (Gerrit)
Apr 20, 2026, 3:09:06 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, cbe-cep-eng...@google.com
Attention needed from Antonio Sartori
Sébastien Lalancette voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 3:28:56 PM (10 days ago) Apr 20
to Antonio Sartori, Igor Ruvinov, chromium...@chromium.org, Enterprise Policy Reviews
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/policy/test, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I0d1e03b00566b2a06378645178490f02dc8a6863
Reviewed-by: Igor Ruvinov <igorr...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Igor Ruvinov <igorr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617695}
Files:
- M chrome/browser/policy/test/locale_policy_browsertest.cc
- M chrome/browser/policy/test/promotional_tabs_enabled_policy_browsertest.cc
- M chrome/browser/policy/test/restore_on_startup_policy_browsertest.cc
Change size: S
Delta: 3 files changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Igor Ruvinov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Dougherty (Gerrit)
Apr 20, 2026, 3:30:19 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org
Attention needed from Antonio Sartori
Mike Dougherty voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 4:12:17 PM (10 days ago) Apr 20
to Antonio Sartori, Sébastien Lalancette, chromium...@chromium.org, cbe-cep-eng...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/enterprise/connectors/interstitials, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I07d981915acabc003d21b59e4bb8f1ca75bed1e2
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Sébastien Lalancette <seblal...@chromium.org>
Commit-Queue: Sébastien Lalancette <seblal...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617730}
Files:
- M chrome/browser/enterprise/connectors/interstitials/enterprise_block_controller_client.cc
- M chrome/browser/enterprise/connectors/interstitials/enterprise_warn_controller_client.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sébastien Lalancette
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 4:47:05 PM (10 days ago) Apr 20
to Antonio Sartori, Mike Dougherty, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/breadcrumbs, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I29e46f7375e1646fcf353a390f2154a0ababff74
Reviewed-by: Mike Dougherty <mich...@chromium.org>
Commit-Queue: Mike Dougherty <mich...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617755}
Files:
- M chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper.cc
- M chrome/browser/breadcrumbs/breadcrumb_manager_tab_helper_unittest.cc
Change size: S
Delta: 2 files changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mike Dougherty
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Apr 20, 2026, 8:18:14 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org
Attention needed from Antonio Sartori
Hidehiko Abe voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 9:07:45 PM (10 days ago) Apr 20
to Antonio Sartori, Hidehiko Abe, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: Ibdcae12c4a4df533e9cd3565b8359ece7a3d30db
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Hidehiko Abe <hide...@chromium.org>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617917}
Files:
- M chrome/test/base/testing_profile.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lingqi Chi (Gerrit)
Apr 20, 2026, 9:37:34 PM (10 days ago) Apr 20
to Antonio Sartori, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Antonio Sartori
Lingqi Chi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lingqi Chi
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Lingqi Chi . resolved
thank you!!
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 10:43:59 PM (10 days ago) Apr 20
to Antonio Sartori, Lingqi Chi, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/preloading, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I1017bbdf8dea2586f57ce0f524e224ff8d2c6de0
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Lingqi Chi <lin...@chromium.org>
Commit-Queue: Lingqi Chi <lin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617945}
Files:
- M chrome/browser/preloading/prefetch/zero_suggest_prefetch/zero_suggest_prefetch_tab_helper_browsertest.cc
- M chrome/browser/preloading/prerender/prerender_browsertest.cc
Change size: S
Delta: 2 files changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lingqi Chi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 21, 2026, 2:19:13 AM (10 days ago) Apr 21
to chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Antonio Sartori voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 21, 2026, 2:19:20 AM (10 days ago) Apr 21
to Erik Chen, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Antonio Sartori voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 3:43:50 AM (10 days ago) Apr 21
to Antonio Sartori, Andrea Orru, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/extensions, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I0d0a7fe91a356852cc5684c7c2b858929d7214a3
Reviewed-by: Andrea Orru <andre...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618016}
Files:
- M chrome/browser/extensions/content_script_apitest.cc
- M chrome/browser/extensions/error_console/error_console_browsertest.cc
- M chrome/browser/extensions/extension_browser_window_helper.cc
- M chrome/browser/extensions/extension_override_apitest.cc
- M chrome/browser/extensions/extension_tab_util_browsertest.cc
- M chrome/browser/extensions/extension_url_overrides_unittest.cc
- M chrome/browser/extensions/extension_url_rewrite_browsertest.cc
- M chrome/browser/extensions/lazy_background_page_apitest.cc
- M chrome/browser/extensions/permissions/active_tab_unittest.cc
- M chrome/browser/extensions/process_management_browsertest.cc
- M chrome/browser/extensions/settings_api_helpers.cc
Change size: S
Delta: 11 files changed, 23 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrea Orru
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Apr 21, 2026, 4:23:55 AM (10 days ago) Apr 21
to Antonio Sartori, Marc Treib, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, amaliev+...@chromium.org, dullweb...@chromium.org, gcasto+w...@chromium.org, jdh+wa...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, njeunje+...@chromium.org, ortuno+w...@chromium.org, oshima...@chromium.org, svend+w...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Antonio Sartori
Marc Treib voted![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 4:26:19 AM (10 days ago) Apr 21
to Antonio Sartori, Erik Chen, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/glic/host/context, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: Ia0735d5556142b5f8b8a9e36e796220e75585dc5
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Erik Chen <erik...@chromium.org>
Commit-Queue: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618030}
Files:
- M chrome/browser/glic/host/context/glic_sharing_utils.cc
- M chrome/browser/glic/host/context/glic_sharing_utils_unittest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Erik Chen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
Apr 21, 2026, 4:31:14 AM (10 days ago) Apr 21
to Antonio Sartori, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Antonio Sartori
Takashi Toyoshima voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Judith Hemp (Gerrit)
Apr 21, 2026, 5:25:43 AM (10 days ago) Apr 21
to Antonio Sartori, chromium...@chromium.org, Permissions Reviews
Attention needed from Antonio Sartori
Judith Hemp voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 5:44:56 AM (10 days ago) Apr 21
to Antonio Sartori, Marc Treib, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, amaliev+...@chromium.org, dullweb...@chromium.org, gcasto+w...@chromium.org, jdh+wa...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, njeunje+...@chromium.org, ortuno+w...@chromium.org, oshima...@chromium.org, svend+w...@chromium.org, vasilii+watchlis...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in ['chrome/browser/browsing_data', 'chrome/browser/btm', 'chrome/browser/chromeos', 'chrome/browser/content_settings', 'chrome/browser/devtools', 'chrome/browser/password_manager', 'chrome/browser/policy', 'chrome/browser/profiles', 'chrome/browser/renderer_context_menu', 'chrome/browser/supervised_user', 'chrome/browser/win'], avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: Id6a90bbe94d74c3a53e04c83c8a28212142a8eca
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Marc Treib <tr...@chromium.org>
Commit-Queue: Marc Treib <tr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618065}
Files:
- M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
- M chrome/browser/btm/btm_service_unittest.cc
- M chrome/browser/chromeos/tablet_mode/tablet_mode_page_behavior_browsertest.cc
- M chrome/browser/content_settings/host_content_settings_map_unittest.cc
- M chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc
- M chrome/browser/password_manager/chrome_password_manager_client.cc
- M chrome/browser/policy/login_policy_test_base_browsertest.cc
- M chrome/browser/profiles/profile_impl.cc
- M chrome/browser/renderer_context_menu/render_view_context_menu.cc
- M chrome/browser/supervised_user/supervised_user_browser_utils.cc
- M chrome/browser/win/installer_downloader/installer_downloader_interactive_uitest.cc
Change size: S
Delta: 11 files changed, 17 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Marc Treib
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 21, 2026, 8:22:14 AM (10 days ago) Apr 21
to Chromium LUCI CQ, Takashi Toyoshima, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Takashi Toyoshima
Antonio Sartori voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 8:35:14 AM (10 days ago) Apr 21
to Antonio Sartori, Judith Hemp, chromium...@chromium.org, Permissions Reviews
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/permissions, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I19e4c5c1bc60a0bf7531633c76322324581e8b35
Reviewed-by: Judith Hemp <hempj...@google.com>
Commit-Queue: Judith Hemp <hempj...@google.com>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618096}
Files:
- M chrome/browser/permissions/permission_manager_unittest.cc
- M chrome/browser/permissions/permission_subscription_unittest.cc
- M chrome/browser/permissions/permissions_security_model_interactive_uitest.cc
Change size: S
Delta: 3 files changed, 12 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Judith Hemp
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Moe Ahmadi (Gerrit)
Apr 21, 2026, 9:28:01 AM (9 days ago) Apr 21
to Antonio Sartori, chromium...@chromium.org
Attention needed from Antonio Sartori
Moe Ahmadi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Moe Ahmadi
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samar Chehade (Gerrit)
Apr 21, 2026, 9:30:46 AM (9 days ago) Apr 21
to Antonio Sartori, Chrome Signin Desktop Reviews, chromium...@chromium.org
Attention needed from Antonio Sartori and Chrome Signin Desktop Reviews
Samar Chehade added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Antonio Sartori
- Chrome Signin Desktop Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Apr 21, 2026, 9:33:34 AM (9 days ago) Apr 21
to Antonio Sartori, Chrome Signin Desktop Reviews, Monica Salama, Samar Chehade, chromium...@chromium.org
Attention needed from Antonio Sartori and Monica Salama
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
msa...@chromium.org is from context(googleclient/chrome/chromium_gwsq/components/signin/config.gwsq)
Related details
Attention is currently required from:
- Antonio Sartori
- Monica Salama
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 21, 2026, 9:41:13 AM (9 days ago) Apr 21
to chromium...@chromium.org
Antonio Sartori voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 10:22:04 AM (9 days ago) Apr 21
to Antonio Sartori, Takashi Toyoshima, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/page_load_metrics/observers, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I9b827cdcc3143c968046291a5d6d3a18b32cb9ea
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Commit-Queue: Antonio Sartori <antonio...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618156}
Files:
- M chrome/browser/page_load_metrics/observers/chrome_gws_page_load_metrics_observer.cc
- M chrome/browser/page_load_metrics/observers/new_tab_page_page_load_metrics_observer.cc
- M chrome/browser/page_load_metrics/observers/new_tab_page_page_load_metrics_observer_browsertest.cc
Change size: XS
Delta: 3 files changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Takashi Toyoshima
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Monica Salama (Gerrit)
Apr 21, 2026, 10:25:33 AM (9 days ago) Apr 21
to Antonio Sartori, Chrome Signin Desktop Reviews, Samar Chehade, chromium...@chromium.org
Attention needed from Antonio Sartori
Monica Salama voted and added 2 comments![]( "Open in Gerrit")
Votes added by Monica Salama
| Code-Review | +1 |
2 comments
Patchset-level comments
Monica Salama . resolved
Thanks!
Commit Message
Line 10, Patchset 1 (Latest):
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/signin, avoidingMonica Salama . unresolved
Long lines should be wrapped to 72 columns, format?
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 21, 2026, 11:20:17 AM (9 days ago) Apr 21
to Monica Salama, Chrome Signin Desktop Reviews, Samar Chehade, chromium...@chromium.org
Antonio Sartori voted and added 1 comment![]( "Open in Gerrit")
Votes added by Antonio Sartori
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
Commit Message
Line 10, Patchset 1:
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/signin, avoidingMonica Salama . resolved
Long lines should be wrapped to 72 columns, format?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 21, 2026, 11:20:33 AM (9 days ago) Apr 21
to Chromium LUCI CQ, chromium...@chromium.org
Antonio Sartori voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 11:35:50 AM (9 days ago) Apr 21
to Antonio Sartori, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/search, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: Id4992750a98ddb07e4f1d09d0f646b90779dd6de
Commit-Queue: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Moe Ahmadi <mah...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618217}
Files:
- M chrome/browser/search/search.cc
- M chrome/browser/search/search_unittest.cc
Change size: S
Delta: 2 files changed, 13 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Moe Ahmadi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 12:23:14 PM (9 days ago) Apr 21
to Antonio Sartori, Monica Salama, Chrome Signin Desktop Reviews, Samar Chehade, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/signin,
avoiding parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I5e97794c884b7d2bfff5455fa6555a58fa893f33
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Monica Salama <msa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618244}
Files:
- M chrome/browser/signin/dice_browsertest.cc
- M chrome/browser/signin/dice_intercepted_session_startup_helper.cc
- M chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
Change size: S
Delta: 3 files changed, 8 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Monica Salama
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emily Stark (Gerrit)
Apr 22, 2026, 12:55:35 AM (9 days ago) Apr 22
to Antonio Sartori, chromium...@chromium.org, jdeblas...@chromium.org
Attention needed from Antonio Sartori
Emily Stark voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 22, 2026, 2:03:46 AM (9 days ago) Apr 22
to Emily Stark, chromium...@chromium.org, jdeblas...@chromium.org
Antonio Sartori voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 22, 2026, 2:46:47 AM (9 days ago) Apr 22
to Antonio Sartori, Emily Stark, chromium...@chromium.org, jdeblas...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/lookalikes, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Bug: 503370195
Change-Id: I005e7ee5225fb3ef363b174347344fc4ee382d30
Commit-Queue: Antonio Sartori <antonio...@chromium.org>
Auto-Submit: Antonio Sartori <antonio...@chromium.org>
Reviewed-by: Emily Stark <est...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618680}
Files:
- M chrome/browser/lookalikes/lookalike_url_blocking_page.cc
- M chrome/browser/lookalikes/lookalike_url_controller_client.cc
- M chrome/browser/lookalikes/lookalike_url_navigation_throttle_browsertest.cc
Change size: XS
Delta: 3 files changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Emily Stark
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:47:22 AM (8 days ago) Apr 23
to Mahmoud Rashad, chromium...@chromium.org
Attention needed from Mahmoud Rashad
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Mahmoud Rashad to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/sync/test/integration, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/sync/test/integration/performance/sessions_sync_perf_test.cc
- M chrome/browser/sync/test/integration/single_client_polling_sync_test.cc
- M chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
- M chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
Change size: XS
Delta: 4 files changed, 4 insertions(+), 4 deletions(-)
Related details
Attention is currently required from:
- Mahmoud Rashad
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:48:05 AM (8 days ago) Apr 23
to Mike Wasserman, chromium...@chromium.org, dibyapal+wa...@chromium.org, csharrison+...@chromium.org, mgiuca...@chromium.org, aixba+wat...@chromium.org, mek+w...@chromium.org, philli...@chromium.org, omnibox-...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, jdonnel...@chromium.org, zelin+watch-we...@chromium.org, kuragin+web-ap...@chromium.org, webap...@microsoft.com, japhet+...@chromium.org
Attention needed from Mike Wasserman
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Mike Wasserman to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/android/browser_navigator_android_browsertest.cc
- M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
- M chrome/browser/ui/browser.cc
- M chrome/browser/ui/browser_browsertest.cc
- M chrome/browser/ui/browser_commands.cc
- M chrome/browser/ui/browser_focus_interactive_uitest.cc
- M chrome/browser/ui/browser_instant_controller.cc
- M chrome/browser/ui/browser_instant_controller_browsertest.cc
- M chrome/browser/ui/browser_navigator.cc
- M chrome/browser/ui/browser_navigator_browsertest.cc
- M chrome/browser/ui/browser_tab_strip_model_delegate_browsertest.cc
- M chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
- M chrome/browser/ui/focus_tab_after_navigation_helper.cc
- M chrome/browser/ui/omnibox/ai_mode_page_action_controller_interactive_uitest.cc
- M chrome/browser/ui/singleton_tabs.cc
- M chrome/browser/ui/tabs/tab_data_browsertest.cc
- M chrome/browser/ui/thumbnails/thumbnail_tab_helper_interactive_uitest.cc
- M chrome/browser/ui/web_applications/app_browser_controller_browsertest_chromeos.cc
Change size: M
Delta: 18 files changed, 34 insertions(+), 34 deletions(-)
Related details
Attention is currently required from:
- Mike Wasserman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:48:38 AM (8 days ago) Apr 23
to Bruno Braga, chromium...@chromium.org, siyua+aut...@chromium.org, siashah+au...@chromium.org, osaul+aut...@google.com, armalhotra+a...@google.com, shgar+aut...@google.com, vinnypersky+...@google.com
Attention needed from Bruno Braga
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Bruno Braga to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/autofill, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/autofill/autofill_field_promo_controller_impl_unittest.cc
- M chrome/browser/ui/autofill/chrome_autofill_client_unittest.cc
- M chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl_interactive_uitest.cc
Change size: XS
Delta: 3 files changed, 3 insertions(+), 3 deletions(-)
Related details
Attention is currently required from:
- Bruno Braga
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:49:11 AM (8 days ago) Apr 23
to David Pennington, chromium...@chromium.org
Attention needed from David Pennington
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like David Pennington to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/bookmarks, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
diff --git a/chrome/browser/ui/bookmarks/bookmark_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_unittest.cc
index d373a9e..ffafcbce 100644
--- a/chrome/browser/ui/bookmarks/bookmark_unittest.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_unittest.cc
@@ -49,7 +49,7 @@
bookmarks::AddIfNotBookmarked(bookmark_model, GURL("https://www.test.com"),
std::u16string());
- AddTab(browser(), GURL(chrome::kChromeUINewTabURL));
+ AddTab(browser(), chrome::ChromeUINewTabURLAsGURL());
EXPECT_EQ(BookmarkBar::SHOW,
BookmarkBarController::From(browser())->bookmark_bar_state());
}
@@ -59,7 +59,7 @@
BookmarkModelFactory::GetForBrowserContext(profile());
bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);
- AddTab(browser(), GURL(chrome::kChromeUINewTabURL));
+ AddTab(browser(), chrome::ChromeUINewTabURLAsGURL());
EXPECT_EQ(BookmarkBar::HIDDEN,
BookmarkBarController::From(browser())->bookmark_bar_state());
}
@@ -77,7 +77,7 @@
// Give it a NTP virtual URL.
content::NavigationController* controller = &web_contents->GetController();
content::NavigationEntry* entry = controller->GetVisibleEntry();
- entry->SetVirtualURL(GURL(chrome::kChromeUINewTabURL));
+ entry->SetVirtualURL(chrome::ChromeUINewTabURLAsGURL());
// Verify that the bookmark bar is hidden.
EXPECT_EQ(BookmarkBar::HIDDEN,
diff --git a/chrome/browser/ui/bookmarks/bookmark_utils.cc b/chrome/browser/ui/bookmarks/bookmark_utils.cc
index 8244288..cc32422 100644
--- a/chrome/browser/ui/bookmarks/bookmark_utils.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_utils.cc
@@ -185,7 +185,7 @@
}
// Use "New tab" as title if the current page is NTP even in incognito mode.
- if (u == GURL(chrome::kChromeUINewTabURL)) {
+ if (u == chrome::ChromeUINewTabURLAsGURL()) {
*title = l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE);
}
Change information
Files:
- M chrome/browser/ui/bookmarks/bookmark_unittest.cc
- M chrome/browser/ui/bookmarks/bookmark_utils.cc
Change size: XS
Delta: 2 files changed, 4 insertions(+), 4 deletions(-)
Related details
Attention is currently required from:
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:49:45 AM (8 days ago) Apr 23
to Masa Fujita, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Masa Fujita
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Masa Fujita to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/extensions, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/extensions/settings_api_bubble_helpers.cc
- M chrome/browser/ui/extensions/settings_overridden_dialog_browsertest.cc
- M chrome/browser/ui/extensions/settings_overridden_params_providers.cc
- M chrome/browser/ui/extensions/settings_overridden_params_providers_unittest.cc
Change size: S
Delta: 4 files changed, 5 insertions(+), 5 deletions(-)
Related details
Attention is currently required from:
- Masa Fujita
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:50:22 AM (8 days ago) Apr 23
to Martin Šrámek, chromium...@chromium.org
Attention needed from Martin Šrámek
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Martin Šrámek to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/hats, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/hats/hats_helper.cc
- M chrome/browser/ui/hats/hats_helper_unittest.cc
- M chrome/browser/ui/hats/trust_safety_sentiment_service_browsertest.cc
Change size: XS
Delta: 3 files changed, 5 insertions(+), 4 deletions(-)
Related details
Attention is currently required from:
- Martin Šrámek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:50:54 AM (8 days ago) Apr 23
to Marlon Facey, chromium...@chromium.org
Attention needed from Marlon Facey
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Marlon Facey to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/search, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/search/instant_extended_interactive_uitest.cc
- M chrome/browser/ui/search/new_tab_page_navigation_throttle.cc
- M chrome/browser/ui/search/new_tab_page_navigation_throttle_browsertest.cc
- M chrome/browser/ui/search/ntp_test_utils.cc
- M chrome/browser/ui/search/ntp_user_data_logger.cc
- M chrome/browser/ui/search/search_tab_helper.cc
Change size: S
Delta: 6 files changed, 12 insertions(+), 12 deletions(-)
Related details
Attention is currently required from:
- Marlon Facey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:51:28 AM (8 days ago) Apr 23
to Chrome Signin Desktop Reviews, chromium...@chromium.org
Attention needed from Chrome Signin Desktop Reviews
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Chrome Signin Desktop Reviews to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/signin, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/signin/signin_view_controller.cc
- M chrome/browser/ui/signin/signin_view_controller.h
Change size: S
Delta: 2 files changed, 5 insertions(+), 5 deletions(-)
Related details
Attention is currently required from:
- Chrome Signin Desktop Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:51:58 AM (8 days ago) Apr 23
to Nicolas Ouellet-Payeur, chromium...@chromium.org, ydago...@chromium.org, nicolas...@chromium.org
Attention needed from Nicolas Ouellet-Payeur
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Nicolas Ouellet-Payeur to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/startup, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/startup/default_browser_prompt/default_browser_prompt_interactive_uitest.cc
- M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
- M chrome/browser/ui/startup/startup_browser_creator_impl.cc
- M chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc
- M chrome/browser/ui/startup/startup_tab_provider.cc
- M chrome/browser/ui/startup/startup_tab_provider_unittest.cc
Change size: S
Delta: 6 files changed, 15 insertions(+), 16 deletions(-)
Related details
Attention is currently required from:
- Nicolas Ouellet-Payeur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
Apr 23, 2026, 7:52:10 AM (8 days ago) Apr 23
to Antonio Sartori, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Antonio Sartori
Masa Fujita voted and added 1 comment![]( "Open in Gerrit")
Votes added by Masa Fujita
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:52:28 AM (8 days ago) Apr 23
to Shakti Sahu, chromium...@chromium.org
Attention needed from Shakti Sahu
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Shakti Sahu to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/tabs/saved_tab_groups, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/tabs/saved_tab_groups/local_tab_group_listener.cc
- M chrome/browser/ui/tabs/saved_tab_groups/saved_tab_group_utils.cc
- M chrome/browser/ui/tabs/saved_tab_groups/tab_group_sync_delegate_browsertest.cc
- M chrome/browser/ui/tabs/saved_tab_groups/tab_group_sync_navigation_browser_test.cc
Change size: S
Delta: 4 files changed, 6 insertions(+), 6 deletions(-)
Related details
Attention is currently required from:
- Shakti Sahu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:52:59 AM (8 days ago) Apr 23
to Dana Fried, chromium...@chromium.org
Attention needed from Dana Fried
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Dana Fried to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/toolbar, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/toolbar/chrome_location_bar_model_delegate.cc
- M chrome/browser/ui/toolbar/chrome_location_bar_model_delegate_browsertest.cc
- M chrome/browser/ui/toolbar/location_bar_model_browsertest.cc
Change size: XS
Delta: 3 files changed, 4 insertions(+), 4 deletions(-)
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 23, 2026, 7:53:34 AM (8 days ago) Apr 23
to Emily Shack, chromium...@chromium.org, omnibox-...@chromium.org, jdonnel...@chromium.org
Attention needed from Emily Shack
Antonio Sartori has uploaded the change for review![]( "Open in Gerrit")
Antonio Sartori would like Emily Shack to review this change.
Commit message
Avoid continuously reparsing NTP url
This CL is a refactoring which switches to using the GURL version of
ChromeUINewTabURL and/or ChromeUINewPageURL in chrome/browser/ui/views, avoiding
parsing GURL again and again.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
- M chrome/browser/ui/views/tab_sharing/tab_sharing_ui_views_browsertest.cc
- M chrome/browser/ui/views/toolbar/webui_toolbar_web_view_browsertest.cc
Change size: S
Delta: 3 files changed, 6 insertions(+), 6 deletions(-)
Related details
Attention is currently required from:
- Emily Shack
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Apr 23, 2026, 7:53:43 AM (8 days ago) Apr 23
to Antonio Sartori, Chrome Signin Desktop Reviews, Amelie Schneider, chromium...@chromium.org
Attention needed from Amelie Schneider
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
ame...@google.com is from context(googleclient/chrome/chromium_gwsq/components/signin/config.gwsq)
Related details
Attention is currently required from:
- Amelie Schneider
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
It is loading more messages.
0 new messages