[contextual_tasks] Cleanup ActiveTaskContextProvider interface [chromium/src : main]

0 views
Skip to first unread message

Shakti Sahu (Gerrit)

unread,
Jan 16, 2026, 11:41:08 PM (15 hours ago) Jan 16
to Min Qin, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Min Qin

Shakti Sahu voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Min Qin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ida2a656f8b07780020af64a95a347a8b1b7b4274
Gerrit-Change-Number: 7487542
Gerrit-PatchSet: 2
Gerrit-Owner: Shakti Sahu <shakt...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Min Qin <qin...@chromium.org>
Gerrit-Comment-Date: Sat, 17 Jan 2026 04:40:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Min Qin (Gerrit)

unread,
12:21 AM (14 hours ago) 12:21 AM
to Shakti Sahu, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Shakti Sahu

Min Qin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shakti Sahu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ida2a656f8b07780020af64a95a347a8b1b7b4274
    Gerrit-Change-Number: 7487542
    Gerrit-PatchSet: 2
    Gerrit-Owner: Shakti Sahu <shakt...@chromium.org>
    Gerrit-Reviewer: Min Qin <qin...@chromium.org>
    Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Shakti Sahu <shakt...@chromium.org>
    Gerrit-Comment-Date: Sat, 17 Jan 2026 05:21:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Shakti Sahu (Gerrit)

    unread,
    11:53 AM (3 hours ago) 11:53 AM
    to Min Qin, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang

    Shakti Sahu voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ida2a656f8b07780020af64a95a347a8b1b7b4274
    Gerrit-Change-Number: 7487542
    Gerrit-PatchSet: 2
    Gerrit-Owner: Shakti Sahu <shakt...@chromium.org>
    Gerrit-Reviewer: Min Qin <qin...@chromium.org>
    Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Comment-Date: Sat, 17 Jan 2026 16:53:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    11:56 AM (3 hours ago) 11:56 AM
    to Shakti Sahu, Min Qin, chromium...@chromium.org, Sophie Chang

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [contextual_tasks] Cleanup ActiveTaskContextProvider interface

    This is a pure refactor CL without functional changes.
    Public methods of ActiveTaskContextProvider (
    OnSidePanelStateUpdated and OnFullTabStateUpdated) were replaced
    by RefreshContext. All callsites were updated.
    Bug: b:476523954
    Change-Id: Ida2a656f8b07780020af64a95a347a8b1b7b4274
    Reviewed-by: Min Qin <qin...@chromium.org>
    Commit-Queue: Shakti Sahu <shakt...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1570799}
    Files:
    • M chrome/browser/contextual_tasks/active_task_context_provider.h
    • M chrome/browser/contextual_tasks/active_task_context_provider_impl.cc
    • M chrome/browser/contextual_tasks/active_task_context_provider_impl.h
    • M chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator.cc
    • M chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator_unittest.cc
    • M chrome/browser/contextual_tasks/contextual_tasks_ui.cc
    • M chrome/browser/contextual_tasks/contextual_tasks_ui_service.cc
    Change size: S
    Delta: 7 files changed, 13 insertions(+), 35 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Min Qin
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ida2a656f8b07780020af64a95a347a8b1b7b4274
    Gerrit-Change-Number: 7487542
    Gerrit-PatchSet: 3
    Gerrit-Owner: Shakti Sahu <shakt...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Min Qin <qin...@chromium.org>
    Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages