[contextual_tasks] Cleanup ActiveTaskContextProvider interface [chromium/src : main]
0 views
Skip to first unread message
Shakti Sahu (Gerrit)
Jan 16, 2026, 11:41:08 PM (15 hours ago) Jan 16
to Min Qin, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Min Qin
Shakti Sahu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Min Qin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Min Qin (Gerrit)
12:21 AM (14 hours ago) 12:21 AM
to Shakti Sahu, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Shakti Sahu
Min Qin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Shakti Sahu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shakti Sahu (Gerrit)
11:53 AM (3 hours ago) 11:53 AM
to Min Qin, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Shakti Sahu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:56 AM (3 hours ago) 11:56 AM
to Shakti Sahu, Min Qin, chromium...@chromium.org, Sophie Chang
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[contextual_tasks] Cleanup ActiveTaskContextProvider interface
This is a pure refactor CL without functional changes.
Public methods of ActiveTaskContextProvider (
OnSidePanelStateUpdated and OnFullTabStateUpdated) were replaced
by RefreshContext. All callsites were updated.
Bug: b:476523954
Change-Id: Ida2a656f8b07780020af64a95a347a8b1b7b4274
Reviewed-by: Min Qin <qin...@chromium.org>
Commit-Queue: Shakti Sahu <shakt...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1570799}
Files:
- M chrome/browser/contextual_tasks/active_task_context_provider.h
- M chrome/browser/contextual_tasks/active_task_context_provider_impl.cc
- M chrome/browser/contextual_tasks/active_task_context_provider_impl.h
- M chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator.cc
- M chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator_unittest.cc
- M chrome/browser/contextual_tasks/contextual_tasks_ui.cc
- M chrome/browser/contextual_tasks/contextual_tasks_ui_service.cc
Change size: S
Delta: 7 files changed, 13 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Min Qin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages