LPP: Remove dependency on PrefService when removing a PIN [chromium/src : main]
0 views
Skip to first unread message
Fahad Mansoor (Gerrit)
9:28 AM (10 hours ago) 9:28 AM
to Denis Kuznetsov, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Denis Kuznetsov
Fahad Mansoor voted and added 1 comment![]( "Open in Gerrit")
Votes added by Fahad Mansoor
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Denis Kuznetsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fahad Mansoor (Gerrit)
10:10 AM (9 hours ago) 10:10 AM
to Denis Kuznetsov, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Denis Kuznetsov
Fahad Mansoor voted![]( "Open in Gerrit")
| Code-Review | +0 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Denis Kuznetsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Denis Kuznetsov (Gerrit)
12:42 PM (7 hours ago) 12:42 PM
to Fahad Mansoor, Chromium LUCI CQ, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Fahad Mansoor
Denis Kuznetsov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Denis Kuznetsov
| Code-Review | +1 |
1 comment
Commit Message
Line 13, Patchset 1 (Latest):
Bug: 445641708Denis Kuznetsov . unresolved
by the way, it would be nice to have something else in the bug description besides the title.
Related details
Attention is currently required from:
- Fahad Mansoor
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fahad Mansoor (Gerrit)
1:07 PM (6 hours ago) 1:07 PM
to Denis Kuznetsov, Chromium LUCI CQ, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Fahad Mansoor added 1 comment![]( "Open in Gerrit")
Commit Message
Line 13, Patchset 1 (Latest):
Bug: 445641708Denis Kuznetsov . resolved
by the way, it would be nice to have something else in the bug description besides the title.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:10 PM (6 hours ago) 1:10 PM
to Fahad Mansoor, Denis Kuznetsov, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
LPP: Remove dependency on PrefService when removing a PIN
PIN can be removed during reauth before the profile is fully
loaded, so add checks such that we do not access the pref_service
before the profile is fully loaded. No behavioral change.
Bug: 445641708
Change-Id: I05e3f624f0d951a06a6c0752b7d95b4aa796bd10
Reviewed-by: Denis Kuznetsov <ant...@chromium.org>
Commit-Queue: Fahad Mansoor <fahadm...@google.com>
Cr-Commit-Position: refs/heads/main@{#1603563}
Files:
- M chrome/browser/ash/login/quick_unlock/pin_backend.cc
Change size: S
Delta: 1 file changed, 13 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Denis Kuznetsov, +0 by Fahad Mansoor
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages