[iOS] iOS 16 deprecation code cleanup [chromium/src : main]
0 views
Skip to first unread message
Daniel White (Gerrit)
Dec 15, 2025, 1:24:47 PM (22 hours ago) Dec 15
to Benjamin Williams, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Benjamin Williams
Daniel White has uploaded the change for review![]( "Open in Gerrit")
Daniel White would like Benjamin Williams to review this change.
Commit message
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
R=bwwil...@google.com
Bug: 403260493
Change-Id: Iaf668a471d6f0f7b7a82164f6d023f2cf7f4c4ae
Change diff
diff --git a/ios/chrome/browser/content_suggestions/ui_bundled/cells/content_suggestions_tile_view.mm b/ios/chrome/browser/content_suggestions/ui_bundled/cells/content_suggestions_tile_view.mm
index f82101a..4f2036f 100644
--- a/ios/chrome/browser/content_suggestions/ui_bundled/cells/content_suggestions_tile_view.mm
+++ b/ios/chrome/browser/content_suggestions/ui_bundled/cells/content_suggestions_tile_view.mm
@@ -49,10 +49,8 @@
_imageContainerView = [[UIView alloc] init];
_imageContainerView.translatesAutoresizingMaskIntoConstraints = NO;
if (ios::provider::IsRaccoonEnabled()) {
- if (@available(iOS 17.0, *)) {
_imageContainerView.hoverStyle = [UIHoverStyle
styleWithShape:[UIShape rectShapeWithCornerRadius:kCornerRadius]];
- }
}
// Use original rounded-square background image for Shorcuts
Change information
Files:
- M ios/chrome/browser/content_suggestions/ui_bundled/cells/content_suggestions_tile_view.mm
Change size: XS
Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Benjamin Williams
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
Dec 15, 2025, 1:25:09 PM (22 hours ago) Dec 15
to Quentin Pubert, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Quentin Pubert
Daniel White has uploaded the change for review![]( "Open in Gerrit")
Daniel White would like Quentin Pubert to review this change.
Commit message
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/find_in_page/model/find_in_page_egtest.mm b/ios/chrome/browser/find_in_page/model/find_in_page_egtest.mm
index 16702aa..39f3fb3e 100644
--- a/ios/chrome/browser/find_in_page/model/find_in_page_egtest.mm
+++ b/ios/chrome/browser/find_in_page/model/find_in_page_egtest.mm
@@ -796,11 +796,9 @@
// after switching temporarily to another tab.
// TODO(crbug.com/40940589): Re-enable this test.
- (void)FLAKY_testFindInPageSwitchingTabs {
- // TODO(crbug.com/40922941): Failing on iOS17 iPhone.
- if (@available(iOS 17.0, *)) {
- if (![ChromeEarlGrey isIPadIdiom]) {
- XCTSkip(@"Failing on iOS17 iPhone");
- }
+ // TODO(crbug.com/40922941): Failing on iPhone.
+ if (![ChromeEarlGrey isIPadIdiom]) {
+ XCTSkip(@"Failing on iOS17 iPhone");
}
[self setUpTestServersForWebPageTest];
Change information
Files:
- M ios/chrome/browser/find_in_page/model/find_in_page_egtest.mm
Change size: XS
Delta: 1 file changed, 3 insertions(+), 5 deletions(-)
Related details
Attention is currently required from:
- Quentin Pubert
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
Dec 15, 2025, 1:25:32 PM (22 hours ago) Dec 15
to Vidhan Jain, chromium...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Vidhan Jain
Daniel White has uploaded the change for review![]( "Open in Gerrit")
Daniel White would like Vidhan Jain to review this change.
Commit message
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_address_manually_egtest.mm b/ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_address_manually_egtest.mm
index a97535c9..c139a5f9 100644
--- a/ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_address_manually_egtest.mm
+++ b/ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_address_manually_egtest.mm
@@ -414,26 +414,24 @@
EARL_GREY_TEST_SKIPPED(@"Test is not applicable for iPhone.");
}
- if (@available(iOS 17.0, *)) {
- [self openAddAddressView:YES];
+ [self openAddAddressView:YES];
- // Change trait collection to use extra large content size so that the
- // 'Save' button becomes hidden.
- ScopedTraitOverrider overrider(TopPresentedViewController());
- overrider.SetContentSizeCategory(UIContentSizeCategoryExtraLarge);
- [ChromeEarlGreyUI waitForAppToIdle];
+ // Change trait collection to use extra large content size so that the
+ // 'Save' button becomes hidden.
+ ScopedTraitOverrider overrider(TopPresentedViewController());
+ overrider.SetContentSizeCategory(UIContentSizeCategoryExtraLarge);
+ [ChromeEarlGreyUI waitForAppToIdle];
- // Fill the required fields.
- [self fillRequiredFields];
+ // Fill the required fields.
+ [self fillRequiredFields];
- // Scroll down to show the 'Save' button.
- [[EarlGrey selectElementWithMatcher:EditProfileBottomSheet()]
- performAction:grey_scrollToContentEdge(kGREYContentEdgeBottom)];
+ // Scroll down to show the 'Save' button.
+ [[EarlGrey selectElementWithMatcher:EditProfileBottomSheet()]
+ performAction:grey_scrollToContentEdge(kGREYContentEdgeBottom)];
- // Ensure the 'Save' button's status changed to enabled.
- [[EarlGrey selectElementWithMatcher:SaveAddressButton()]
- assertWithMatcher:grey_enabled()];
- }
+ // Ensure the 'Save' button's status changed to enabled.
+ [[EarlGrey selectElementWithMatcher:SaveAddressButton()]
+ assertWithMatcher:grey_enabled()];
}
@end
Change information
Files:
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_address_manually_egtest.mm
Change size: S
Delta: 1 file changed, 14 insertions(+), 16 deletions(-)
Related details
Attention is currently required from:
- Vidhan Jain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
Dec 15, 2025, 1:25:54 PM (22 hours ago) Dec 15
to Gauthier Ambard, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Daniel White has uploaded the change for review![]( "Open in Gerrit")
Daniel White would like Gauthier Ambard to review this change.
Commit message
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/shared/coordinator/utils/credential_provider_settings_utils.mm b/ios/chrome/browser/shared/coordinator/utils/credential_provider_settings_utils.mm
index de61e0f6..d476178 100644
--- a/ios/chrome/browser/shared/coordinator/utils/credential_provider_settings_utils.mm
+++ b/ios/chrome/browser/shared/coordinator/utils/credential_provider_settings_utils.mm
@@ -36,16 +36,12 @@
void OpenIOSCredentialProviderSettings() {
// If available, use the API that allows to directly open the iOS credential
// provider settings.
- if (@available(iOS 17.0, *)) {
- [ASSettingsHelper openCredentialProviderAppSettingsWithCompletionHandler:^(
- NSError* error) {
- if (error) {
- ios::provider::PasswordsInOtherAppsOpensSettings();
- }
- }];
- } else {
- ios::provider::PasswordsInOtherAppsOpensSettings();
- }
+ [ASSettingsHelper
+ openCredentialProviderAppSettingsWithCompletionHandler:^(NSError* error) {
+ if (error) {
+ ios::provider::PasswordsInOtherAppsOpensSettings();
+ }
+ }];
}
void RecordTurnOnCredentialProviderExtensionPromptOutcome(
Change information
Files:
- M ios/chrome/browser/shared/coordinator/utils/credential_provider_settings_utils.mm
Change size: S
Delta: 1 file changed, 6 insertions(+), 10 deletions(-)
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Williams (Gerrit)
Dec 15, 2025, 1:26:02 PM (22 hours ago) Dec 15
to Daniel White, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Daniel White
Benjamin Williams voted![]( "Open in Gerrit")
Attention is currently required from:
- Daniel White
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
Dec 15, 2025, 1:26:18 PM (22 hours ago) Dec 15
to Sergio Collazos, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, knollr+wat...@chromium.org, marq+...@chromium.org
Attention needed from Sergio Collazos
Daniel White has uploaded the change for review![]( "Open in Gerrit")
Daniel White would like Sergio Collazos to review this change.
Commit message
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activity_service_controller_egtest.mm
Change size: M
Delta: 1 file changed, 65 insertions(+), 69 deletions(-)
Related details
Attention is currently required from:
- Sergio Collazos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
Dec 15, 2025, 1:26:40 PM (22 hours ago) Dec 15
to Ewann Pellé, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Ewann Pellé
Daniel White has uploaded the change for review![]( "Open in Gerrit")
Daniel White would like Ewann Pellé to review this change.
Commit message
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/tab_switcher/tab_strip/ui/tab_strip_new_tab_button.swift b/ios/chrome/browser/tab_switcher/tab_strip/ui/tab_strip_new_tab_button.swift
index 409fb72..5b9ed29 100644
--- a/ios/chrome/browser/tab_switcher/tab_strip/ui/tab_strip_new_tab_button.swift
+++ b/ios/chrome/browser/tab_switcher/tab_strip/ui/tab_strip_new_tab_button.swift
@@ -73,9 +73,7 @@
button.translatesAutoresizingMaskIntoConstraints = false
button.addTarget(self, action: #selector(buttonTapped), for: .touchUpInside)
button.isPointerInteractionEnabled = true
- if #available(iOS 17.0, *) {
- button.hoverStyle = .init(effect: .lift, shape: .circle)
- }
+ button.hoverStyle = .init(effect: .lift, shape: .circle)
}
/// Updates the `accessibilityLabel` according to the current state of
Change information
Files:
- M ios/chrome/browser/tab_switcher/tab_strip/ui/tab_strip_new_tab_button.swift
Change size: XS
Delta: 1 file changed, 1 insertion(+), 3 deletions(-)
Related details
Attention is currently required from:
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
Dec 15, 2025, 1:27:01 PM (22 hours ago) Dec 15
to Christian Xu, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Christian Xu
Daniel White has uploaded the change for review![]( "Open in Gerrit")
Daniel White would like Christian Xu to review this change.
Commit message
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/toolbar/ui_bundled/buttons/toolbar_button_factory.mm b/ios/chrome/browser/toolbar/ui_bundled/buttons/toolbar_button_factory.mm
index 01b3397..08b27b80 100644
--- a/ios/chrome/browser/toolbar/ui_bundled/buttons/toolbar_button_factory.mm
+++ b/ios/chrome/browser/toolbar/ui_bundled/buttons/toolbar_button_factory.mm
@@ -437,10 +437,8 @@
button.exclusiveTouch = YES;
button.pointerInteractionEnabled = YES;
if (ios::provider::IsRaccoonEnabled()) {
- if (@available(iOS 17.0, *)) {
- button.hoverStyle = [UIHoverStyle
- styleWithShape:[UIShape rectShapeWithCornerRadius:width / 4]];
- }
+ button.hoverStyle = [UIHoverStyle
+ styleWithShape:[UIShape rectShapeWithCornerRadius:width / 4]];
}
button.pointerStyleProvider =
^UIPointerStyle*(UIButton* uiButton, UIPointerEffect* proposedEffect,
Change information
Files:
- M ios/chrome/browser/toolbar/ui_bundled/buttons/toolbar_button_factory.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 4 deletions(-)
Related details
Attention is currently required from:
- Christian Xu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
Dec 15, 2025, 1:27:25 PM (22 hours ago) Dec 15
to Zhaoyang Li, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Zhaoyang Li
Daniel White has uploaded the change for review![]( "Open in Gerrit")
Daniel White would like Zhaoyang Li to review this change.
Commit message
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/test/scoped_eg_traits_overrider.mm b/ios/chrome/test/scoped_eg_traits_overrider.mm
index c56c718..429489cf 100644
--- a/ios/chrome/test/scoped_eg_traits_overrider.mm
+++ b/ios/chrome/test/scoped_eg_traits_overrider.mm
@@ -20,19 +20,15 @@
// For other trait overrides, don't forget to remove it here. The
// `traitOverrides` is read only.
if (top_view_controller_) {
- if (@available(iOS 17.0, *)) {
top_view_controller_.traitOverrides.preferredContentSizeCategory =
original_content_size_category_;
- }
}
}
void ScopedTraitOverrider::SetContentSizeCategory(
UIContentSizeCategory new_content_size_category) {
if (top_view_controller_) {
- if (@available(iOS 17.0, *)) {
top_view_controller_.traitOverrides.preferredContentSizeCategory =
new_content_size_category;
- }
}
}
Change information
Files:
- M ios/chrome/test/scoped_eg_traits_overrider.mm
Change size: XS
Delta: 1 file changed, 0 insertions(+), 4 deletions(-)
Related details
Attention is currently required from:
- Zhaoyang Li
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
Dec 15, 2025, 1:27:50 PM (22 hours ago) Dec 15
to Robbie Gibson, chromium...@chromium.org, rkgibso...@chromium.org, chromium-a...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, extension...@chromium.org
Attention needed from Robbie Gibson
Daniel White has uploaded the change for review![]( "Open in Gerrit")
Daniel White would like Robbie Gibson to review this change.
Commit message
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/widget_kit_extension/main.swift b/ios/chrome/widget_kit_extension/main.swift
index f0f3264..9c0726e 100644
--- a/ios/chrome/widget_kit_extension/main.swift
+++ b/ios/chrome/widget_kit_extension/main.swift
@@ -12,11 +12,7 @@
static func main() {
CrashHelper.configure()
- if #available(iOS 17.0, *) {
- return ChromeWidgetsForMIM.main()
- } else {
- return ChromeWidgets.main()
- }
+ return ChromeWidgetsForMIM.main()
}
}
Change information
Files:
- M ios/chrome/widget_kit_extension/main.swift
Change size: XS
Delta: 1 file changed, 1 insertion(+), 5 deletions(-)
Related details
Attention is currently required from:
- Robbie Gibson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robbie Gibson (Gerrit)
Dec 15, 2025, 1:33:05 PM (22 hours ago) Dec 15
to Daniel White, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org
Attention needed from Daniel White
Robbie Gibson voted![]( "Open in Gerrit")
Attention is currently required from:
- Daniel White
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 15, 2025, 1:40:32 PM (22 hours ago) Dec 15
to Daniel White, Robbie Gibson, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
R=rkgi...@google.com
Bug: 403260493
Change-Id: Ieea8dcafc3e707ddfa6309e5e1e2e0c8f1f38c85
Commit-Queue: Robbie Gibson <rkgi...@google.com>
Auto-Submit: Daniel White <daniel...@google.com>
Reviewed-by: Robbie Gibson <rkgi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1558838}
Files:
- M ios/chrome/widget_kit_extension/main.swift
Change size: XS
Delta: 1 file changed, 1 insertion(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Robbie Gibson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vidhan Jain (Gerrit)
Dec 15, 2025, 1:47:33 PM (22 hours ago) Dec 15
to Daniel White, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Daniel White
Vidhan Jain voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel White
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 15, 2025, 2:28:53 PM (21 hours ago) Dec 15
to Daniel White, Benjamin Williams, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Bug: 403260493
Change-Id: Iaf668a471d6f0f7b7a82164f6d023f2cf7f4c4ae
Auto-Submit: Daniel White <daniel...@google.com>
Commit-Queue: Benjamin Williams <bwwil...@google.com>
Reviewed-by: Benjamin Williams <bwwil...@google.com>
Cr-Commit-Position: refs/heads/main@{#1558874}
Files:
- M ios/chrome/browser/content_suggestions/ui_bundled/cells/content_suggestions_tile_view.mm
Change size: XS
Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Benjamin Williams
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 15, 2025, 2:46:38 PM (21 hours ago) Dec 15
to Daniel White, Vidhan Jain, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Bug: 403260493
Change-Id: Ib73a25e9a962513ad31e4772695e88138ce6ec75
Reviewed-by: Vidhan Jain <vid...@google.com>
Auto-Submit: Daniel White <daniel...@google.com>
Commit-Queue: Vidhan Jain <vid...@google.com>
Cr-Commit-Position: refs/heads/main@{#1558892}
Files:
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_address_manually_egtest.mm
Change size: S
Delta: 1 file changed, 14 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vidhan Jain
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yue She (Gerrit)
Dec 15, 2025, 5:54:14 PM (17 hours ago) Dec 15
to Daniel White, Zhaoyang Li, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Daniel White
Yue She voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel White
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
3:52 AM (7 hours ago) 3:52 AM
to Daniel White, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Daniel White
Ewann Pellé voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ewann Pellé
| Code-Review | +1 |
[iOS] iOS 16 deprecation code cleanupEwann Pellé . unresolved
tiny nit: this CL cleans an iOS 17 check.
Related details
Attention is currently required from:
- Daniel White
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Quentin Pubert (Gerrit)
4:29 AM (7 hours ago) 4:29 AM
to Daniel White, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Daniel White
Quentin Pubert voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel White
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:08 AM (6 hours ago) 5:08 AM
to Daniel White, Quentin Pubert, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Bug: 403260493
Change-Id: If3682361819d826679794c17ca810f8e487ae951
Auto-Submit: Daniel White <daniel...@google.com>
Commit-Queue: Quentin Pubert <qpu...@google.com>
Reviewed-by: Quentin Pubert <qpu...@google.com>
Cr-Commit-Position: refs/heads/main@{#1559208}
Files:
- M ios/chrome/browser/find_in_page/model/find_in_page_egtest.mm
Change size: XS
Delta: 1 file changed, 3 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Quentin Pubert
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
5:10 AM (6 hours ago) 5:10 AM
to Daniel White, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Daniel White
Gauthier Ambard voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel White
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:02 AM (5 hours ago) 6:02 AM
to Daniel White, Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] iOS 16 deprecation code cleanup
Each year the Chrome for iOS team increases the application's minimum
supported iOS version. During the process, run/compile-time flags are
added throughout the codebase to transitions areas of the code using
deprecated APIs to the newer variants. Once the minimum supported
version is bumped, these guards are no longer needed.
This CL is part of a large-scale effort to remove the remaining obsolete
guards from the application's codebase.
This CL was uploaded by git cl split.
Bug: 403260493
Change-Id: I247476fd7217247326d495ef355bbb17cbca01bd
Auto-Submit: Daniel White <daniel...@google.com>
Reviewed-by: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Gauthier Ambard <gam...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1559232}
Files:
- M ios/chrome/browser/shared/coordinator/utils/credential_provider_settings_utils.mm
Change size: S
Delta: 1 file changed, 6 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gauthier Ambard
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Xu (Gerrit)
8:36 AM (3 hours ago) 8:36 AM
to Daniel White, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Daniel White
Christian Xu voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Daniel White
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
11:05 AM (13 minutes ago) 11:05 AM
to Christian Xu, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Daniel White voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages