Workaround of an ubidi_getLogicalRun() issue [chromium/src : main]

[Kent Tamura (Gerrit)]

Attention needed from Kent Tamura and Nico Weber

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Kent Tamura . resolved

Nico, would you review this please?

The internal structure is `Run` here: https://source.chromium.org/chromium/chromium/src/+/main:third_party/icu/source/common/ubidiimp.h;l=199

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Nico Weber

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ica350078f0f3809012e957afb37c5985d9765d5c

Gerrit-Change-Number: 7781344

Gerrit-PatchSet: 3

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Nico Weber <tha...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Nico Weber <tha...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Tue, 21 Apr 2026 01:30:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes