Add user agent override API to WebState [chromium/src : main]
0 views
Skip to first unread message
Louis Romero (Gerrit)
Mar 20, 2026, 8:04:18 PM (3 days ago) Mar 20
to Louis Romero, Sylvain Defresne, Mike Dougherty, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Mike Dougherty and Sylvain Defresne
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Mike Dougherty
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
7:03 AM (6 hours ago) 7:03 AM
to Louis Romero, Mike Dougherty, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Louis Romero and Mike Dougherty
Sylvain Defresne added 1 comment![]( "Open in Gerrit")
File ios/web/web_state/web_state_impl.mm
Line 74, Patchset 6 (Latest):
const std::string kEmptyString = "";Sylvain Defresne . unresolved
`std::string` has a non default destructor, so this adds a global destructor, which will fail on a bot later.
Instead either:
- declare the constant at the function scope
```
const std::string& WebStateImpl::GetUserAgentOverride() const {
...
static constexpr std::string kEmptyString;
return *kEmptyString;
}
```
- change the API to return `std::string`.
Related details
Attention is currently required from:
- Louis Romero
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
7:10 AM (6 hours ago) 7:10 AM
to Louis Romero, Mike Dougherty, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Louis Romero and Mike Dougherty
Sylvain Defresne added 1 comment![]( "Open in Gerrit")
File ios/web/web_state/web_state_impl.mm
Line 74, Patchset 6 (Latest):
const std::string kEmptyString = "";Sylvain Defresne . unresolved
`std::string` has a non default destructor, so this adds a global destructor, which will fail on a bot later.
Instead either:
- declare the constant at the function scope
```
const std::string& WebStateImpl::GetUserAgentOverride() const {
...
static constexpr std::string kEmptyString;
return *kEmptyString;
}
```
- change the API to return `std::string`.
Sylvain Defresne
The `*` was not supposed to be here (typo).
Sylvain Defresne (Gerrit)
9:30 AM (4 hours ago) 9:30 AM
to Louis Romero, Mike Dougherty, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Louis Romero and Mike Dougherty
Sylvain Defresne voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Louis Romero
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Louis Romero (Gerrit)
10:11 AM (3 hours ago) 10:11 AM
to Louis Romero, Sylvain Defresne, Mike Dougherty, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Mike Dougherty
Louis Romero added 1 comment![]( "Open in Gerrit")
File ios/web/web_state/web_state_impl.mm
Sylvain Defresne`std::string` has a non default destructor, so this adds a global destructor, which will fail on a bot later.
Instead either:
- declare the constant at the function scope
```
const std::string& WebStateImpl::GetUserAgentOverride() const {
...
static constexpr std::string kEmptyString;
return *kEmptyString;
}
```
- change the API to return `std::string`.
The `*` was not supposed to be here (typo).
Attention is currently required from:
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Dougherty (Gerrit)
1:11 PM (3 minutes ago) 1:11 PM
to Louis Romero, Sylvain Defresne, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Louis Romero
Mike Dougherty added 1 comment![]( "Open in Gerrit")
File ios/web/public/web_state.h
Line 346, Patchset 7 (Latest):
// Returns the user agent override, or an empty string if none is set.Mike Dougherty . unresolved
I think it would be better to use an std::optional<std::string> here instead of relying on an empty string. Would that work?
Related details
Attention is currently required from:
- Louis Romero
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages