Add documentation and example for problem with circular dependencies [chromium/src : main]

1 view

Skip to first unread message

Scott Violet (Gerrit)

unread,

Jul 17, 2024, 11:10:42 AM7/17/24

to Erik Chen, Scott Violet, chromium...@chromium.org

Attention needed from Erik Chen

Scott Violet voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

Jul 17, 2024, 5:36:21 PM7/17/24

to Scott Violet, chromium...@chromium.org

Erik Chen voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 17, 2024, 5:39:30 PM7/17/24

to Erik Chen, Scott Violet, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Add documentation and example for problem with circular dependencies

Change-Id: I2dc9e9425a4f02f44fa7b0adf33579cbe43140ad

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5716350

Reviewed-by: Scott Violet <s...@chromium.org>

Commit-Queue: Erik Chen <erik...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1329144}

Files:

M docs/chrome_browser_design_principles.md

Change size: M

Delta: 1 file changed, 97 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Scott Violet

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages