Add documentation and example for problem with circular dependencies [chromium/src : main]

1 view
Skip to first unread message

Scott Violet (Gerrit)

unread,
Jul 17, 2024, 11:10:42 AM7/17/24
to Erik Chen, Scott Violet, chromium...@chromium.org
Attention needed from Erik Chen

Scott Violet voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2dc9e9425a4f02f44fa7b0adf33579cbe43140ad
Gerrit-Change-Number: 5716350
Gerrit-PatchSet: 4
Gerrit-Owner: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Attention: Erik Chen <erik...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Jul 2024 15:10:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Erik Chen (Gerrit)

unread,
Jul 17, 2024, 5:36:21 PM7/17/24
to Scott Violet, chromium...@chromium.org

Erik Chen voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2dc9e9425a4f02f44fa7b0adf33579cbe43140ad
Gerrit-Change-Number: 5716350
Gerrit-PatchSet: 4
Gerrit-Owner: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Jul 2024 21:36:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 17, 2024, 5:39:30 PM7/17/24
to Erik Chen, Scott Violet, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add documentation and example for problem with circular dependencies
Change-Id: I2dc9e9425a4f02f44fa7b0adf33579cbe43140ad
Reviewed-by: Scott Violet <s...@chromium.org>
Commit-Queue: Erik Chen <erik...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1329144}
Files:
  • M docs/chrome_browser_design_principles.md
Change size: M
Delta: 1 file changed, 97 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Scott Violet
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2dc9e9425a4f02f44fa7b0adf33579cbe43140ad
Gerrit-Change-Number: 5716350
Gerrit-PatchSet: 5
Gerrit-Owner: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages