Create chrome/browser/ui/views/tabs/glic directory [chromium/src : main]
0 views
Skip to first unread message
Ian Wells (Gerrit)
5:32 PM (6 hours ago) 5:32 PM
to Darryl James, Maggie Jennings, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org, dfried...@chromium.org, estali...@chromium.org
Attention needed from Darryl James and Maggie Jennings
Ian Wells added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Darryl James
- Maggie Jennings
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
5:42 PM (6 hours ago) 5:42 PM
to Ian Wells, Maggie Jennings, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org, dfried...@chromium.org, estali...@chromium.org
Attention needed from Ian Wells and Maggie Jennings
Darryl James voted and added 2 comments![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
2 comments
Patchset-level comments
Darryl James . resolved
lgtm % fixing merge conflict; Thanks!
File chrome/browser/ui/views/tabs/glic/BUILD.gn
Line 4, Patchset 4 (Latest):
Darryl James . unresolved
optional: Consider adding `assert(enable_glic || enable_glic_android)` this way non-glic enabled platforms won't accidentally build / use files from these targets 👍
Marking as optional since this lives in the higher level c/b/glic/BUILD.gn which already asserts this. Mainly want to be on the safe side if someone pulls files specifically from this target for whatever reason
Related details
Attention is currently required from:
- Ian Wells
- Maggie Jennings
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Wells (Gerrit)
6:27 PM (5 hours ago) 6:27 PM
to Darryl James, Maggie Jennings, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org, dfried...@chromium.org, estali...@chromium.org
Attention needed from Maggie Jennings
Ian Wells voted and added 2 comments![]( "Open in Gerrit")
Votes added by Ian Wells
| Commit-Queue | +2 |
Darryl James . resolved
lgtm % fixing merge conflict; Thanks!
Ian Wells
Thanks!
File chrome/browser/ui/views/tabs/glic/BUILD.gn
optional: Consider adding `assert(enable_glic || enable_glic_android)` this way non-glic enabled platforms won't accidentally build / use files from these targets 👍
Marking as optional since this lives in the higher level c/b/glic/BUILD.gn which already asserts this. Mainly want to be on the safe side if someone pulls files specifically from this target for whatever reason
Attention is currently required from:
- Maggie Jennings
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:41 PM (4 hours ago) 7:41 PM
to Ian Wells, Darryl James, Maggie Jennings, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org, dfried...@chromium.org, estali...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/ui/BUILD.gn
Insertions: 4, Deletions: 4.
The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/ui/views/tabs/glic/BUILD.gn
Insertions: 4, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Create chrome/browser/ui/views/tabs/glic directory
Bypass-Check-License: renamed files
Bug: 475863782
Change-Id: Ib34ab10bbf05899d3daaed06648076a2c89e6525
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Ian Wells <iwe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1569436}
Files:
- M chrome/browser/background/glic/BUILD.gn
- M chrome/browser/background/glic/glic_status_icon_interactive_uitest.cc
- M chrome/browser/contextual_cueing/contextual_cueing_helper_interactive_uitest.cc
- M chrome/browser/glic/BUILD.gn
- M chrome/browser/glic/browser_ui/BUILD.gn
- M chrome/browser/glic/browser_ui/context_sharing_border_view_interactive_uitest.cc
- M chrome/browser/glic/browser_ui/scoped_glic_button_indicator.cc
- M chrome/browser/glic/browser_ui/tab_underline_view_interactive_uitest.cc
- M chrome/browser/glic/glic_policy_browsertest.cc
- M chrome/browser/glic/widget/glic_view.cc
- M chrome/browser/glic/widget/glic_widget.cc
- M chrome/browser/glic/widget/glic_window_animator.cc
- M chrome/browser/glic/widget/glic_window_animator.h
- M chrome/browser/glic/widget/glic_window_controller_impl.cc
- M chrome/browser/glic/widget/glic_window_controller_interactive_uitest.cc
- M chrome/browser/ui/BUILD.gn
- M chrome/browser/ui/views/frame/horizontal_tab_strip_region_view.cc
- A chrome/browser/ui/views/tabs/glic/BUILD.gn
- A chrome/browser/ui/views/tabs/glic/OWNERS
- R chrome/browser/ui/views/tabs/glic/glic_actor_constants.h
- R chrome/browser/ui/views/tabs/glic/glic_actor_task_icon.cc
- R chrome/browser/ui/views/tabs/glic/glic_actor_task_icon.h
- R chrome/browser/ui/views/tabs/glic/glic_and_actor_buttons_container.cc
- R chrome/browser/ui/views/tabs/glic/glic_and_actor_buttons_container.h
- R chrome/browser/ui/views/tabs/glic/glic_button.cc
- R chrome/browser/ui/views/tabs/glic/glic_button.h
- R chrome/browser/ui/views/tabs/glic/glic_button_browsertest.cc
- M chrome/browser/ui/views/tabs/tab_strip_action_container.cc
- M chrome/browser/ui/views/tabs/tab_strip_action_container.h
- M chrome/browser/ui/views/tabs/tab_strip_action_container_browsertest.cc
- M chrome/browser/ui/views/tabs/tab_strip_action_container_unittest.cc
- M chrome/browser/ui/views/user_education/browser_user_education_service.cc
- M chrome/test/BUILD.gn
Change size: M
Delta: 33 files changed, 133 insertions(+), 56 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darryl James
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages