[Drag and Drop] Implement onHover listeners for the row body and drag handle [chromium/src : main]
0 views
Skip to first unread message
Eleanor Lee (Gerrit)
Dec 22, 2025, 12:16:13 AM (5 days ago) Dec 22
to Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Eleanor Lee voted and added 1 comment![]( "Open in Gerrit")
Votes added by Eleanor Lee
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eleanor Lee (Gerrit)
Dec 22, 2025, 12:40:02 AM (5 days ago) Dec 22
to Brandon Wylie, Mark Schillaci, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Brandon Wylie and Mark Schillaci
Eleanor Lee voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Brandon Wylie
- Mark Schillaci
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Schillaci (Gerrit)
Dec 22, 2025, 10:44:29 AM (5 days ago) Dec 22
to Eleanor Lee, Brandon Wylie, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Brandon Wylie
Mark Schillaci voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Brandon Wylie
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Wylie (Gerrit)
Dec 22, 2025, 2:29:53 PM (4 days ago) Dec 22
to Eleanor Lee, Mark Schillaci, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Eleanor Lee
Brandon Wylie voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brandon Wylie
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Eleanor Lee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eleanor Lee (Gerrit)
5:40 PM (6 hours ago) 5:40 PM
to Brandon Wylie, Mark Schillaci, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Eleanor Lee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Unit tests will be added in a chained CL.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eleanor Lee (Gerrit)
5:40 PM (6 hours ago) 5:40 PM
to Brandon Wylie, Mark Schillaci, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Eleanor Lee voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:57 PM (4 hours ago) 6:57 PM
to Eleanor Lee, Brandon Wylie, Mark Schillaci, chromium...@chromium.org, browser-comp...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Drag and Drop] Implement onHover listeners for the row body and drag handle
The link for the design doc is in the bug in comment #2.
This CL covers section 7. under "Proposed Design Changes".
After: https://screencast.googleplex.com/cast/NTUwNjY3OTU5OTc5MjEyOHwxY2IzOWE2Ni00NA
Bug: 454420485
Change-Id: I1d49cdf2351f15d16bf9522671101984921bf402
Reviewed-by: Mark Schillaci <mschi...@google.com>
Commit-Queue: Eleanor Lee <elean...@google.com>
Reviewed-by: Brandon Wylie <wyl...@google.com>
Cr-Commit-Position: refs/heads/main@{#1562808}
Files:
- M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerCoordinator.java
- M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerDragHelper.java
Change size: M
Delta: 2 files changed, 65 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Schillaci, +1 by Brandon Wylie
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages