[Drag and Drop] Implement onHover listeners for the row body and drag handle [chromium/src : main]

0 views
Skip to first unread message

Eleanor Lee (Gerrit)

unread,
Dec 22, 2025, 12:16:13 AM (5 days ago) Dec 22
to Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org

Eleanor Lee voted and added 1 comment

Votes added by Eleanor Lee

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2:
Eleanor Lee . unresolved

Unit tests will be added in a chained CL.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1d49cdf2351f15d16bf9522671101984921bf402
Gerrit-Change-Number: 7296551
Gerrit-PatchSet: 2
Gerrit-Owner: Eleanor Lee <elean...@google.com>
Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 05:16:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eleanor Lee (Gerrit)

unread,
Dec 22, 2025, 12:40:02 AM (5 days ago) Dec 22
to Brandon Wylie, Mark Schillaci, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Brandon Wylie and Mark Schillaci

Eleanor Lee voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Wylie
  • Mark Schillaci
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1d49cdf2351f15d16bf9522671101984921bf402
Gerrit-Change-Number: 7296551
Gerrit-PatchSet: 4
Gerrit-Owner: Eleanor Lee <elean...@google.com>
Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Brandon Wylie <wyl...@google.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 05:39:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Schillaci (Gerrit)

unread,
Dec 22, 2025, 10:44:29 AM (5 days ago) Dec 22
to Eleanor Lee, Brandon Wylie, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Brandon Wylie

Mark Schillaci voted and added 1 comment

Votes added by Mark Schillaci

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Mark Schillaci . resolved

lgtm! thanks eleanor!

Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Wylie
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1d49cdf2351f15d16bf9522671101984921bf402
    Gerrit-Change-Number: 7296551
    Gerrit-PatchSet: 4
    Gerrit-Owner: Eleanor Lee <elean...@google.com>
    Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
    Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
    Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
    Gerrit-Attention: Brandon Wylie <wyl...@google.com>
    Gerrit-Comment-Date: Mon, 22 Dec 2025 15:44:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Brandon Wylie (Gerrit)

    unread,
    Dec 22, 2025, 2:29:53 PM (4 days ago) Dec 22
    to Eleanor Lee, Mark Schillaci, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
    Attention needed from Eleanor Lee

    Brandon Wylie voted and added 1 comment

    Votes added by Brandon Wylie

    Code-Review+1

    1 comment

    Patchset-level comments
    Brandon Wylie . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eleanor Lee
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1d49cdf2351f15d16bf9522671101984921bf402
    Gerrit-Change-Number: 7296551
    Gerrit-PatchSet: 4
    Gerrit-Owner: Eleanor Lee <elean...@google.com>
    Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
    Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
    Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
    Gerrit-Attention: Eleanor Lee <elean...@google.com>
    Gerrit-Comment-Date: Mon, 22 Dec 2025 19:29:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Eleanor Lee (Gerrit)

    unread,
    5:40 PM (6 hours ago) 5:40 PM
    to Brandon Wylie, Mark Schillaci, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org

    Eleanor Lee added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2:
    Eleanor Lee . resolved

    Unit tests will be added in a chained CL.

    Eleanor Lee

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1d49cdf2351f15d16bf9522671101984921bf402
      Gerrit-Change-Number: 7296551
      Gerrit-PatchSet: 5
      Gerrit-Owner: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
      Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
      Gerrit-Comment-Date: Fri, 26 Dec 2025 22:40:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Eleanor Lee <elean...@google.com>
      satisfied_requirement
      open
      diffy

      Eleanor Lee (Gerrit)

      unread,
      5:40 PM (6 hours ago) 5:40 PM
      to Brandon Wylie, Mark Schillaci, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org

      Eleanor Lee voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1d49cdf2351f15d16bf9522671101984921bf402
      Gerrit-Change-Number: 7296551
      Gerrit-PatchSet: 5
      Gerrit-Owner: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
      Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
      Gerrit-Comment-Date: Fri, 26 Dec 2025 22:40:19 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      6:57 PM (4 hours ago) 6:57 PM
      to Eleanor Lee, Brandon Wylie, Mark Schillaci, chromium...@chromium.org, browser-comp...@chromium.org

      Chromium LUCI CQ submitted the change

      Unreviewed changes

      4 is the latest approved patch-set.
      No files were changed between the latest approved patch-set and the submitted one.

      Change information

      Commit message:
      [Drag and Drop] Implement onHover listeners for the row body and drag handle

      The link for the design doc is in the bug in comment #2.

      This CL covers section 7. under "Proposed Design Changes".

      After: https://screencast.googleplex.com/cast/NTUwNjY3OTU5OTc5MjEyOHwxY2IzOWE2Ni00NA
      Bug: 454420485
      Change-Id: I1d49cdf2351f15d16bf9522671101984921bf402
      Reviewed-by: Mark Schillaci <mschi...@google.com>
      Commit-Queue: Eleanor Lee <elean...@google.com>
      Reviewed-by: Brandon Wylie <wyl...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1562808}
      Files:
      • M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerCoordinator.java
      • M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerDragHelper.java
      Change size: M
      Delta: 2 files changed, 65 insertions(+), 2 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Mark Schillaci, +1 by Brandon Wylie
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1d49cdf2351f15d16bf9522671101984921bf402
      Gerrit-Change-Number: 7296551
      Gerrit-PatchSet: 6
      Gerrit-Owner: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages