Re-enable NavigationManagerTest.EmptyWindowOpenNavigation [chromium/src : main]

0 views
Skip to first unread message

Mike Dougherty (Gerrit)

unread,
Jun 27, 2025, 6:13:15 PMJun 27
to Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org

New activity on the change

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I67f8800c7e37c1dcad6255788c902eac421b8095
Gerrit-Change-Number: 6684339
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Dougherty <mich...@chromium.org>
Gerrit-Reviewer: Mike Dougherty <mich...@chromium.org>
Gerrit-Comment-Date: Fri, 27 Jun 2025 22:13:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Louis Romero (Gerrit)

unread,
Jun 30, 2025, 4:13:30 PMJun 30
to Mike Dougherty, Louis Romero, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Mike Dougherty

Louis Romero voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mike Dougherty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I67f8800c7e37c1dcad6255788c902eac421b8095
    Gerrit-Change-Number: 6684339
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mike Dougherty <mich...@chromium.org>
    Gerrit-Reviewer: Louis Romero <lpro...@google.com>
    Gerrit-Reviewer: Mike Dougherty <mich...@chromium.org>
    Gerrit-Attention: Mike Dougherty <mich...@chromium.org>
    Gerrit-Comment-Date: Mon, 30 Jun 2025 20:13:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Mike Dougherty (Gerrit)

    unread,
    Jun 30, 2025, 7:41:26 PMJun 30
    to Louis Romero, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org

    Mike Dougherty voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I67f8800c7e37c1dcad6255788c902eac421b8095
    Gerrit-Change-Number: 6684339
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mike Dougherty <mich...@chromium.org>
    Gerrit-Reviewer: Louis Romero <lpro...@google.com>
    Gerrit-Reviewer: Mike Dougherty <mich...@chromium.org>
    Gerrit-Comment-Date: Mon, 30 Jun 2025 23:41:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 30, 2025, 7:50:37 PMJun 30
    to Mike Dougherty, Louis Romero, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Re-enable NavigationManagerTest.EmptyWindowOpenNavigation
    Bug: 425579167
    Change-Id: I67f8800c7e37c1dcad6255788c902eac421b8095
    Reviewed-by: Louis Romero <lpro...@google.com>
    Commit-Queue: Mike Dougherty <mich...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1480803}
    Files:
    Change size: XS
    Delta: 1 file changed, 4 insertions(+), 4 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Louis Romero
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I67f8800c7e37c1dcad6255788c902eac421b8095
    Gerrit-Change-Number: 6684339
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mike Dougherty <mich...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Louis Romero <lpro...@google.com>
    Gerrit-Reviewer: Mike Dougherty <mich...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages