Move more actor files to build on Android [chromium/src : main]

0 views
Skip to first unread message

Min Qin (Gerrit)

unread,
2:39 PM (9 hours ago) 2:39 PM
to Siddhartha S, David Bokan, chromium...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Siddhartha S

Min Qin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Siddhartha S
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4a9f12f6389a03a492813dfc4035114b5ea1a23
Gerrit-Change-Number: 7298486
Gerrit-PatchSet: 3
Gerrit-Owner: Siddhartha S <ss...@chromium.org>
Gerrit-Reviewer: David Bokan <bo...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-Attention: Siddhartha S <ss...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Dec 2025 19:39:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Siddhartha S (Gerrit)

unread,
5:30 PM (6 hours ago) 5:30 PM
to Siddhartha S, Min Qin, David Bokan, chromium...@chromium.org, mfoltz+wa...@chromium.org

Siddhartha S voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4a9f12f6389a03a492813dfc4035114b5ea1a23
Gerrit-Change-Number: 7298486
Gerrit-PatchSet: 3
Gerrit-Owner: Siddhartha S <ss...@chromium.org>
Gerrit-Reviewer: David Bokan <bo...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Dec 2025 22:30:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Siddhartha S (Gerrit)

unread,
8:20 PM (3 hours ago) 8:20 PM
to Siddhartha S, Chromium LUCI CQ, Min Qin, David Bokan, chromium...@chromium.org, mfoltz+wa...@chromium.org

Siddhartha S voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4a9f12f6389a03a492813dfc4035114b5ea1a23
Gerrit-Change-Number: 7298486
Gerrit-PatchSet: 5
Gerrit-Owner: Siddhartha S <ss...@chromium.org>
Gerrit-Reviewer: David Bokan <bo...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
Gerrit-Comment-Date: Sat, 27 Dec 2025 01:19:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
9:54 PM (1 hour ago) 9:54 PM
to Siddhartha S, Min Qin, David Bokan, chromium...@chromium.org, mfoltz+wa...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/actor/BUILD.gn
Insertions: 1, Deletions: 0.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
Move more actor files to build on Android
Bug: 470475787, 465208148
Change-Id: Id4a9f12f6389a03a492813dfc4035114b5ea1a23
Reviewed-by: Min Qin <qin...@chromium.org>
Commit-Queue: Siddhartha S <ss...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1562829}
Files:
  • M chrome/browser/BUILD.gn
  • M chrome/browser/actor/BUILD.gn
Change size: S
Delta: 2 files changed, 22 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Min Qin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4a9f12f6389a03a492813dfc4035114b5ea1a23
Gerrit-Change-Number: 7298486
Gerrit-PatchSet: 6
Gerrit-Owner: Siddhartha S <ss...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Bokan <bo...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages