[Media Capture] use JniType WebContents to simplify c++ implementations [chromium/src : main]

0 views
Skip to first unread message

Grace Cham (Gerrit)

unread,
Jun 24, 2026, 2:42:22 AM (yesterday) Jun 24
to Calder Kitagawa, Tomas Gunnarsson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Calder Kitagawa and Tomas Gunnarsson

Grace Cham voted and added 1 comment

Votes added by Grace Cham

Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
  • Tomas Gunnarsson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I331ac1d5177badf58d09948a8265ab2b6156a952
Gerrit-Change-Number: 7989754
Gerrit-PatchSet: 2
Gerrit-Owner: Grace Cham <hsc...@chromium.org>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Tomas Gunnarsson <to...@chromium.org>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 06:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tomas Gunnarsson (Gerrit)

unread,
Jun 24, 2026, 4:19:01 AM (yesterday) Jun 24
to Grace Cham, Calder Kitagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Calder Kitagawa and Grace Cham

Tomas Gunnarsson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
  • Grace Cham
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I331ac1d5177badf58d09948a8265ab2b6156a952
    Gerrit-Change-Number: 7989754
    Gerrit-PatchSet: 2
    Gerrit-Owner: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Grace Cham <hsc...@chromium.org>
    Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 08:18:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Calder Kitagawa (Gerrit)

    unread,
    Jun 24, 2026, 7:41:58 AM (yesterday) Jun 24
    to Grace Cham, Tomas Gunnarsson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org
    Attention needed from Grace Cham

    Calder Kitagawa voted and added 1 comment

    Votes added by Calder Kitagawa

    Code-Review+1

    1 comment

    Patchset-level comments
    Calder Kitagawa . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Grace Cham
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I331ac1d5177badf58d09948a8265ab2b6156a952
    Gerrit-Change-Number: 7989754
    Gerrit-PatchSet: 2
    Gerrit-Owner: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Grace Cham <hsc...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 11:41:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Grace Cham (Gerrit)

    unread,
    Jun 24, 2026, 9:18:52 PM (12 hours ago) Jun 24
    to Calder Kitagawa, Tomas Gunnarsson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org

    Grace Cham voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I331ac1d5177badf58d09948a8265ab2b6156a952
    Gerrit-Change-Number: 7989754
    Gerrit-PatchSet: 2
    Gerrit-Owner: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Comment-Date: Thu, 25 Jun 2026 01:18:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 24, 2026, 9:23:25 PM (12 hours ago) Jun 24
    to Grace Cham, Calder Kitagawa, Tomas Gunnarsson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Media Capture] use JniType WebContents to simplify c++ implementations
    Bug: None
    Test: builds
    Change-Id: I331ac1d5177badf58d09948a8265ab2b6156a952
    Reviewed-by: Tomas Gunnarsson <to...@chromium.org>
    Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
    Commit-Queue: Grace Cham <hsc...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1652111}
    Files:
    • M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureDevicesDispatcherAndroid.java
    • M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCapturePickerManagerBridge.java
    • M chrome/browser/android/media/media_capture_devices_dispatcher_android.cc
    • M chrome/browser/media/android/media_capture_picker_manager_bridge.cc
    • M chrome/browser/media/android/media_capture_picker_manager_bridge.h
    Change size: M
    Delta: 5 files changed, 37 insertions(+), 58 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tomas Gunnarsson, +1 by Calder Kitagawa
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I331ac1d5177badf58d09948a8265ab2b6156a952
    Gerrit-Change-Number: 7989754
    Gerrit-PatchSet: 3
    Gerrit-Owner: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages