[Media Capture] use JniType WebContents to simplify c++ implementations [chromium/src : main]
0 views
Skip to first unread message
Grace Cham (Gerrit)
Jun 24, 2026, 2:42:22 AM (yesterday) Jun 24
to Calder Kitagawa, Tomas Gunnarsson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Calder Kitagawa and Tomas Gunnarsson
Grace Cham voted and added 1 comment![]( "Open in Gerrit")
Votes added by Grace Cham
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Grace Cham . resolved
Hi! This is a follow-up to Calder's comment on https://chromium-review.git.corp.google.com/c/chromium/src/+/7966279/comment/738ffd04_7bf59136/, PTAL, thanks!
Related details
Attention is currently required from:
- Calder Kitagawa
- Tomas Gunnarsson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tomas Gunnarsson (Gerrit)
Jun 24, 2026, 4:19:01 AM (yesterday) Jun 24
to Grace Cham, Calder Kitagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Calder Kitagawa and Grace Cham
Tomas Gunnarsson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Calder Kitagawa
- Grace Cham
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Calder Kitagawa (Gerrit)
Jun 24, 2026, 7:41:58 AM (yesterday) Jun 24
to Grace Cham, Tomas Gunnarsson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Grace Cham
Calder Kitagawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Calder Kitagawa
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Grace Cham
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Grace Cham (Gerrit)
Jun 24, 2026, 9:18:52 PM (12 hours ago) Jun 24
to Calder Kitagawa, Tomas Gunnarsson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org
Grace Cham voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 24, 2026, 9:23:25 PM (12 hours ago) Jun 24
to Grace Cham, Calder Kitagawa, Tomas Gunnarsson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Media Capture] use JniType WebContents to simplify c++ implementations
Bug: None
Test: builds
Change-Id: I331ac1d5177badf58d09948a8265ab2b6156a952
Reviewed-by: Tomas Gunnarsson <to...@chromium.org>
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Commit-Queue: Grace Cham <hsc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1652111}
Files:
- M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureDevicesDispatcherAndroid.java
- M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCapturePickerManagerBridge.java
- M chrome/browser/android/media/media_capture_devices_dispatcher_android.cc
- M chrome/browser/media/android/media_capture_picker_manager_bridge.cc
- M chrome/browser/media/android/media_capture_picker_manager_bridge.h
Change size: M
Delta: 5 files changed, 37 insertions(+), 58 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tomas Gunnarsson, +1 by Calder Kitagawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages