Update brave.com entries in src/AUTHORS [chromium/src : main]
Mikhail Atuchin (Gerrit)
Mikhail Atuchin added 1 comment![]( "Open in Gerrit")
We have signed Google Corporate CLA so we need to update `AUTHORS` to replace individual entries to `*.brave.com`.
The instruction tells about adding entries, but not about updating them.`Please include this as part of your first patch and not as a separate standalone patch`.
If it's against the rules I can connect it to my other CL.
Also, is it possible to get dry run (CQ +1) access for *.brave.com accounts?
Related details
- Daniel Cheng
- Mike Dougherty
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Daniel Cheng voted Code-Review+1![]( "Open in Gerrit")
- Mike Dougherty
- Mikhail Atuchin
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Daniel Cheng added 1 comment![]( "Open in Gerrit")
We have signed Google Corporate CLA so we need to update `AUTHORS` to replace individual entries to `*.brave.com`.
The instruction tells about adding entries, but not about updating them.`Please include this as part of your first patch and not as a separate standalone patch`.
If it's against the rules I can connect it to my other CL.Also, is it possible to get dry run (CQ +1) access for *.brave.com accounts?
I think updating this as a standalone is fine.
As for CQ+1 access, I am not sure how that would work. I'll ask around.
Related details
- Mike Dougherty
- Mikhail Atuchin
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Atuchin (Gerrit)
Mikhail Atuchin added 1 comment![]( "Open in Gerrit")
Daniel ChengWe have signed Google Corporate CLA so we need to update `AUTHORS` to replace individual entries to `*.brave.com`.
The instruction tells about adding entries, but not about updating them.`Please include this as part of your first patch and not as a separate standalone patch`.
If it's against the rules I can connect it to my other CL.Also, is it possible to get dry run (CQ +1) access for *.brave.com accounts?
I think updating this as a standalone is fine.
As for CQ+1 access, I am not sure how that would work. I'll ask around.
Thanks @dch...@chromium.org.
BTW, when I worked for Yandex (`*.yandex-team.ru`) we have CQ+1 by default, so I assume it isn't a special request.
Related details
- Mike Dougherty
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Dougherty (Gerrit)
Mike Dougherty voted Code-Review+1![]( "Open in Gerrit")
- Mikhail Atuchin
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rick Byers (Gerrit)
Rick Byers added 1 comment![]( "Open in Gerrit")
Daniel ChengWe have signed Google Corporate CLA so we need to update `AUTHORS` to replace individual entries to `*.brave.com`.
The instruction tells about adding entries, but not about updating them.`Please include this as part of your first patch and not as a separate standalone patch`.
If it's against the rules I can connect it to my other CL.Also, is it possible to get dry run (CQ +1) access for *.brave.com accounts?
Mikhail AtuchinI think updating this as a standalone is fine.
As for CQ+1 access, I am not sure how that would work. I'll ask around.
Thanks @dch...@chromium.org.
BTW, when I worked for Yandex (`*.yandex-team.ru`) we have CQ+1 by default, so I assume it isn't a special request.
Hey Mikhail,
As far as I know, CQ+1 is granted on an account-by-account basis following the instructions here: https://www.chromium.org/getting-involved/become-a-committer/#try-job-access. I've nominated you for access (actually not even really nomination since you already had it - you just have a new e-mail address and affiliation, but your status in the chromium project comes with you). I've also asked whether *@brave.com is possible - perhaps I'm just unaware.
Thanks for continuing to contribute to Chromium!
Rick
Related details
- Mikhail Atuchin
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |