Switch App-Bound tests to use ServiceEnvironment [chromium/src : main]
0 views
Skip to first unread message
Will Harris (Gerrit)
12:09 AM (23 hours ago) 12:09 AM
to Will Harris, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, net-r...@chromium.org
Attention needed from Avi Drissman
Will Harris added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
2:27 PM (9 hours ago) 2:27 PM
to Will Harris, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, net-r...@chromium.org
Attention needed from Will Harris
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Will Harris
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Will Harris (Gerrit)
4:09 PM (7 hours ago) 4:09 PM
to Will Harris, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, net-r...@chromium.org
Will Harris voted and added 1 comment![]( "Open in Gerrit")
Votes added by Will Harris
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:11 PM (7 hours ago) 4:11 PM
to Will Harris, Avi Drissman, chromium...@chromium.org, AyeAye, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Switch App-Bound tests to use ServiceEnvironment
The test utilities provided by service_program/test_support can do
everything needed to install and manage the elevated service.
This CL therefore removes the calls from the os_crypt test_support
library and switches all tests to use the ServiceEnvironment instead.
ServiceEnvironment is extended slightly to take multiple extra switches
as one test requires this.
No behavior change is expected. This is also a test-only change.
BUG=40227925
Change-Id: Ia6a63416a5af5047e4ba908fb4fd95293d2ef23a
Commit-Queue: Will Harris <w...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1581369}
Files:
- M chrome/browser/net/DEPS
- M chrome/browser/net/cookie_encryption_provider_interactive_uitest.cc
- M chrome/browser/os_crypt/BUILD.gn
- M chrome/browser/os_crypt/DEPS
- M chrome/browser/os_crypt/app_bound_encryption_win_browsertest.cc
- M chrome/browser/os_crypt/test_support.cc
- M chrome/browser/os_crypt/test_support.h
- M chrome/windows_services/elevated_tracing_service/elevated_tracing_service_unittest.cc
- M chrome/windows_services/service_program/test_support/service_environment.cc
- M chrome/windows_services/service_program/test_support/service_environment.h
Change size: M
Delta: 10 files changed, 56 insertions(+), 91 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Avi Drissman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages