[ios] Fix RestoreIOSLiveTab description [chromium/src : main]

0 views
Skip to first unread message

Sylvain Defresne (Gerrit)

unread,
11:34 AM (5 hours ago) 11:34 AM
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org
Attention needed from Colin Blundell

Sylvain Defresne voted and added 1 comment

Votes added by Sylvain Defresne

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sylvain Defresne . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3487a1a01b9784bb515577f32b650fee53fa71c6
Gerrit-Change-Number: 6983294
Gerrit-PatchSet: 1
Gerrit-Owner: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:34:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
11:49 AM (5 hours ago) 11:49 AM
to Sylvain Defresne, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org
Attention needed from Sylvain Defresne

Colin Blundell voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sylvain Defresne
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3487a1a01b9784bb515577f32b650fee53fa71c6
    Gerrit-Change-Number: 6983294
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 15:49:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    12:00 PM (4 hours ago) 12:00 PM
    to Sylvain Defresne, Colin Blundell, chromium...@chromium.org, ios-r...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [ios] Fix RestoreIOSLiveTab description

    The class RestoreIOSLiveTab has been using web::proto::NavigationStorage
    insteadof web::CRWSessionStorage for a long time. Update the description.
    Bug: 40945317
    Change-Id: I3487a1a01b9784bb515577f32b650fee53fa71c6
    Commit-Queue: Sylvain Defresne <sdef...@chromium.org>
    Auto-Submit: Sylvain Defresne <sdef...@chromium.org>
    Reviewed-by: Colin Blundell <blun...@chromium.org>
    Commit-Queue: Colin Blundell <blun...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1520649}
    Files:
    • M components/sessions/ios/ios_restore_live_tab.h
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Colin Blundell
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3487a1a01b9784bb515577f32b650fee53fa71c6
    Gerrit-Change-Number: 6983294
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages