Revert "Use location dialog for save as context menu option" [chromium/src : main]

0 views
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 18, 2026, 3:50:39 AM (yesterday) Jul 18
to Sinan Sahin, Sirisha Kavuluru, Michael Thiessen, Chromium LUCI CQ, Min Qin, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, Chromium Metrics Reviews
Attention needed from Michael Thiessen, Min Qin, Sinan Sahin and Sirisha Kavuluru

luci-bi...@appspot.gserviceaccount.com has uploaded the change for review

luci-bi...@appspot.gserviceaccount.com would like Sinan Sahin, Sirisha Kavuluru, Michael Thiessen, Chromium LUCI CQ and Min Qin to review this change.

Commit message

Revert "Use location dialog for save as context menu option"

This reverts commit eb27df1a5a6065c1ec44fba0efce5a464884c8f7.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6024579932749824

Sample build with failed test: https://ci.chromium.org/b/8675964117528832577
Affected test(s):
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.contextmenu:ContextMenuTest#testCopyEmailAddress](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.contextmenu:ContextMenuTest%23testCopyEmailAddress?q=VHash%3A9d2db2838dc1d70b)
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.contextmenu:ContextMenuTest#testSaveDataUrl](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.contextmenu:ContextMenuTest%23testSaveDataUrl?q=VHash%3A9d2db2838dc1d70b)
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.contextmenu:ContextMenuTest#testSaveImage](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.contextmenu:ContextMenuTest%23testSaveImage?q=VHash%3A9d2db2838dc1d70b)
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.contextmenu:ContextMenuTest#testSaveVideo](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.contextmenu:ContextMenuTest%23testSaveVideo?q=VHash%3A9d2db2838dc1d70b)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6024579932749824&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7929089&type=BUG

Original change's description:
> Use location dialog for save as context menu option
>
> This CL changes the "download" context menu option into "save as" on
> Android desktop platforms to match the existing Chrome OS and desktop
> behavior. Clicking on that menu option will trigger the location dialog
> to allow user specify the file name they want to save.
>
> Bug: 524228780,
> Change-Id: I51090f19459f8a3e537f05ff9f2089254f20e590
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7929089
> Reviewed-by: Sinan Sahin <sinan...@google.com>
> Commit-Queue: Min Qin <qin...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1664314}
>
Bug: 524228780,
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I52a6f0f63fa565af4882d8ab82eb78c5a7dd4049

Change diff


Change information

Files:
  • M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java
  • M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java
  • M chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuMediatorTest.java
  • M chrome/browser/chrome_browser_field_trials.cc
  • M chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/dialogs/DownloadLocationDialogCoordinator.java
  • M chrome/browser/download/chrome_download_manager_delegate.cc
  • M chrome/browser/download/download_dialog_types.h
  • M chrome/browser/flags/android/chrome_feature_list.cc
  • M chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
  • M chrome/browser/ui/android/strings/android_chrome_strings.grd
  • D chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_CONTEXTMENU_SAVE_IMAGE_AS.png.sha1
  • D chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_CONTEXTMENU_SAVE_LINK_AS.png.sha1
  • D chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_CONTEXTMENU_SAVE_VIDEO_AS.png.sha1
  • D chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_CONTEXTMENU_SAVE_VIDEO_FRAME_AS.png.sha1
  • M components/download/content/internal/context_menu_download.cc
  • M components/download/public/common/download_features.cc
  • M components/download/public/common/download_features.h
  • M tools/metrics/histograms/metadata/mobile/enums.xml
Change size: M
Delta: 18 files changed, 8 insertions(+), 125 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Thiessen
  • Min Qin
  • Sinan Sahin
  • Sirisha Kavuluru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I52a6f0f63fa565af4882d8ab82eb78c5a7dd4049
Gerrit-Change-Number: 8120785
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michael Thiessen <mthi...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-Reviewer: Sinan Sahin <sinan...@google.com>
Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Sinan Sahin <sinan...@google.com>
Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Michael Thiessen <mthi...@chromium.org>
Gerrit-Attention: Min Qin <qin...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 18, 2026, 3:51:02 AM (yesterday) Jul 18
to rubber-...@appspot.gserviceaccount.com, Sinan Sahin, Sirisha Kavuluru, Michael Thiessen, Chromium LUCI CQ, Min Qin, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, Chromium Metrics Reviews, srahim...@chromium.org, asvitkine...@chromium.org, dtraino...@chromium.org
Attention needed from Michael Thiessen, Min Qin, Sinan Sahin and Sirisha Kavuluru

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Thiessen
  • Min Qin
  • Sinan Sahin
  • Sirisha Kavuluru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I52a6f0f63fa565af4882d8ab82eb78c5a7dd4049
Gerrit-Change-Number: 8120785
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michael Thiessen <mthi...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-Reviewer: Sinan Sahin <sinan...@google.com>
Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Sinan Sahin <sinan...@google.com>
Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Michael Thiessen <mthi...@chromium.org>
Gerrit-Attention: Min Qin <qin...@chromium.org>
Gerrit-Comment-Date: Sat, 18 Jul 2026 07:50:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 18, 2026, 3:51:16 AM (yesterday) Jul 18
to luci-bi...@appspot.gserviceaccount.com, Sinan Sahin, Sirisha Kavuluru, Michael Thiessen, Chromium LUCI CQ, Min Qin, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, Chromium Metrics Reviews, srahim...@chromium.org, asvitkine...@chromium.org, dtraino...@chromium.org
Attention needed from Michael Thiessen, Min Qin, Sinan Sahin and Sirisha Kavuluru

Related details

Attention is currently required from:
  • Michael Thiessen
  • Min Qin
  • Sinan Sahin
  • Sirisha Kavuluru
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I52a6f0f63fa565af4882d8ab82eb78c5a7dd4049
    Gerrit-Change-Number: 8120785
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Michael Thiessen <mthi...@chromium.org>
    Gerrit-Reviewer: Min Qin <qin...@chromium.org>
    Gerrit-Reviewer: Sinan Sahin <sinan...@google.com>
    Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Sinan Sahin <sinan...@google.com>
    Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Attention: Michael Thiessen <mthi...@chromium.org>
    Gerrit-Attention: Min Qin <qin...@chromium.org>
    Gerrit-Comment-Date: Sat, 18 Jul 2026 07:51:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Min Qin (Gerrit)

    unread,
    Jul 18, 2026, 3:23:22 PM (16 hours ago) Jul 18
    to luci-bi...@appspot.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Sinan Sahin, Sirisha Kavuluru, Michael Thiessen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, Chromium Metrics Reviews, srahim...@chromium.org, asvitkine...@chromium.org, dtraino...@chromium.org
    Attention needed from Michael Thiessen, Sinan Sahin and Sirisha Kavuluru

    Min Qin voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Thiessen
    • Sinan Sahin
    • Sirisha Kavuluru
    Gerrit-Comment-Date: Sat, 18 Jul 2026 19:23:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Min Qin (Gerrit)

    unread,
    Jul 18, 2026, 3:28:06 PM (16 hours ago) Jul 18
    to luci-bi...@appspot.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Sinan Sahin, Sirisha Kavuluru, Michael Thiessen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, Chromium Metrics Reviews, srahim...@chromium.org, asvitkine...@chromium.org, dtraino...@chromium.org
    Attention needed from Michael Thiessen, Sinan Sahin and Sirisha Kavuluru

    Min Qin voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Sat, 18 Jul 2026 19:27:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages