[Popular Sites] Use V7 by default at ToT [chromium/src : main]
0 views
Skip to first unread message
Samuel Huang (Gerrit)
Mar 20, 2026, 12:12:29 PM (4 days ago) Mar 20
to Calder Kitagawa, Tibor Goldschwendt, Chromium LUCI CQ, chromium...@chromium.org, ntp-dev...@chromium.org
Attention needed from Calder Kitagawa and Tibor Goldschwendt
Samuel Huang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Calder Kitagawa
- Tibor Goldschwendt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Calder Kitagawa (Gerrit)
Mar 20, 2026, 12:18:40 PM (4 days ago) Mar 20
to Samuel Huang, Tibor Goldschwendt, Chromium LUCI CQ, chromium...@chromium.org, ntp-dev...@chromium.org
Attention needed from Samuel Huang and Tibor Goldschwendt
Calder Kitagawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Calder Kitagawa
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Samuel Huang
- Tibor Goldschwendt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Huang (Gerrit)
Mar 23, 2026, 11:57:23 AM (yesterday) Mar 23
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, ntp-dev...@chromium.org
Attention needed from Moe Ahmadi
Samuel Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Huang
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Moe Ahmadi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Moe Ahmadi (Gerrit)
7:42 AM (11 hours ago) 7:42 AM
to Samuel Huang, Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, ntp-dev...@chromium.org
Attention needed from Samuel Huang
Moe Ahmadi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Moe Ahmadi
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Samuel Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Huang (Gerrit)
11:19 AM (8 hours ago) 11:19 AM
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, ntp-dev...@chromium.org
Samuel Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Huang
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:23 AM (7 hours ago) 11:23 AM
to Samuel Huang, Calder Kitagawa, chromium...@chromium.org, ntp-dev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Popular Sites] Use V7 by default at ToT
Popular Sites version 7 has been experimented with via Finch and is
ready for launch. This CL makes V7 the hardcoded default at ToT by
updating `kPopularSitesDefaultVersion` from 5 to 7.
This change ensures that all future releases of Chrome will use V7
natively. Following this, the Finch experiment will be ramped up to 100%
for older versions, using the Chrome version from this CL's landing as
the `max_version` for the server-side study.
The `NTPPopularSites` entry in `fieldtrial_testing_config.json` was
previously removed in crrev.com/c/7653396 as part of a general cleanup
and is not re-added here.
Test coverage in `popular_sites_impl_unittest.cc` is updated to reflect
the new default version, while preserving tests for legacy version
parsing and transitions (e.g., V5 to V6).
Bug: 494297303
Change-Id: Ie1622a41da495fbcc7d0772f7b9fc1db46df10fe
Commit-Queue: Samuel Huang <hua...@chromium.org>
Reviewed-by: Moe Ahmadi <mah...@chromium.org>
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1604143}
Files:
- M components/ntp_tiles/popular_sites_impl.cc
- M components/ntp_tiles/popular_sites_impl_unittest.cc
Change size: M
Delta: 2 files changed, 38 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Moe Ahmadi, +1 by Calder Kitagawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages