recovery: Fix an issue cause re-image via usbkey fail on new usbkey [infra/infra : main]
0 views
Skip to first unread message
Garry Wang (Gerrit)
Aug 9, 2022, 12:03:13 AM8/9/22
to Vineet Joshi, Xixuan Wu, Gregory Nisbet, chromium...@chromium.org
Attention is currently required from: Gregory Nisbet, Xixuan Wu.
2 comments:
Commit Message:
Patch Set #2, Line 7:
imaeg"imaeg" --> "image"
Done
Patch Set #2, Line 12:
imaeg"imaeg" --> "image"
Done
To view, visit change 3813515. To unsubscribe, or for help writing mail filters, visit settings.
Xixuan Wu (Gerrit)
Aug 9, 2022, 12:46:58 AM8/9/22
to Garry Wang, Vineet Joshi, Gregory Nisbet, chromium...@chromium.org
Attention is currently required from: Gregory Nisbet, Xixuan Wu.
Patch set 3:Commit-Queue +2
Xixuan Wu (Gerrit)
Aug 9, 2022, 12:47:03 AM8/9/22
to Garry Wang, Vineet Joshi, Gregory Nisbet, chromium...@chromium.org
Attention is currently required from: Garry Wang, Gregory Nisbet.
Patch set 3:Code-Review +1-Commit-Queue
Garry Wang (Gerrit)
Aug 9, 2022, 1:00:20 AM8/9/22
to LUCI CQ, Xixuan Wu, Vineet Joshi, Gregory Nisbet, chromium...@chromium.org
Attention is currently required from: Gregory Nisbet.
Patch set 3:Commit-Queue +2
LUCI CQ (Gerrit)
Aug 9, 2022, 1:03:26 AM8/9/22
to Garry Wang, Xixuan Wu, Vineet Joshi, Gregory Nisbet, chromium...@chromium.org
LUCI CQ submitted this change.
Approvals:
Garry Wang: Commit
Xixuan Wu: Looks good to me
Vineet Joshi: Looks good to me
recovery: Fix an issue cause re-image via usbkey fail on new usbkey
"Servo has USB-key with require image" has a recoveryAction to download
stable_version image, however when it's used as dependency then the
recoveryAction won't get triggered. This CL adds another action to
ensure that we have expected image before re-image DUT.
BUG=b:241845548
TEST=go test ./... and run mallet local-recovery
Change-Id: I1f12e414a9d46bac11fa81f02bee21922e8dfbb4
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/3813515
Reviewed-by: Vineet Joshi <vkj...@google.com>
Commit-Queue: Garry Wang <xianu...@chromium.org>
Reviewed-by: Xixuan Wu <xix...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#50792}
---
M go/src/infra/cros/recovery/config/config_cros_repair.go
M go/src/infra/cros/recovery/internal/execs/cros/cros_install_exec.go
2 files changed, 54 insertions(+), 1 deletion(-)
Reply all
Reply to author
Forward
0 new messages