Add "Report an unsafe site" app menu item 3/X [chromium/src : main]
0 views
Skip to first unread message
Peter Kotwicz (Gerrit)
Feb 5, 2026, 9:43:48 PM (2 days ago) Feb 5
to Dana Fried, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, srahim...@chromium.org
Attention needed from Dana Fried
Peter Kotwicz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Peter Kotwicz . resolved
dfried@ can you please take a look? I am splitting the CL you looked at into 5 sub CLs. The entire feature will likely be implemented over 12ish CLs
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Feb 6, 2026, 9:40:17 AM (yesterday) Feb 6
to Peter Kotwicz, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, srahim...@chromium.org
Attention needed from Peter Kotwicz
Dana Fried added 2 comments![]( "Open in Gerrit")
File chrome/browser/ui/browser_commands.cc
Line 2359, Patchset 5 (Latest):
base::RecordAction(UserMetricsAction("ReportUnsafeSite_AppMenu"));Dana Fried . unresolved
nit: this naming convention doesn't seem to match any other app menu actions
File chrome/browser/ui/toolbar/app_menu_model.cc
Line 957, Patchset 5 (Latest):
if (feedback::ReportUnsafeSiteDialog::IsEnabled(*browser->profile())) {Dana Fried . unresolved
Should we wrap this in a GOOGLE_CHROME_BRANDING check as well?
Related details
Attention is currently required from:
- Peter Kotwicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kotwicz (Gerrit)
Feb 6, 2026, 10:58:30 AM (yesterday) Feb 6
to Dana Fried, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, srahim...@chromium.org
Attention needed from Dana Fried
Peter Kotwicz added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Peter Kotwicz . resolved
dfried@ can you please take another look?
File chrome/browser/ui/browser_commands.cc
Line 2359, Patchset 5:
base::RecordAction(UserMetricsAction("ReportUnsafeSite_AppMenu"));Dana Fried . resolved
nit: this naming convention doesn't seem to match any other app menu actions
Peter Kotwicz
Removed _AppMenu suffix
File chrome/browser/ui/toolbar/app_menu_model.cc
Line 957, Patchset 5:
if (feedback::ReportUnsafeSiteDialog::IsEnabled(*browser->profile())) {Dana Fried . resolved
Should we wrap this in a GOOGLE_CHROME_BRANDING check as well?
Peter Kotwicz
Put IDC_FEEDBACK inside the GOOGLE_CHROME_BRANDING check as well. Let's see if the tests pass. The help menu isn't created at all for non-branded builds.
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Feb 6, 2026, 11:55:19 AM (yesterday) Feb 6
to Peter Kotwicz, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, srahim...@chromium.org
Attention needed from Peter Kotwicz
Dana Fried voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Peter Kotwicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kotwicz (Gerrit)
7:13 PM (4 hours ago) 7:13 PM
to Dana Fried, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, srahim...@chromium.org
Peter Kotwicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kotwicz (Gerrit)
7:30 PM (4 hours ago) 7:30 PM
to Chromium LUCI CQ, Dana Fried, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, srahim...@chromium.org
Attention needed from Dana Fried
Peter Kotwicz voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages