Fix testSignInWithManagedDataTypes flakiness [chromium/src : main]

0 views
Skip to first unread message

Mahmoud Rashad (Gerrit)

unread,
Sep 25, 2025, 7:55:43 AM (23 hours ago) Sep 25
to Ankush Singh, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Ankush Singh

Mahmoud Rashad voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ankush Singh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1320d4078b1f491837012ca94558b54198da8e43
Gerrit-Change-Number: 6983206
Gerrit-PatchSet: 2
Gerrit-Owner: Mahmoud Rashad <mmra...@google.com>
Gerrit-Reviewer: Ankush Singh <ankus...@google.com>
Gerrit-Reviewer: Mahmoud Rashad <mmra...@google.com>
Gerrit-Attention: Ankush Singh <ankus...@google.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 11:55:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ankush Singh (Gerrit)

unread,
Sep 25, 2025, 12:27:21 PM (18 hours ago) Sep 25
to Mahmoud Rashad, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Mahmoud Rashad

Ankush Singh voted and added 1 comment

Votes added by Ankush Singh

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Ankush Singh . resolved

Let's give it a shot!

Open in Gerrit

Related details

Attention is currently required from:
  • Mahmoud Rashad
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1320d4078b1f491837012ca94558b54198da8e43
    Gerrit-Change-Number: 6983206
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Reviewer: Ankush Singh <ankus...@google.com>
    Gerrit-Reviewer: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Attention: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 16:27:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Mahmoud Rashad (Gerrit)

    unread,
    Sep 25, 2025, 2:24:30 PM (16 hours ago) Sep 25
    to Ankush Singh, Chromium LUCI CQ, chromium...@chromium.org

    Mahmoud Rashad voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1320d4078b1f491837012ca94558b54198da8e43
    Gerrit-Change-Number: 6983206
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Reviewer: Ankush Singh <ankus...@google.com>
    Gerrit-Reviewer: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 18:24:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 25, 2025, 2:27:20 PM (16 hours ago) Sep 25
    to Mahmoud Rashad, Ankush Singh, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fix testSignInWithManagedDataTypes flakiness

    This test is flaky at least on android-16-x64-rel[1]. The post test
    screenshot is just a black screen. The test fails when Espresso tries to
    verify something on the UI. According to the post test screenshot, this
    could be the settings screen didn't load yet.

    [1]
    https://luci-milo.appspot.com/ui/tests/p/chromium/rules/6b2ed33a65acddbabdceacf95f9615bb?tab=recent-failures&filterToMetric=builds-failed-due-to-flaky-tests&groupBy=builder&orderBy=invocationFailures
    Bug: 444011887
    Change-Id: I1320d4078b1f491837012ca94558b54198da8e43
    Reviewed-by: Ankush Singh <ankus...@google.com>
    Commit-Queue: Mahmoud Rashad <mmra...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1520767}
    Files:
    • M chrome/android/javatests/src/org/chromium/chrome/browser/sync/settings/ManageSyncSettingsTest.java
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Ankush Singh
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1320d4078b1f491837012ca94558b54198da8e43
    Gerrit-Change-Number: 6983206
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mahmoud Rashad <mmra...@google.com>
    Gerrit-Reviewer: Ankush Singh <ankus...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mahmoud Rashad <mmra...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages