Sharing: Refactor SharingFCMSender to extract SendMessageViaSync [chromium/src : main]
0 views
Skip to first unread message
Wei Guo (Gerrit)
Apr 13, 2026, 8:40:10 PM (15 hours ago) Apr 13
to Tommy Nyquist, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org
Wei Guo voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikel Astiz (Gerrit)
4:33 AM (7 hours ago) 4:33 AM
to Wei Guo, Tommy Nyquist, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org
Attention needed from Wei Guo
Mikel Astiz voted and added 3 comments![]( "Open in Gerrit")
Votes added by Mikel Astiz
| Code-Review | +1 |
3 comments
Patchset-level comments
File components/sharing_message/sharing_fcm_sender.cc
Line 246, Patchset 5 (Latest):
fcm->set_priority(10);Mikel Astiz . unresolved
Would it be possible to move the code above to the caller (`SendMessageToFcmTarget()`) and directly bind `SendMessageViaSync()` when invoking `EncryptMessage()`? Assuming this would allow removing `DoSendMessageToSenderIdTarget()` and `DoSendMessageToServerTarget()`, leading to `DoXXX()` functions being exclusively used for `SendMessageDelegate` overrides.
Line 270, Patchset 5 (Latest):
specifics->set_payload(message);Mikel Astiz . unresolved
Nit: could we also `std::move()` this to avoid copies, for consistency with the above?
Related details
Attention is currently required from:
- Wei Guo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages