Add @NullMarked to chrome/android/j/s/o/c/c/b/services/gcm [chromium/src : main]

0 views
Skip to first unread message

Shu Yang (Gerrit)

unread,
Sep 4, 2025, 9:04:36 PM (3 days ago) Sep 4
to Andrew Grieve, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium LUCI CQ
Attention needed from Andrew Grieve

Shu Yang added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I50e23a30b90072cbe5f9da65d486d442da002346
Gerrit-Change-Number: 6918155
Gerrit-PatchSet: 1
Gerrit-Owner: Shu Yang <shu...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Shu Yang <shu...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 01:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Sep 4, 2025, 9:05:52 PM (3 days ago) Sep 4
to Shu Yang, Andrew Grieve, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium LUCI CQ
Attention needed from Shu Yang

Andrew Grieve voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shu Yang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I50e23a30b90072cbe5f9da65d486d442da002346
    Gerrit-Change-Number: 6918155
    Gerrit-PatchSet: 1
    Gerrit-Owner: Shu Yang <shu...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Shu Yang <shu...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Shu Yang <shu...@google.com>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 01:05:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Grieve (Gerrit)

    unread,
    Sep 4, 2025, 9:05:58 PM (3 days ago) Sep 4
    to Shu Yang, Andrew Grieve, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium LUCI CQ
    Attention needed from Shu Yang

    Andrew Grieve voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Shu Yang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I50e23a30b90072cbe5f9da65d486d442da002346
    Gerrit-Change-Number: 6918155
    Gerrit-PatchSet: 1
    Gerrit-Owner: Shu Yang <shu...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Shu Yang <shu...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Shu Yang <shu...@google.com>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 01:05:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Shu Yang (Gerrit)

    unread,
    Sep 4, 2025, 9:06:34 PM (3 days ago) Sep 4
    to Andrew Grieve, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium LUCI CQ

    Shu Yang voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I50e23a30b90072cbe5f9da65d486d442da002346
    Gerrit-Change-Number: 6918155
    Gerrit-PatchSet: 1
    Gerrit-Owner: Shu Yang <shu...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Shu Yang <shu...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 01:06:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 4, 2025, 9:10:00 PM (3 days ago) Sep 4
    to Shu Yang, Andrew Grieve, AyeAye, chromium...@chromium.org, Peter Beverloo

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add @NullMarked to chrome/android/j/s/o/c/c/b/services/gcm
    Bug: 389129271
    Change-Id: I50e23a30b90072cbe5f9da65d486d442da002346
    Owners-Override: Andrew Grieve <agr...@chromium.org>
    Reviewed-by: Andrew Grieve <agr...@chromium.org>
    Commit-Queue: Shu Yang <shu...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1511254}
    Files:
    • M chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerServiceImpl.java
    • M chrome/android/java/src/org/chromium/chrome/browser/services/gcm/GCMBackgroundServiceImpl.java
    • M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMMessage.java
    Change size: S
    Delta: 3 files changed, 20 insertions(+), 6 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Andrew Grieve
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I50e23a30b90072cbe5f9da65d486d442da002346
    Gerrit-Change-Number: 6918155
    Gerrit-PatchSet: 2
    Gerrit-Owner: Shu Yang <shu...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Shu Yang <shu...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages