[iframe] Fix resetting the size for cross-origin navigation [chromium/src : main]
0 views
Skip to first unread message
Koji Ishii (Gerrit)
Jun 16, 2026, 3:06:17 PM (12 days ago) Jun 16
to Ian Kilpatrick, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Ian Kilpatrick and Kent Tamura
Koji Ishii added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Koji Ishii . resolved
PTAL. Ian, this is what we discussed, about resetting to the default size.
Related details
Attention is currently required from:
- Ian Kilpatrick
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jun 16, 2026, 8:19:04 PM (12 days ago) Jun 16
to Koji Ishii, Kent Tamura, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Ian Kilpatrick and Koji Ishii
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian Kilpatrick
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Jun 16, 2026, 11:25:28 PM (12 days ago) Jun 16
to Rakina Zata Amni, Chromium IPC Reviews, Kent Tamura, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Chromium IPC Reviews, Ian Kilpatrick and Rakina Zata Amni
Koji Ishii added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Koji Ishii . resolved
Rakina, PTAL content/renderer/frame_owner_properties_converter.cc
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Ian Kilpatrick
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jun 16, 2026, 11:26:31 PM (12 days ago) Jun 16
to Koji Ishii, Chromium IPC Reviews, Hidehiko Abe, Rakina Zata Amni, Kent Tamura, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Hidehiko Abe, Ian Kilpatrick and Rakina Zata Amni
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: hide...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): hide...@chromium.org
Reviewer source(s):
hide...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Hidehiko Abe
- Ian Kilpatrick
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jun 17, 2026, 3:35:38 AM (11 days ago) Jun 17
to Koji Ishii, Chromium IPC Reviews, Rakina Zata Amni, Kent Tamura, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Ian Kilpatrick, Koji Ishii and Rakina Zata Amni
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
File third_party/blink/public/mojom/frame/frame_owner_properties.mojom
Line 11, Patchset 9 (Latest):
enum FrameResponsiveSizing {Hidehiko Abe . unresolved
could you elaborate the meaning of each element?
(while it says this is calculated from new CSS frame-sizing property, but it looks not trivial 1-1-onto mapping).
Related details
Attention is currently required from:
- Ian Kilpatrick
- Koji Ishii
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Jun 17, 2026, 3:50:49 AM (11 days ago) Jun 17
to Koji Ishii, Chromium IPC Reviews, Hidehiko Abe, Kent Tamura, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Ian Kilpatrick and Koji Ishii
Rakina Zata Amni voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ian Kilpatrick
- Koji Ishii
Koji Ishii (Gerrit)
Jun 17, 2026, 4:09:05 AM (11 days ago) Jun 17
to Rakina Zata Amni, Chromium IPC Reviews, Hidehiko Abe, Kent Tamura, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Hidehiko Abe and Ian Kilpatrick
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Commit-Queue | +0 |
1 comment
File third_party/blink/public/mojom/frame/frame_owner_properties.mojom
Line 11, Patchset 9:
enum FrameResponsiveSizing {Hidehiko Abe . unresolved
could you elaborate the meaning of each element?
(while it says this is calculated from new CSS frame-sizing property, but it looks not trivial 1-1-onto mapping).
Attention is currently required from:
- Hidehiko Abe
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jun 17, 2026, 5:00:01 AM (11 days ago) Jun 17
to Koji Ishii, Rakina Zata Amni, Chromium IPC Reviews, Kent Tamura, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Ian Kilpatrick and Koji Ishii
Hidehiko Abe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hidehiko Abe
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Ian Kilpatrick
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Jun 17, 2026, 11:12:24 PM (11 days ago) Jun 17
to Koji Ishii, Hidehiko Abe, Rakina Zata Amni, Chromium IPC Reviews, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Koji Ishii
Ian Kilpatrick voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Koji Ishii
Koji Ishii (Gerrit)
Jun 18, 2026, 12:10:00 AM (11 days ago) Jun 18
to Ian Kilpatrick, Hidehiko Abe, Rakina Zata Amni, Chromium IPC Reviews, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Koji Ishii (Gerrit)
Jun 18, 2026, 12:15:16 AM (11 days ago) Jun 18
to Ian Kilpatrick, Hidehiko Abe, Rakina Zata Amni, Chromium IPC Reviews, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Commit-Queue | +2 |
1 comment
File third_party/blink/public/mojom/frame/frame_owner_properties.mojom
Line 11, Patchset 9:
enum FrameResponsiveSizing {Hidehiko Abe . resolved
Koji Ishiicould you elaborate the meaning of each element?
(while it says this is calculated from new CSS frame-sizing property, but it looks not trivial 1-1-onto mapping).
Thanks for pointing it out, added comments to clarify.
Koji Ishii
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 12:24:27 AM (10 days ago) Jun 18
to Koji Ishii, Ian Kilpatrick, Hidehiko Abe, Rakina Zata Amni, Chromium IPC Reviews, Kent Tamura, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iframe] Fix resetting the size for cross-origin navigation
This patch is a follow up to crrev.com/c/7893591 to more
stably reset the size for cross-origin navigation.
The part crrev.com/c/7929354 disabled was flaky because the
child is laid out before the mojo message reaches the parent
and the parent is laid out.
To prevent leaking the size from the previous document, this
patch resets the size of the child frame to the default size
synchronously in the child document.
To constrain this behavior only for the content of the
responsively-sized iframes, the value of the `frame-sizing`
property is added to `FrameOwnerProperties`, leveraging the
already existing cross-process syncing pipeline.
Bug: 418397278, 522312787
Change-Id: I688cd34c40b9dfa5db6ce58cb9e07c7e94853f8e
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Commit-Queue: Koji Ishii <ko...@chromium.org>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648789}
Files:
- M content/renderer/frame_owner_properties_converter.cc
- M third_party/blink/public/mojom/frame/frame_owner_properties.mojom
- M third_party/blink/public/web/web_frame_owner_properties.h
- M third_party/blink/renderer/core/frame/frame.cc
- M third_party/blink/renderer/core/frame/frame_owner.h
- M third_party/blink/renderer/core/frame/remote_frame_owner.cc
- M third_party/blink/renderer/core/frame/remote_frame_owner.h
- M third_party/blink/renderer/core/frame/web_local_frame_impl.cc
- M third_party/blink/renderer/core/html/html_frame_owner_element.cc
- M third_party/blink/renderer/core/html/html_frame_owner_element.h
- M third_party/blink/renderer/core/loader/document_loader.cc
- M third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
- M third_party/blink/web_tests/VirtualTestSuites
- M third_party/blink/web_tests/external/wpt/css/css-sizing/responsive-iframe/responsive-iframe-navigation.html
Change size: M
Delta: 14 files changed, 126 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura, +1 by Ian Kilpatrick, +1 by Rakina Zata Amni, +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 18, 2026, 6:38:56 PM (10 days ago) Jun 18
to Chromium LUCI CQ, Koji Ishii, Ian Kilpatrick, Hidehiko Abe, Rakina Zata Amni, Chromium IPC Reviews, Kent Tamura, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60729
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages