Make StyleRuleBase::Clone() always clone [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Apr 13, 2026, 9:06:14 AM (yesterday) Apr 13
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson
Anders Hartvoll Ruud voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steinar H Gunderson (Gerrit)
Apr 13, 2026, 9:34:18 AM (yesterday) Apr 13
to Anders Hartvoll Ruud, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Steinar H Gunderson added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/css/style_rule.cc
Line 709, Patchset 1 (Parent):
if (!old_inner_rule || !old_inner_rule->ChildRules()) {Steinar H Gunderson . unresolved
I don't think this is right. Why do you need this for kContents and kApplyMixin? Their contents is always cloned in RuleSet::AddChildRules(), so why do you need to clone them again here?
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
4:37 AM (7 hours ago) 4:37 AM
to chromiu...@luci-project-accounts.iam.gserviceaccount.com, Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson
Anders Hartvoll Ruud added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/css/style_rule.cc
Line 709, Patchset 1 (Parent):
if (!old_inner_rule || !old_inner_rule->ChildRules()) {Steinar H Gunderson . resolved
I don't think this is right. Why do you need this for kContents and kApplyMixin? Their contents is always cloned in RuleSet::AddChildRules(), so why do you need to clone them again here?
Anders Hartvoll Ruud
`Clone()` needs to actually clone due to `StyleSheetContents` unsharing. What `AddChildRules()` does isn't really relevant.
Related details
Attention is currently required from:
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages