Unsuppress ext-color-buffer-half-float.html. [chromium/src : main]

1 view
Skip to first unread message

Kenneth Russell (Gerrit)

unread,
Jul 1, 2022, 5:38:53 PM7/1/22
to Rubber Stamper, Alexey Knyazev, Gregg Tavares, Maggie Chen, Yuly Novikov, chromium...@chromium.org

View Change

1 comment:

  • Patchset:

    • Patch Set #1:

      FYI all. Seeing whether this test passes everywhere now.

To view, visit change 3741403. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
Gerrit-Change-Number: 3741403
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Russell <k...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
Gerrit-CC: Gregg Tavares <gm...@chromium.org>
Gerrit-CC: Maggie Chen <mag...@chromium.org>
Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
Gerrit-Comment-Date: Fri, 01 Jul 2022 21:38:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Rubber Stamper (Gerrit)

unread,
Jul 1, 2022, 5:39:08 PM7/1/22
to Kenneth Russell, Chromium LUCI CQ, Alexey Knyazev, Gregg Tavares, Maggie Chen, Yuly Novikov, chromium...@chromium.org

Patch set 1:Bot-Commit +1

View Change

    To view, visit change 3741403. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
    Gerrit-Change-Number: 3741403
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kenneth Russell <k...@chromium.org>
    Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
    Gerrit-CC: Gregg Tavares <gm...@chromium.org>
    Gerrit-CC: Maggie Chen <mag...@chromium.org>
    Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
    Gerrit-Comment-Date: Fri, 01 Jul 2022 21:39:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Rubber Stamper (Gerrit)

    unread,
    Jul 1, 2022, 9:13:11 PM7/1/22
    to Kenneth Russell, Chromium LUCI CQ, Alexey Knyazev, Gregg Tavares, Maggie Chen, Yuly Novikov, chromium...@chromium.org

    Attention is currently required from: Kenneth Russell.

    Patch set 2:Bot-Commit +1

    View Change

      To view, visit change 3741403. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
      Gerrit-Change-Number: 3741403
      Gerrit-PatchSet: 2
      Gerrit-Owner: Kenneth Russell <k...@chromium.org>
      Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
      Gerrit-CC: Gregg Tavares <gm...@chromium.org>
      Gerrit-CC: Maggie Chen <mag...@chromium.org>
      Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
      Gerrit-Attention: Kenneth Russell <k...@chromium.org>
      Gerrit-Comment-Date: Sat, 02 Jul 2022 01:13:01 +0000

      Rubber Stamper (Gerrit)

      unread,
      Jul 1, 2022, 9:16:07 PM7/1/22
      to Kenneth Russell, Chromium LUCI CQ, Alexey Knyazev, Gregg Tavares, Maggie Chen, Yuly Novikov, chromium...@chromium.org

      Attention is currently required from: Kenneth Russell.

      Patch set 3:Bot-Commit +1

      View Change

        To view, visit change 3741403. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
        Gerrit-Change-Number: 3741403
        Gerrit-PatchSet: 3
        Gerrit-Owner: Kenneth Russell <k...@chromium.org>
        Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
        Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
        Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
        Gerrit-CC: Gregg Tavares <gm...@chromium.org>
        Gerrit-CC: Maggie Chen <mag...@chromium.org>
        Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
        Gerrit-Attention: Kenneth Russell <k...@chromium.org>
        Gerrit-Comment-Date: Sat, 02 Jul 2022 01:16:01 +0000

        Kenneth Russell (Gerrit)

        unread,
        Jul 1, 2022, 9:16:20 PM7/1/22
        to Rubber Stamper, Chromium LUCI CQ, Alexey Knyazev, Gregg Tavares, Maggie Chen, Yuly Novikov, chromium...@chromium.org

        Attention is currently required from: Kenneth Russell.

        Patch set 3:Commit-Queue +2

        View Change

          To view, visit change 3741403. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
          Gerrit-Change-Number: 3741403
          Gerrit-PatchSet: 3
          Gerrit-Owner: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
          Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
          Gerrit-CC: Gregg Tavares <gm...@chromium.org>
          Gerrit-CC: Maggie Chen <mag...@chromium.org>
          Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
          Gerrit-Attention: Kenneth Russell <k...@chromium.org>
          Gerrit-Comment-Date: Sat, 02 Jul 2022 01:16:13 +0000

          Chromium LUCI CQ (Gerrit)

          unread,
          Jul 1, 2022, 10:52:51 PM7/1/22
          to Kenneth Russell, Rubber Stamper, Alexey Knyazev, Gregg Tavares, Maggie Chen, Yuly Novikov, chromium...@chromium.org

          Chromium LUCI CQ submitted this change.

          View Change



          1 is the latest approved patch-set.
          The change was submitted with unreviewed changes in the following files:

          ```
          The name of the file: content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
          Insertions: 4, Deletions: 1.

          @@ -431,7 +431,8 @@
          crbug.com/1152602 [ win amd-0x7340 angle-d3d11 ] conformance/canvas/drawingbuffer-static-canvas-test.html [ RetryOnFailure ]

          # Win / D3D9 failures
          -# Skipping these two tests because they're causing assertion failures.
          +# Won't investigate this failure - D3D9 backend's effectively obsolete.
          +crbug.com/angleproject/5038 [ win angle-d3d9 ] conformance/extensions/ext-color-buffer-half-float.html [ Failure ]

          # The functions test have been persistently flaky on D3D9
          crbug.com/956134 [ win angle-d3d9 ] conformance/extensions/webgl-depth-texture.html [ Failure ]
          @@ -709,6 +710,8 @@
          crbug.com/1232446 [ chromeos chromeos-board-amd64-generic ] conformance/rendering/gl-scissor-test.html [ Failure ]
          crbug.com/1271227 [ chromeos chromeos-board-amd64-generic ] conformance/attribs/gl-bindAttribLocation-aliasing.html [ RetryOnFailure ]

          +# Failures on validating command decoder only; won't fix.
          +crbug.com/angleproject/5038 [ chromeos no-passthrough ] conformance/extensions/ext-color-buffer-half-float.html [ Failure ]

          ###########################
          # Lacros/Wayland failures #
          ```

          Approvals: Rubber Stamper: Looks good to me Kenneth Russell: Commit
          Unsuppress ext-color-buffer-half-float.html.

          conformance/extensions/ext-color-buffer-half-float.html is passing
          on all desired configurations with the latest ANGLE fixes.

          Permanently suppress on Win/D3D9, which is obsolete, and ChromeOS
          with the validating command decoder, as passthrough+ANGLE will ship
          there soon.

          Bug: angleproject:5038
          Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
          Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3741403
          Commit-Queue: Kenneth Russell <k...@chromium.org>
          Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
          Cr-Commit-Position: refs/heads/main@{#1020335}
          ---
          M content/test/gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt
          M content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
          2 files changed, 25 insertions(+), 3 deletions(-)


          To view, visit change 3741403. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
          Gerrit-Change-Number: 3741403
          Gerrit-PatchSet: 4
          Gerrit-Owner: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
          Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
          Gerrit-CC: Gregg Tavares <gm...@chromium.org>
          Gerrit-CC: Maggie Chen <mag...@chromium.org>
          Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
          Gerrit-MessageType: merged

          Maggie Chen (Gerrit)

          unread,
          Jul 2, 2022, 2:16:38 AM7/2/22
          to Chromium LUCI CQ, Kenneth Russell, Rubber Stamper, Alexey Knyazev, Gregg Tavares, Yuly Novikov, chromium...@chromium.org

          View Change

          1 comment:

          • Patchset:

            • Patch Set #4:

              Hi Ken, gpu_tests.webgl_conformance_integration_test ext-color-buffer-half-float.html fails. Now all GPU Android FYI bots turn red.

          To view, visit change 3741403. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
          Gerrit-Change-Number: 3741403
          Gerrit-PatchSet: 4
          Gerrit-Owner: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
          Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
          Gerrit-CC: Gregg Tavares <gm...@chromium.org>
          Gerrit-CC: Maggie Chen <mag...@chromium.org>
          Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
          Gerrit-Comment-Date: Sat, 02 Jul 2022 06:16:28 +0000

          Alexey Knyazev (Gerrit)

          unread,
          Jul 2, 2022, 4:40:59 AM7/2/22
          to Chromium LUCI CQ, Kenneth Russell, Rubber Stamper, Gregg Tavares, Maggie Chen, Yuly Novikov, chromium...@chromium.org

          Attention is currently required from: Kenneth Russell.

          View Change

          1 comment:

          • Patchset:

            • Patch Set #4:

              Hi Ken, gpu_tests.webgl_conformance_integration_test ext-color-buffer-half-float.html fails. […]

              Ken, the test does fail on several GLES drivers when creating a L/A/LA texture from a floating-point buffer. We should either workaround that in ANGLE (there are likely two ways of doing that) or allow `INVALID_OPERATION` in the extension spec and WebGL CTS.

          To view, visit change 3741403. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
          Gerrit-Change-Number: 3741403
          Gerrit-PatchSet: 4
          Gerrit-Owner: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
          Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
          Gerrit-CC: Gregg Tavares <gm...@chromium.org>
          Gerrit-CC: Maggie Chen <mag...@chromium.org>
          Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
          Gerrit-Attention: Kenneth Russell <k...@chromium.org>
          Gerrit-Comment-Date: Sat, 02 Jul 2022 08:40:47 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Maggie Chen <mag...@chromium.org>
          Gerrit-MessageType: comment

          Maggie Chen (Gerrit)

          unread,
          Jul 2, 2022, 4:22:13 PM7/2/22
          to Chromium LUCI CQ, Kenneth Russell, Rubber Stamper, Alexey Knyazev, Gregg Tavares, Yuly Novikov, chromium...@chromium.org

          Attention is currently required from: Kenneth Russell.

          Maggie Chen has created a revert of this change.

          View Change

          To view, visit change 3741403. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
          Gerrit-Change-Number: 3741403
          Gerrit-PatchSet: 4
          Gerrit-Owner: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
          Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
          Gerrit-CC: Alexey Knyazev <lexa.k...@gmail.com>
          Gerrit-CC: Gregg Tavares <gm...@chromium.org>
          Gerrit-CC: Maggie Chen <mag...@chromium.org>
          Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
          Gerrit-Attention: Kenneth Russell <k...@chromium.org>
          Gerrit-MessageType: revert
          Reply all
          Reply to author
          Forward
          0 new messages