Remove AnchoredNudgeController [chromium/src : main]
0 views
Skip to first unread message
Ian Wells (Gerrit)
6:30 PM (4 hours ago) 6:30 PM
to Sophie Chang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org
Attention needed from Sophie Chang
Ian Wells voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ian Wells
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Wells (Gerrit)
6:31 PM (4 hours ago) 6:31 PM
to Marke Hallowell, Sophie Chang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org
Attention needed from Marke Hallowell and Sophie Chang
Ian Wells added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Marke Hallowell
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marke Hallowell (Gerrit)
6:38 PM (4 hours ago) 6:38 PM
to Ian Wells, Sophie Chang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org
Attention needed from Ian Wells and Sophie Chang
Marke Hallowell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marke Hallowell
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Ian Wells
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Chang (Gerrit)
7:12 PM (4 hours ago) 7:12 PM
to Ian Wells, Marke Hallowell, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org
Attention needed from Ian Wells and Marke Hallowell
Sophie Chang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian Wells
- Marke Hallowell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Wells (Gerrit)
7:34 PM (3 hours ago) 7:34 PM
to Sophie Chang, Marke Hallowell, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org
Attention needed from Marke Hallowell
Ian Wells voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ian Wells
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Marke Hallowell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
8:50 PM (2 hours ago) 8:50 PM
to Ian Wells, Sophie Chang, Marke Hallowell, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dewitt...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove AnchoredNudgeController
Anchored message cues for Glic will be provided by ContextualCueingV2
instead. UpdateNudgeLabel() no longer needs an anchored message param so
that's removed too.
Bug: 485296140
Change-Id: I5ec74a791d4f7963187c56e4d70fee2da3ee0348
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Commit-Queue: Ian Wells <iwe...@chromium.org>
Reviewed-by: Marke Hallowell <w...@chromium.org>
Auto-Submit: Ian Wells <iwe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659183}
Files:
- M chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator.cc
- M chrome/browser/glic/browser_ui/BUILD.gn
- D chrome/browser/glic/browser_ui/anchored_nudge_controller.cc
- D chrome/browser/glic/browser_ui/anchored_nudge_controller.h
- M chrome/browser/glic/browser_ui/glic_nudge_controller.h
- M chrome/browser/glic/browser_ui/glic_nudge_controller_android.cc
- M chrome/browser/glic/browser_ui/glic_nudge_controller_android.h
- M chrome/browser/glic/browser_ui/glic_nudge_controller_android_browsertest.cc
- M chrome/browser/glic/browser_ui/glic_nudge_controller_desktop.cc
- M chrome/browser/glic/browser_ui/glic_nudge_controller_desktop.h
- M chrome/browser/glic/browser_ui/glic_nudge_controller_interactive_uitest.cc
- M chrome/browser/glic/glic_selection_observer.cc
- M chrome/browser/glic/public/glic_passkeys.h
- M chrome/browser/glic/suggestions/contextual_cueing_features.cc
- M chrome/browser/glic/suggestions/contextual_cueing_features.h
- M chrome/browser/glic/suggestions/contextual_cueing_helper.cc
- M chrome/browser/glic/suggestions/contextual_cueing_helper_browsertest.cc
- M chrome/browser/record_replay/chrome_record_replay_client.cc
- M chrome/browser/ui/views/omnibox/omnibox_context_menu.cc
- M chrome/browser/ui/views/tabs/tab_strip_action_container_unittest.cc
Change size: L
Delta: 20 files changed, 32 insertions(+), 296 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sophie Chang, +1 by Marke Hallowell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages